lockdown frontend readonly UI for jupyter far more

Author: williamstein

src/packages/frontend/frame-editors/frame-tree/commands/generic-commands.tsx

@@ -208,6 +208,7 @@ addCommands({
     }),
   },
   undo: {
+    disabled: ({ readOnly }) => readOnly,
     stayOpenOnClick: true,
     group: "undo-redo",
     pos: 0,
@@ -225,6 +226,7 @@ addCommands({
     },
   },
   redo: {
+    disabled: ({ readOnly }) => readOnly,
     stayOpenOnClick: true,
     group: "undo-redo",
     pos: 1,
@@ -560,6 +562,7 @@ addCommands({
   },
 
   delete: {
+    disabled: ({ readOnly }) => readOnly,
     group: "delete",
     icon: "trash",
     title: "Delete this file",
@@ -568,6 +571,7 @@ addCommands({
   },
 
   rename: {
+    disabled: ({ readOnly }) => readOnly,
     pos: 0,
     group: "misc-file-actions",
     icon: "swap",
@@ -600,6 +604,7 @@ addCommands({
     ...fileAction("copy"),
   },
   move_file: {
+    disabled: ({ readOnly }) => readOnly,
     pos: 4,
     group: "misc-file-actions",
     icon: "move",
@@ -687,6 +692,7 @@ addCommands({
   },
   save: {
     pos: 0,
+    disabled: ({ readOnly }) => readOnly,
     group: "save",
     icon: "save",
     title: "Save this file to disk",
@@ -709,7 +715,7 @@ addCommands({
     pos: 5,
     group: "help-link",
     icon: "comment",
-    label: "Chat With People or AI",
+    label: "Chat With Collaborators or AI",
     button: "Chat",
     title:
       "Open chat on the side of this file for chatting with project collaborators or AI about this file.",

src/packages/frontend/frame-editors/frame-tree/commands/manage.tsx

@@ -501,7 +501,7 @@ export class ManageCommands {
     }
     // TODO: handle when cmd.confirm is defined.
     return {
-      disabled: cmd.disabled?.(this),
+      disabled: cmd.disabled?.(this) || allChildrenAreDisabled(children),
       label,
       onClick,
       key: cmd.stayOpenOnClick ? `${key}-${STAY_OPEN_ON_CLICK}` : key,
@@ -651,3 +651,15 @@ export class ManageCommands {
     return ManageCommands.allCommandPositions;
   };
 }
+
+function allChildrenAreDisabled(children) {
+  if (children == null || children.length == 0) {
+    return false;
+  }
+  for(const child of children) {
+    if(!child.disabled) {
+      return false;
+    }
+  }
+  return true;
+}

src/packages/frontend/frame-editors/jupyter-editor/cell-notebook/cell-notebook.tsx

@@ -8,7 +8,6 @@ Frame that display a Jupyter notebook in the traditional way with input and outp
 */
 
 import { Map } from "immutable";
-
 import { Component, Rendered } from "@cocalc/frontend/app-framework";
 import { JupyterActions } from "@cocalc/frontend/jupyter/browser-actions";
 import { JupyterEditor } from "@cocalc/frontend/jupyter/main";

src/packages/frontend/frame-editors/jupyter-editor/editor.ts

@@ -474,6 +474,7 @@ const JUPYTER_MENUS = {
                 // title: `Select the ${display_name} Jupyter kernel for writing code in ${Language}.`,
                 label: Language,
                 children: [menuItem],
+                disabled: ({ readOnly }) => readOnly,
               });
             }
           };
@@ -517,6 +518,7 @@ function initMenus() {
         throw Error(`invalid Jupyter command name "${name}"`);
       }
       return {
+        disabled: cmd.r ? undefined : ({ readOnly }) => readOnly,
         button: cmd.b,
         title: cmd.t,
         label: cmd.m,