fix ipywidgets output bug involving using stable html without proper id and index set

williamstein · williamstein · commit 0ec2a120d080 · 2024-08-21T20:22:35.000Z
diff --git a/src/packages/frontend/jupyter/output-messages/mime-types/html.tsx b/src/packages/frontend/jupyter/output-messages/mime-types/html.tsx
@@ -13,7 +13,15 @@ const Html = ({
   index?: number;
   trust?: boolean;
 }) => {
-  if (!trust || !requiresStableUnsafeHtml(value)) {
+  // if id and index aren't set no way to track this as stable unsafe html.
+  // This happens, e.g., right now with renderOutput with ipywidgets, which is probably OK, since usually
+  // with widgets the HTML doesn't need to be stable -- you are using widgets for state, not HTML.
+  if (
+    id == null ||
+    index == null ||
+    !trust ||
+    !requiresStableUnsafeHtml(value)
+  ) {
     return <HTML value={value} />;
   }
   return (
