server/tests: do not create and start a default proejct for a new account – just uses up resources, when not used, and add delay after creating accounts

haraldschilly · haraldschilly · commit 1e10ad74ca84 · 2025-12-11T16:33:27.000+01:00
diff --git a/src/packages/server/compute/control.test.ts b/src/packages/server/compute/control.test.ts
@@ -25,12 +25,17 @@ describe("creates account, project and a test compute server, then control it",
       firstName: "User",
       lastName: "One",
       account_id,
+      noFirstProject: true,
     });
     // Only User One:
     project_id = await createProject({
       account_id,
       title: "My First Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
   });
 
   let id;
diff --git a/src/packages/server/compute/create-server.test.ts b/src/packages/server/compute/create-server.test.ts
@@ -5,6 +5,7 @@ import createAccount from "@cocalc/server/accounts/create-account";
 import createProject from "@cocalc/server/projects/create";
 import createServer from "./create-server";
 import { CLOUDS_BY_NAME } from "@cocalc/util/db-schema/compute-servers";
+import { delay } from "awaiting";
 
 beforeAll(async () => {
   await initEphemeralDatabase();
@@ -25,12 +26,17 @@ describe("creates account, project and then compute servers in various ways", ()
       firstName: "User",
       lastName: "One",
       account_id,
+      noFirstProject: true,
     });
     // Only User One:
     project_id = await createProject({
       account_id,
       title: "My First Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
   });
 
   it("creates a compute server for project one and gets it", async () => {
diff --git a/src/packages/server/compute/get-servers.test.ts b/src/packages/server/compute/get-servers.test.ts
@@ -5,6 +5,7 @@ import createAccount from "@cocalc/server/accounts/create-account";
 import createProject from "@cocalc/server/projects/create";
 import addUserToProject from "@cocalc/server/projects/add-user-to-project";
 import createServer from "./create-server";
+import { delay } from "awaiting";
 
 beforeAll(async () => {
   await initEphemeralDatabase();
@@ -60,24 +61,34 @@ describe("creates accounts, projects, compute servers, and tests querying", () =
       firstName: "User",
       lastName: "One",
       account_id: account_id1,
+      noFirstProject: true,
     });
     await createAccount({
       email: "",
       password: "xyz",
       firstName: "User",
       lastName: "Two",
       account_id: account_id2,
+      noFirstProject: true,
     });
     // Only User One:
     project_id1 = await createProject({
       account_id: account_id1,
       title: "My First Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
     // Both users
     project_id2 = await createProject({
       account_id: account_id2,
       title: "My Second Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
     await addUserToProject({
       account_id: account_id1,
       project_id: project_id2,
diff --git a/src/packages/server/compute/maintenance/purchases/close.test.ts b/src/packages/server/compute/maintenance/purchases/close.test.ts
@@ -17,6 +17,7 @@ import {
   closePurchase,
 } from "./close";
 import { getPurchase } from "./util";
+import { delay } from "awaiting";
 
 beforeAll(async () => {
   await initEphemeralDatabase();
@@ -39,12 +40,17 @@ describe("creates account, project, test compute server, and purchase, then clos
       firstName: "User",
       lastName: "One",
       account_id,
+      noFirstProject: true,
     });
     // Only User One:
     project_id = await createProject({
       account_id,
       title: "My First Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
   });
 
   it("creates compute server on the 'test' cloud", async () => {
diff --git a/src/packages/server/compute/maintenance/purchases/manage-purchases.test.ts b/src/packages/server/compute/maintenance/purchases/manage-purchases.test.ts
@@ -60,11 +60,16 @@ describe("confirm managing of purchases works", () => {
       firstName: "User",
       lastName: "One",
       account_id,
+      noFirstProject: true,
     });
     project_id = await createProject({
       account_id,
       title: "My First Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
     const s = {
       title: "myserver",
       idle_timeout: 15,
diff --git a/src/packages/server/compute/maintenance/purchases/ongoing-purchases.test.ts b/src/packages/server/compute/maintenance/purchases/ongoing-purchases.test.ts
@@ -20,6 +20,7 @@ import {
   MAX_PURCHASE_LENGTH_MS,
 } from "./manage-purchases";
 import createPurchase from "@cocalc/server/purchases/create-purchase";
+import { delay } from "awaiting";
 
 beforeAll(async () => {
   await initEphemeralDatabase();
@@ -49,12 +50,17 @@ describe("creates account, project, test compute server, and purchase", () => {
       firstName: "User",
       lastName: "One",
       account_id,
+      noFirstProject: true,
     });
     // Only User One:
     project_id = await createProject({
       account_id,
       title: "My First Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
   });
 
   let id;
diff --git a/src/packages/server/compute/maintenance/purchases/util.test.ts b/src/packages/server/compute/maintenance/purchases/util.test.ts
@@ -5,6 +5,7 @@ import createProject from "@cocalc/server/projects/create";
 import createServer from "@cocalc/server/compute/create-server";
 import { getServer } from "@cocalc/server/compute/get-servers";
 import { setPurchaseId } from "./util";
+import { delay } from "awaiting";
 
 beforeAll(async () => {
   await initEphemeralDatabase();
@@ -26,12 +27,17 @@ describe("creates compute server then sets the purchase id and confirms it", ()
       firstName: "User",
       lastName: "One",
       account_id,
+      noFirstProject: true,
     });
     // Only User One:
     project_id = await createProject({
       account_id,
       title: "My First Project",
+      start: false,
     });
+    // sometimes above isn't noticed below, which is weird, so we put in slight delay.
+    // TODO: it's surely because of using a connection pool instead of a single connection.
+    await delay(300);
     const s = {
       title: "myserver",
       idle_timeout: 15,
diff --git a/src/packages/server/licenses/add-to-project.test.ts b/src/packages/server/licenses/add-to-project.test.ts
@@ -24,12 +24,13 @@ describe("test various cases of adding a license to a project", () => {
     project_id = await createProject({
       account_id: uuid(),
       title: "My First Project",
+      start: false,
     });
     await addLicenseToProject({ project_id, license_id });
     const pool = getPool();
     const { rows } = await pool.query(
       "SELECT site_license FROM projects WHERE project_id=$1",
-      [project_id]
+      [project_id],
     );
     expect(rows[0].site_license).toEqual({ [license_id]: {} });
   });
@@ -39,7 +40,7 @@ describe("test various cases of adding a license to a project", () => {
     const pool = getPool();
     const { rows } = await pool.query(
       "SELECT site_license FROM projects WHERE project_id=$1",
-      [project_id]
+      [project_id],
     );
     expect(rows[0].site_license).toEqual({ [license_id]: {} });
   });
@@ -50,7 +51,7 @@ describe("test various cases of adding a license to a project", () => {
     const pool = getPool();
     const { rows } = await pool.query(
       "SELECT site_license FROM projects WHERE project_id=$1",
-      [project_id]
+      [project_id],
     );
     expect(rows[0].site_license).toEqual({
       [license_id]: {},
@@ -62,12 +63,12 @@ describe("test various cases of adding a license to a project", () => {
     const pool = getPool();
     await pool.query(
       "UPDATE projects SET site_license='{}' WHERE project_id=$1",
-      [project_id]
+      [project_id],
     );
     await addLicenseToProject({ project_id, license_id });
     const { rows } = await pool.query(
       "SELECT site_license FROM projects WHERE project_id=$1",
-      [project_id]
+      [project_id],
     );
     expect(rows[0].site_license).toEqual({ [license_id]: {} });
   });
diff --git a/src/packages/server/llm/test/models.test.ts b/src/packages/server/llm/test/models.test.ts
@@ -315,6 +315,7 @@ describe("User-defined LLMs", () => {
         firstName: "Test",
         lastName: "User",
         account_id,
+        noFirstProject: true,
       });
       accountCreated = true;
     }
diff --git a/src/packages/server/projects/collaborators-ownership.test.ts b/src/packages/server/projects/collaborators-ownership.test.ts
@@ -52,6 +52,7 @@ async function createUser(emailPrefix: string): Promise<string> {
     firstName: "Test",
     lastName: "User",
     account_id,
+    noFirstProject: true,
   });
   return account_id;
 }
@@ -64,6 +65,7 @@ async function createProjectWithOwner(): Promise<{
   const projectId = await createProject({
     account_id: ownerId,
     title: "Ownership test project",
+    start: false,
   });
   return { ownerId, projectId };
 }
diff --git a/src/packages/server/projects/manage-users-owner-only.test.ts b/src/packages/server/projects/manage-users-owner-only.test.ts
@@ -52,39 +52,45 @@ describe("without site enforcement (default)", () => {
       firstName: "Owner",
       lastName: "One",
       account_id: ownerId,
+      noFirstProject: true,
     });
     await createAccount({
       email: `collab-${collaboratorId}@example.com`,
       password: "pass",
       firstName: "Collab",
       lastName: "Two",
       account_id: collaboratorId,
+      noFirstProject: true,
     });
     await createAccount({
       email: `collab-${collaboratorToRemove}@example.com`,
       password: "pass",
       firstName: "Collab",
       lastName: "Three",
       account_id: collaboratorToRemove,
+      noFirstProject: true,
     });
     await createAccount({
       email: `collab-${newCollaboratorId}@example.com`,
       password: "pass",
       firstName: "Collab",
       lastName: "Four",
       account_id: newCollaboratorId,
+      noFirstProject: true,
     });
     await createAccount({
       email: `owner-collab-${ownerCollaboratorId}@example.com`,
       password: "pass",
       firstName: "Owner",
       lastName: "Collab",
       account_id: ownerCollaboratorId,
+      noFirstProject: true,
     });
 
     projectId = await createProject({
       account_id: ownerId,
       title: "Default setting test",
+      start: false,
     });
 
     await addCollaborator({
@@ -176,39 +182,45 @@ describe("strict collaborator management site setting", () => {
       firstName: "Owner",
       lastName: "One",
       account_id: ownerId,
+      noFirstProject: true,
     });
     await createAccount({
       email: `collab-${collaboratorId}@example.com`,
       password: "pass",
       firstName: "Collab",
       lastName: "Two",
       account_id: collaboratorId,
+      noFirstProject: true,
     });
     await createAccount({
       email: `collab-${otherCollaboratorId}@example.com`,
       password: "pass",
       firstName: "Collab",
       lastName: "Three",
       account_id: otherCollaboratorId,
+      noFirstProject: true,
     });
     await createAccount({
       email: `owner-collab-${ownerCollaboratorId}@example.com`,
       password: "pass",
       firstName: "Owner",
       lastName: "Collab",
       account_id: ownerCollaboratorId,
+      noFirstProject: true,
     });
     await createAccount({
       email: `collab-remove-${collaboratorToRemoveByOwner}@example.com`,
       password: "pass",
       firstName: "Collab",
       lastName: "ToRemove",
       account_id: collaboratorToRemoveByOwner,
+      noFirstProject: true,
     });
 
     projectId = await createProject({
       account_id: ownerId,
       title: "Strict setting test",
+      start: false,
     });
 
     await addCollaborator({
diff --git a/src/packages/server/purchases/closing-date.test.ts b/src/packages/server/purchases/closing-date.test.ts
@@ -37,6 +37,7 @@ describe("basic consistency checks for closing date functions", () => {
       firstName: "Test",
       lastName: "User",
       account_id,
+      noFirstProject: true,
     });
     const d = await getClosingDay(account_id);
     expect(d).toBeGreaterThanOrEqual(1);
diff --git a/src/packages/server/purchases/edit-license.test.ts b/src/packages/server/purchases/edit-license.test.ts
@@ -42,6 +42,7 @@ describe("create a license and then edit it in various ways", () => {
       firstName: "Test",
       lastName: "User",
       account_id,
+      noFirstProject: true,
     });
     const info = getPurchaseInfo(license0);
     x.license_id = await createLicense(account_id, info);
@@ -190,6 +191,7 @@ describe("create a subscription license and edit it and confirm the subscription
       firstName: "Test",
       lastName: "User",
       account_id: item.account_id,
+      noFirstProject: true,
     });
     const client = await getPoolClient();
     await purchaseShoppingCartItem(item as any, client);
@@ -246,6 +248,7 @@ describe("testing changing the owner of a license", () => {
       firstName: "Test",
       lastName: "User",
       account_id,
+      noFirstProject: true,
     });
     const info = getPurchaseInfo(license0);
     x.license_id = await createLicense(account_id, info);
diff --git a/src/packages/server/purchases/get-purchases.test.ts b/src/packages/server/purchases/get-purchases.test.ts
@@ -33,6 +33,7 @@ describe("creates and get purchases using various options", () => {
       firstName: "Test",
       lastName: "User",
       account_id,
+      noFirstProject: true,
     });
     await createPurchase({
       account_id,
diff --git a/src/packages/server/purchases/get-service-cost.test.ts b/src/packages/server/purchases/get-service-cost.test.ts
@@ -74,7 +74,7 @@ describe("get some service costs", () => {
 
   it("throws error on invalid service", async () => {
     await expect(
-      async () => await getServiceCost("nonsense" as any)
+      async () => await getServiceCost("nonsense" as any),
     ).rejects.toThrow();
   });
 });
diff --git a/src/packages/server/purchases/get-spend-rate.test.ts b/src/packages/server/purchases/get-spend-rate.test.ts
diff --git a/src/packages/server/purchases/is-purchase-allowed.test.ts b/src/packages/server/purchases/is-purchase-allowed.test.ts
diff --git a/src/packages/server/purchases/purchase-shopping-cart-item.test.ts b/src/packages/server/purchases/purchase-shopping-cart-item.test.ts
diff --git a/src/packages/server/purchases/shift-subscription.2.test.ts b/src/packages/server/purchases/shift-subscription.2.test.ts
diff --git a/src/packages/server/purchases/student-pay.test.ts b/src/packages/server/purchases/student-pay.test.ts

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,7 @@ describe("User-defined LLMs", () => {`
`315`	`315`	`firstName: "Test",`
`316`	`316`	`lastName: "User",`
`317`	`317`	`account_id,`
	`318`	`+ noFirstProject: true,`
`318`	`319`	`});`
`319`	`320`	`accountCreated = true;`
`320`	`321`	`}`