Skip to content

Commit 2449d64

Browse files
committed
terminal: bugfix -- latest change to eliminate control codes could result in typed characters being dropped sometimes
1 parent fab669c commit 2449d64

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/packages/frontend/frame-editors/terminal-editor/connected-terminal.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -744,11 +744,17 @@ export class Terminal<T extends CodeEditorState = CodeEditorState> {
744744
}
745745

746746
init_terminal_data(): void {
747-
this.terminal.onData((data) => {
747+
this.terminal.onKey(({ key }) => {
748748
if (this.ignoreData) {
749-
return;
749+
console.log("onKey", { key });
750+
this.conn_write(key);
751+
}
752+
});
753+
this.terminal.onData((data) => {
754+
if (!this.ignoreData) {
755+
console.log("onData", { data });
756+
this.conn_write(data);
750757
}
751-
this.conn_write(data);
752758
});
753759
}
754760

src/packages/util/smc-version.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
/* autogenerated by the update_version script */
2-
exports.version=1751120452;
2+
exports.version=1751142528;

0 commit comments

Comments
 (0)