Merge remote-tracking branch 'origin/master' into api-exec-process-info

Author: haraldschilly

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,29 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.  **If the screenshots include text, make sure to also include that text separately so that we can copy and paste it and not have to type it in again!**
+
+
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

src/c.js

@@ -112,6 +112,29 @@ exports.extend_PostgreSQL = (ext) -> class PostgreSQL extends ext
                         uuid   : opts.uuid
                         cb     : (err, _ttl) =>
                             ttl = _ttl; cb(err)
+            (cb) =>
+                # double check that the blob definitely exists and has correct expire
+                # See discussion at https://github.com/sagemathinc/cocalc/issues/7715
+                # The problem is that maybe with VERY low probability somehow we extend
+                # the blob ttl at the same time that we're deleting blobs and the extend
+                # is too late and does an empty update.
+                @_query
+                    query : 'SELECT expire FROM blobs'
+                    where : "id = $::UUID" : opts.uuid
+                    cb    : (err, x) =>
+                        if err
+                            cb(err)
+                            return
+                        # some consistency checks
+                        rows = x?.rows
+                        if rows.length == 0
+                            cb("blob got removed while saving it")
+                            return
+                        if !opts.ttl and rows[0].expire
+                            cb("blob should have infinite ttl but it has expire set")
+                            return
+                        cb()
+
         ], (err) => opts.cb(err, ttl))
 
     # Used internally by save_blob to possibly extend the expire time of a blob.

src/packages/database/postgres-blobs.coffee

@@ -5,7 +5,6 @@
 
 import { Form, Switch, Tooltip } from "antd";
 import { join } from "path";
-
 import { Col, Row } from "@cocalc/frontend/antd-bootstrap";
 import { redux, useTypedRedux } from "@cocalc/frontend/app-framework";
 import { A, Loading } from "@cocalc/frontend/components";
@@ -29,7 +28,7 @@ export const AccountPreferences: React.FC = () => {
   const email_address = useTypedRedux("account", "email_address");
   const email_address_verified = useTypedRedux(
     "account",
-    "email_address_verified"
+    "email_address_verified",
   );
   const passports = useTypedRedux("account", "passports");
   const sign_out_error = useTypedRedux("account", "sign_out_error");
@@ -95,7 +94,7 @@ export const AccountPreferences: React.FC = () => {
                         .getActions("account")
                         .set_other_settings(
                           "dark_mode",
-                          !other_settings.get("dark_mode")
+                          !other_settings.get("dark_mode"),
                         );
                     }}
                     style={{

src/packages/frontend/account/account-preferences.tsx

@@ -322,6 +322,10 @@ If that doesn't work after a few minutes, try these ${doc_conn} or email ${this.
     this.set_account_table({ other_settings: { [name]: value } });
   }
 
+  set_editor_settings = (name: string, value) => {
+    this.set_account_table({ editor_settings: { [name]: value } });
+  };
+
   public set_show_purchase_form(show: boolean) {
     // this controlls the default state of the "buy a license" purchase form in account → licenses
     // by default, it's not showing up

src/packages/frontend/account/actions.ts

@@ -5,7 +5,6 @@
 
 import { Card, InputNumber } from "antd";
 import { Map } from "immutable";
-
 import { Checkbox, Panel } from "@cocalc/frontend/antd-bootstrap";
 import { Rendered, redux, useTypedRedux } from "@cocalc/frontend/app-framework";
 import {
@@ -35,6 +34,19 @@ import Tours from "./tours";
 import { useLanguageModelSetting } from "./useLanguageModelSetting";
 import { UserDefinedLLMComponent } from "./user-defined-llm";
 
+// See https://github.com/sagemathinc/cocalc/issues/5620
+// There are weird bugs with relying only on mathjax, whereas our
+// implementation of katex with a fallback to mathjax works very well.
+// This makes it so katex can't be disabled.
+const ALLOW_DISABLE_KATEX = false;
+
+export function katexIsEnabled() {
+  if (!ALLOW_DISABLE_KATEX) {
+    return true;
+  }
+  return redux.getStore("account")?.getIn(["other_settings", "katex"]) ?? true;
+}
+
 interface Props {
   other_settings: Map<string, any>;
   is_stripe_customer: boolean;
@@ -110,7 +122,10 @@ export function OtherSettings(props: Readonly<Props>): JSX.Element {
     }
   }
 
-  function render_katex(): Rendered {
+  function render_katex() {
+    if (!ALLOW_DISABLE_KATEX) {
+      return null;
+    }
     return (
       <Checkbox
         checked={!!props.other_settings.get("katex")}

src/packages/frontend/account/other-settings.tsx

@@ -523,14 +523,16 @@ export const ChatRoom: React.FC<Props> = ({ project_id, path }) => {
                 margin: "0 0 5px 0",
               }}
             />
-            <Button
-              onClick={on_send_button_click}
-              disabled={input.trim() === "" || is_uploading}
-              type="primary"
-              style={{ height: "47.5px" }}
-            >
-              <Icon name="paper-plane" /> Send
-            </Button>
+            <Tooltip title={"Send message (shift+enter)"}>
+              <Button
+                onClick={on_send_button_click}
+                disabled={input.trim() === "" || is_uploading}
+                type="primary"
+                style={{ height: "47.5px" }}
+              >
+                <Icon name="paper-plane" /> Send
+              </Button>
+            </Tooltip>
             <div style={{ height: "5px" }} />
             <Button
               onClick={() => actions.set_is_preview(true)}

src/packages/frontend/chat/chatroom.tsx

@@ -675,7 +675,7 @@ export default function Message(props: Readonly<Props>) {
             Cancel
           </Button>
           <Button onClick={sendReply} type="primary">
-            Send Reply
+            <Icon name="paper-plane" /> Send
           </Button>
           <LLMCostEstimationChat
             llm_cost={llm_cost_reply}

src/packages/frontend/chat/message.tsx

@@ -159,7 +159,7 @@ export default function SideChat({ project_id, path, style }: Props) {
                 type="primary"
               >
                 <Icon name="paper-plane" />
-                Send Message (shift+enter)
+                Send
               </Button>
             </Tooltip>
             {/*