fix #6830 -- links to stack trace files

Author: williamstein

src/packages/frontend/client/project.ts

@@ -38,6 +38,7 @@ import { ipywidgetsGetBufferUrl } from "@cocalc/frontend/jupyter/server-urls";
 import type { ApiKey } from "@cocalc/util/db-schema/api-keys";
 import computeServers from "@cocalc/frontend/compute/manager";
 import type { ExecOpts, ExecOutput } from "@cocalc/util/db-schema/projects";
+import { HOME_ROOT } from "@cocalc/util/consts/files";
 
 export class ProjectClient {
   private client: WebappClient;
@@ -79,7 +80,7 @@ export class ProjectClient {
     const base_path = appBasePath;
     if (opts.path[0] === "/") {
       // absolute path to the root
-      opts.path = ".smc/root" + opts.path; // use root symlink, which is created by start_smc
+      opts.path = HOME_ROOT + opts.path; // use root symlink, which is created by start_smc
     }
     return encode_path(join(base_path, `${opts.project_id}/raw/${opts.path}`));
   }

src/packages/frontend/jupyter/output-messages/ansi.ts

@@ -24,6 +24,10 @@ export function is_ansi(s: any): boolean {
   );
 }
 
+export function toText(s: string): string {
+  return Anser.ansiToText(s);
+}
+
 // Extract a plain-text representation of a given cell
 export function cellOutputToText(cell): string {
   const raw = cell.get("output");

src/packages/frontend/jupyter/output-messages/traceback.tsx

@@ -5,9 +5,10 @@
 
 import React from "react";
 import { Map } from "immutable";
-import { endswith } from "@cocalc/util/misc";
-import { Ansi } from "./ansi";
+import { Ansi, toText } from "./ansi";
 import { TRACEBACK_STYLE } from "./style";
+import { useFileContext } from "@cocalc/frontend/lib/file-context";
+import { HOME_ROOT } from "@cocalc/util/consts/files";
 
 interface TracebackProps {
   message: Map<string, any>;
@@ -24,23 +25,65 @@ export const Traceback: React.FC<TracebackProps> = React.memo(
     const v: JSX.Element[] = [];
 
     const tb = message.get("traceback");
+    const { AnchorTagComponent } = useFileContext();
 
+    let lines: string[];
     if (typeof tb == "string") {
-      v.push(<Ansi>{tb}</Ansi>);
+      lines = tb.split("\n");
+    } else if (typeof tb.forEach == "function" || Array.isArray(tb)) {
+      // forEach detects an immutable.js object
+      lines = [];
+      for (const x of tb) {
+        lines.push(x);
+      }
+    } else {
+      lines = [JSON.stringify(tb)];
     }
-    // forEach detects an immutable object
-    else if (typeof tb.forEach == "function" || Array.isArray(tb)) {
-      let n: number = 0;
-      for (let x of tb) {
-        if (!endswith(x, "\n")) {
-          x += "\n";
-        }
+
+    let n: number = 0;
+    for (let x of lines) {
+      if (!x.endsWith("\n")) {
+        x += "\n";
+      }
+      if (AnchorTagComponent != null && x.startsWith("File ")) {
+        const { file, target, rest, line } = parseFile(x);
+        v.push(
+          <div key={n}>
+            File{" "}
+            <AnchorTagComponent href={`${target}#line=${line}`}>
+              {file}:{line}
+            </AnchorTagComponent>
+            <Ansi>{rest}</Ansi>
+          </div>,
+        );
+      } else {
         v.push(<Ansi key={n}>{x}</Ansi>);
-        n += 1;
       }
+      n += 1;
     }
 
     return <div style={TRACEBACK_STYLE}>{v}</div>;
   },
-  should_memoize
+  should_memoize,
 );
+
+function parseFile(x: string): {
+  file: string;
+  rest: string;
+  target: string;
+  line: number;
+} {
+  const i = x.indexOf(", ");
+  const a = toText(x.slice(0, i).trim()).slice(5).trim();
+  const rest = x.slice(i);
+  const v = a.split(":");
+  const file = v[0];
+  let target = file;
+  if (target[0] === "/") {
+    // absolute path to the root
+    target = '~/' + HOME_ROOT + target; // use root symlink
+  }
+
+  const line = parseInt(v[1]);
+  return { rest, file, target, line };
+}

src/packages/frontend/project/open-file.ts

@@ -163,8 +163,8 @@ export async function open_file(
       if (!actions.open_files) return; // closed
       alert_message({
         type: "info",
-        message: `Opening realpath "${realpath}" instead, since filesystem links are not fully supported.`,
-        timeout: 15,
+        message: `Opening normalized real path "${realpath}"`,
+        timeout: 10,
       });
       actions.open_files.delete(opts.path);
       opts.path = realpath;

src/packages/frontend/project/utils.ts

@@ -236,7 +236,16 @@ export function editor_id(project_id: string, path: string): string {
 }
 
 // Normalize path as in node, except '' is the home dir, not '.'.
+// Also, if ~/ is somewhere in the path, start over at home.
 export function normalize(path: string): string {
+  while (true) {
+    const i = path.indexOf("~/");
+    if (i == -1) {
+      break;
+    }
+    path = path.slice(i + 2);
+  }
+
   path = os_path.normalize(path);
   if (path === ".") {
     return "";

src/packages/util/consts/files.ts

@@ -0,0 +1,2 @@
+export const HOME_ROOT = ".smc/root";
+