Merge pull request #7722 from sagemathinc/api-exec-await

api/exec await + latex

Author: haraldschilly

src/packages/backend/execute-code.ts

@@ -477,6 +477,12 @@ function doSpawn(
     finish();
   });
 
+  // Doc: https://nodejs.org/api/child_process.html#event-exit – read it!
+  // TODO: This is not 100% correct, because in case the process is killed (signal TERM),
+  // the $code is "null" and a second argument gives the signal (as a string). Hence, after a kill,
+  // this code below changes the exit code to 0. This could be a special case, though.
+  // It cannot be null, though, because the "finish" callback assumes that stdout, err and exit are set.
+  // The local $killed var is only true, if the process has been killed by the timeout – not by another kill.
   child.on("exit", (code) => {
     exit_code = code ?? 0;
     finish();

src/packages/frontend/editors/stopwatch/time.tsx

@@ -1,6 +1,7 @@
-import { Icon } from "@cocalc/frontend/components/icon";
 import { CSSProperties } from "react";
 
+import { Icon } from "@cocalc/frontend/components/icon";
+
 function zpad(n: number): string {
   let s = `${n}`;
   if (s.length === 1) {

src/packages/frontend/frame-editors/_style.sass

@@ -10,13 +10,12 @@
   > button.btn
     margin-bottom: 20px
 
-
 // latex editor, build panel
 .cocalc-latex-build-content
 
   .ant-tabs-tab
-    margin: 0  !important
-    padding: 0  !important
+    margin: 0 !important
+    padding: 0 !important
     > div
       width: 100%
       padding: 5px 10px
@@ -26,6 +25,9 @@
   .ant-tabs-content-holder
     display: flex
 
+    .ant-tabs-content
+      overflow-y: auto
+
     .ant-tabs-tabpane
-      display        : flex
-      flex-direction : column
+      display: flex
+      flex-direction: column

src/packages/frontend/frame-editors/code-editor/actions.ts

@@ -59,6 +59,10 @@ import {
   ext2syntax,
   syntax2tool,
 } from "@cocalc/util/code-formatter";
+import {
+  TIMEOUT_CALLING_PROJECT,
+  TIMEOUT_CALLING_PROJECT_MSG,
+} from "@cocalc/util/consts/project";
 import {
   aux_file,
   filename_extension,
@@ -67,6 +71,7 @@ import {
   uuid,
 } from "@cocalc/util/misc";
 import { reuseInFlight } from "@cocalc/util/reuse-in-flight";
+import { set_account_table } from "../../account/util";
 import { default_opts } from "../codemirror/cm-options";
 import { print_code } from "../frame-tree/print-code";
 import * as tree_ops from "../frame-tree/tree-ops";
@@ -99,7 +104,6 @@ import * as cm_doc_cache from "./doc";
 import { SHELLS } from "./editor";
 import { test_line } from "./simulate_typing";
 import { misspelled_words } from "./spell-check";
-import { set_account_table } from "../../account/util";
 
 interface gutterMarkerParams {
   line: number;
@@ -1853,13 +1857,12 @@ export class Actions<
   public set_error(
     error?: object | string,
     style?: ErrorStyles,
-    id?: string,
+    _id?: string, // id - not currently used, but would be for frame-specific error.
   ): void {
-    id = id; // id - not currently used, but would be for frame-specific error.
     if (error === undefined) {
       this.setState({ error });
     } else {
-      if (typeof error == "object") {
+      if (typeof error === "object") {
         const e = (error as any).message;
         if (e === undefined) {
           let e = JSON.stringify(error);
@@ -1870,6 +1873,9 @@ export class Actions<
         if (typeof e != "string") throw Error("bug"); // make typescript happy
         error = e;
       }
+      if (error === TIMEOUT_CALLING_PROJECT) {
+        error = TIMEOUT_CALLING_PROJECT_MSG;
+      }
       this.setState({ error });
     }
 

src/packages/frontend/frame-editors/frame-tree/commands/generic-commands.tsx

@@ -469,7 +469,14 @@ addCommands({
     title: "Force rebuild entire project.",
     icon: "play",
   },
-
+  stop_build: {
+    group: "build",
+    // TODO does not react to changes
+    // disabled: ({ props }) => props.editor_actions.is_running !== true,
+    label: "Stop",
+    title: "Stop all running jobs.",
+    icon: "stop",
+  },
   clean: {
     group: "build",
     label: "Delete Aux Files",

src/packages/frontend/frame-editors/frame-tree/title-bar.tsx

@@ -76,6 +76,7 @@ interface FrameActions extends Actions {
   clean?: (id: string) => void;
   word_count?: (time: number, force: boolean) => void;
   close_and_halt?: (id: string) => void;
+  stop_build?: (id: string) => void;
 }
 
 interface EditorActions extends Actions {