store: make license date selection only allow for selecting the *day*, not the time

- actual time is all still EXACTLY AS BEFORE, it's just that the UI
  component normalizes the time to be from 12am on the start date to
  11:59pm on the end date, in the browser's local timezone

Author: williamstein

src/packages/next/components/misc/date-range.tsx

@@ -26,7 +26,7 @@ export default function DateRange(props: Props) {
     maxDaysInFuture,
     disabled = false,
     initialValues = [undefined, undefined],
-    suffix
+    suffix,
   } = props;
 
   const [dateRange, setDateRange] = useState<DateRangeType>(initialValues);
@@ -66,7 +66,6 @@ export default function DateRange(props: Props) {
     <div style={style}>
       <DatePicker.RangePicker
         changeOnBlur
-        showTime
         disabled={disabled}
         allowEmpty={[true, true]}
         renderExtraFooter={() => (
@@ -93,10 +92,18 @@ export default function DateRange(props: Props) {
           ] as any
         }
         onChange={(value) => {
-          const x: [Date0, Date0] = [
-            value?.[0]?.toDate(),
-            value?.[1]?.toDate(),
-          ];
+          const now = dayjs();
+          // Ensure start is the later of now or the start of the selected day
+          const start = value?.[0]
+            ? dayjs(value[0]).isBefore(now)
+              ? now.toDate()
+              : dayjs(value[0]).startOf("day").toDate()
+            : undefined;
+          // Set end of day, but only modify if there's a value
+          const end = value?.[1]
+            ? dayjs(value[1]).endOf("day").subtract(1, "minute").toDate()
+            : undefined;
+          const x: [Date0, Date0] = [start, end];
           setDateRange(x);
           onChange?.(x);
         }}
@@ -116,9 +123,7 @@ export default function DateRange(props: Props) {
             : undefined
         }
       />
-      {suffix && (
-        <span style={{marginLeft: '5px'}}>{suffix}</span>
-      )}
+      {suffix && <span style={{ marginLeft: "5px" }}>{suffix}</span>}
     </div>
   );
 }

src/packages/next/components/store/usage-and-duration.tsx

@@ -95,7 +95,7 @@ export function UsageAndDuration(props: Props) {
         range[1] = new Date(range[1]);
       }
       suffix =
-        range && range[0] && `(${getTimezoneFromDate(range[0], "long")})`;
+        range && range[0] && `(midnight to 11:59pm, ${getTimezoneFromDate(range[0], "long")})`;
     } catch (err) {
       invalidRange = true;
       console.warn(`WARNING: issue parsing date ${range[0]}`);