start conat RPC api for compute servers

Author: williamstein

src/packages/conat/hub/api/compute.ts

@@ -0,0 +1,29 @@
+import { authFirstRequireAccount } from "./util";
+import type {
+  //Action,
+  Cloud,
+  //ComputeServerTemplate,
+  //ComputeServerUserInfo,
+  Configuration,
+  //Images,
+  //GoogleCloudImages,
+} from "@cocalc/util/db-schema/compute-servers";
+
+export const compute = {
+  createServer: authFirstRequireAccount,
+};
+
+export interface Compute {
+  createServer: (opts: {
+    account_id?: string;
+    project_id: string;
+    title?: string;
+    color?: string;
+    autorestart?: boolean;
+    cloud?: Cloud;
+    configuration?: Configuration;
+    notes?: string;
+    course_project_id?: string;
+    course_server_id?: number;
+  }) => Promise<number>;
+}

src/packages/conat/hub/api/index.ts

@@ -8,6 +8,7 @@ import { handleErrorMessage } from "@cocalc/conat/util";
 import { type Sync, sync } from "./sync";
 import { type Org, org } from "./org";
 import { type Messages, messages } from "./messages";
+import { type Compute, compute } from "./compute";
 
 export interface HubApi {
   system: System;
@@ -18,6 +19,7 @@ export interface HubApi {
   sync: Sync;
   org: Org;
   messages: Messages;
+  compute: Compute;
 }
 
 const HubApiStructure = {
@@ -29,6 +31,7 @@ const HubApiStructure = {
   sync,
   org,
   messages,
+  compute,
 } as const;
 
 export function transformArgs({ name, args, account_id, project_id }) {

src/packages/frontend/compute/action.tsx

@@ -51,7 +51,7 @@ export default function getActions({
     const a = ACTION_INFO[action];
     if (!a) continue;
     if (action == "suspend") {
-      if (configuration.cloud != "google-cloud") {
+      if (configuration?.cloud != "google-cloud") {
         continue;
       }
       if (getArchitecture(configuration) == "arm64") {
@@ -61,12 +61,12 @@ export default function getActions({
         continue;
       }
       // must have no gpu and <= 208GB of RAM -- https://cloud.google.com/compute/docs/instances/suspend-resume-instance
-      if (configuration.acceleratorType) {
+      if (configuration?.acceleratorType) {
         continue;
       }
       // [ ] TODO: we don't have an easy way to check the RAM requirement right now.
     }
-    if (!editModal && configuration.ephemeral && action == "stop") {
+    if (!editModal && configuration?.ephemeral && action == "stop") {
       continue;
     }
     const {
@@ -79,10 +79,10 @@ export default function getActions({
       confirmMessage,
       clouds,
     } = a;
-    if (danger && !configuration.ephemeral && !editModal) {
+    if (danger && !configuration?.ephemeral && !editModal) {
       continue;
     }
-    if (clouds && !clouds.includes(configuration.cloud)) {
+    if (clouds && !clouds.includes(configuration?.cloud)) {
       continue;
     }
     v.push(
@@ -179,7 +179,7 @@ function ActionButton({
       }
     }
 
-    if (configuration.cloud == "onprem") {
+    if (configuration?.cloud == "onprem") {
       if (action == "start") {
         setShowOnPremStart(true);
       } else if (action == "stop") {
@@ -244,7 +244,7 @@ function ActionButton({
         onOpenChange={setPopConfirm}
         placement="right"
         okButtonProps={{
-          disabled: !configuration.ephemeral && danger && !understand,
+          disabled: !configuration?.ephemeral && danger && !understand,
         }}
         title={
           <div>
@@ -269,7 +269,7 @@ function ActionButton({
                 }`}
               />
             )}
-            {!configuration.ephemeral && danger && (
+            {!configuration?.ephemeral && danger && (
               <div>
                 {/* ATTN: Not using a checkbox here to WORKAROUND A BUG IN CHROME that I see after a day or so! */}
                 <Button onClick={() => setUnderstand(!understand)} type="text">
@@ -443,7 +443,7 @@ function OnPremGuide({ setShow, configuration, id, title, action }) {
               </div>
             }
           />
-          {configuration.gpu && (
+          {configuration?.gpu && (
             <span>
               Since you clicked GPU, you must also have an NVIDIA GPU and the
               Cuda drivers installed and working.{" "}

src/packages/frontend/compute/configuration.tsx

@@ -131,11 +131,9 @@ function Config({
         template={template}
       />
     );
+  } else if (configuration == null) {
+    return <span>Not Configured</span>;
   } else {
-    return (
-      <span>
-        Configuration not implemented: {JSON.stringify(configuration)}
-      </span>
-    );
+    return <span>Unknown Cloud: '{JSON.stringify(configuration?.cloud)}'</span>;
   }
 }

src/packages/server/compute/create-server.ts

@@ -10,9 +10,7 @@ It's of course easy to make a compute serve that can't be started due to invalid
 import getPool from "@cocalc/database/pool";
 import { isValidUUID } from "@cocalc/util/misc";
 import isCollaborator from "@cocalc/server/projects/is-collaborator";
-import {
-  CLOUDS_BY_NAME,
-} from "@cocalc/util/db-schema/compute-servers";
+import { CLOUDS_BY_NAME } from "@cocalc/util/db-schema/compute-servers";
 import { isDnsAvailable } from "./dns";
 import { getAvailableVpnIp } from "./vpn";
 import { getProjectSpecificId } from "./project-specific-id";
@@ -28,7 +26,7 @@ import type {
 } from "@cocalc/util/db-schema/compute-servers";
 
 interface Options {
-  account_id: string;
+  account_id?: string;
   project_id: string;
   cloud?: Cloud;
   configuration?: Configuration;
@@ -38,7 +36,7 @@ interface Options {
   position?: number;
   notes?: string;
   course_project_id?: string;
-  course_server_id?: string;
+  course_server_id?: number;
 }
 
 const FIELDS =
@@ -49,7 +47,7 @@ const FIELDS =
 export default async function createServer(opts: Options): Promise<number> {
   logger.debug("createServer", opts);
   if (!isValidUUID(opts.account_id)) {
-    throw Error("created_by must be a valid uuid");
+    throw Error("account_id must be a valid uuid");
   }
   if (!isValidUUID(opts.project_id)) {
     throw Error("project_id must be a valid uuid");

src/packages/server/conat/api/compute.ts

@@ -0,0 +1,2 @@
+import createServer from "@cocalc/server/compute/create-server";
+export { createServer };

src/packages/server/conat/api/index.ts

@@ -40,6 +40,16 @@ pnpm conat-watch 'hub.*.*.api' --match-replies
 
 */
 
+import * as purchases from "./purchases";
+import * as db from "./db";
+import * as system from "./system";
+import * as projects from "./projects";
+import * as jupyter from "./jupyter";
+import * as sync from "./sync";
+import * as org from "./org";
+import * as messages from "./messages";
+import * as compute from "./compute";
+
 import getLogger from "@cocalc/backend/logger";
 import { type HubApi, getUserId, transformArgs } from "@cocalc/conat/hub/api";
 import { conat } from "@cocalc/backend/conat";
@@ -50,6 +60,18 @@ import { close as terminateProjectRunner } from "@cocalc/server/conat/project/ru
 import { close as terminateProjectRunnerLoadBalancer } from "@cocalc/server/conat/project/load-balancer";
 import { delay } from "awaiting";
 
+export const hubApi: HubApi = {
+  system,
+  projects,
+  db,
+  purchases,
+  jupyter,
+  sync,
+  org,
+  messages,
+  compute,
+};
+
 const logger = getLogger("server:conat:api");
 
 export function initAPI() {
@@ -174,26 +196,6 @@ async function handleApiRequest({ request, mesg }) {
   }
 }
 
-import * as purchases from "./purchases";
-import * as db from "./db";
-import * as system from "./system";
-import * as projects from "./projects";
-import * as jupyter from "./jupyter";
-import * as sync from "./sync";
-import * as org from "./org";
-import * as messages from "./messages";
-
-export const hubApi: HubApi = {
-  system,
-  projects,
-  db,
-  purchases,
-  jupyter,
-  sync,
-  org,
-  messages,
-};
-
 async function getResponse({ name, args, account_id, project_id }) {
   const [group, functionName] = name.split(".");
   const f = hubApi[group]?.[functionName];

src/packages/server/projects/is-collaborator.ts

@@ -2,8 +2,8 @@ import getPool from "@cocalc/database/pool";
 import { is_valid_uuid_string as isValid } from "@cocalc/util/misc";
 
 interface Options {
-  account_id: string;
-  project_id: string;
+  account_id?: string;
+  project_id?: string;
 }
 
 // Return true if account_id is a collaborator on project_ids.