fix #7570 -- normalize date range of non-subscription license to be valid whenever the cart is touched

- start can't be in past
- end must be at least an hour after start

This is done on the backend whenever anything touches the shopping cart,
which should greatly increase chances of it always working.  It's
automatic.  You do see it the second you view your cart (on the way to
checkout).

Author: williamstein

src/packages/server/shopping/cart/get.ts

@@ -8,6 +8,7 @@ import { assertValidAccountID } from "@cocalc/util/misc";
 import getPool from "@cocalc/database/pool";
 import { Item } from "@cocalc/util/db-schema/shopping-cart-items";
 export type { Item };
+import { ensureValidLicenseIntervals } from "./validate";
 
 interface Options {
   account_id: string;
@@ -26,8 +27,9 @@ export default async function getCart({
     `SELECT * FROM shopping_cart_items WHERE account_id=$1 AND purchased IS ${
       purchased ? " NOT " : ""
     } NULL AND removed IS ${removed ? " NOT " : ""} NULL ORDER BY id DESC`,
-    [account_id]
+    [account_id],
   );
+  await ensureValidLicenseIntervals(rows, pool);
   return rows;
 }
 
@@ -42,7 +44,7 @@ export async function getItem({
   const pool = getPool();
   const { rows } = await pool.query(
     "SELECT * FROM shopping_cart_items WHERE account_id=$1 AND id=$2",
-    [account_id, id]
+    [account_id, id],
   );
   if (rows.length == 0) {
     throw Error(`no item with id ${id}`);

src/packages/server/shopping/cart/validate.ts

@@ -0,0 +1,35 @@
+// This ensures the date ranges in the rows are valid in the
+// database, and also mutates the rows themselves to be valid.
+export async function ensureValidLicenseIntervals(rows: any[], pool) {
+  for (const row of rows) {
+    const { description } = row;
+    const range = description?.range;
+    if (range == null) {
+      // subscriptions, etc.
+      continue;
+    }
+    // "range": ["2024-09-30T07:00:00.000Z", "2024-10-16T06:58:59.999Z"] is two UTC strings.  We
+    // ensure that the start endpoint is >= now and the end endpoint is >= start + 1 hour.
+    let start = new Date(range[0]);
+    let end = new Date(range[1]);
+    const now = new Date();
+    let changed = false;
+    if (start < now) {
+      changed = true;
+      start = now;
+    }
+    // 1 hour in milliseconds
+    const oneHourLater = new Date(start.getTime() + 3600 * 1000);
+    if (end < oneHourLater) {
+      changed = true;
+      end = oneHourLater;
+    }
+    if (changed) {
+      description.range = [start.toISOString(), end.toISOString()];
+      await pool.query(
+        "UPDATE shopping_cart_items SET description=$1 WHERE id=$2",
+        [description, row.id],
+      );
+    }
+  }
+}