frontend/latex: properly test if exec did timeout, for a proper retry

Author: haraldschilly

src/packages/frontend/frame-editors/code-editor/actions.ts

@@ -64,7 +64,7 @@ import {
   syntax2tool,
 } from "@cocalc/util/code-formatter";
 import {
-  IS_TIMEOUT_CALLING_PROJECT,
+  isTimeoutCallingProject,
   TIMEOUT_CALLING_PROJECT_MSG,
 } from "@cocalc/util/consts/project";
 import {
@@ -1921,7 +1921,7 @@ export class Actions<
     if (error === undefined) {
       return "";
     }
-    if (IS_TIMEOUT_CALLING_PROJECT(error)) {
+    if (isTimeoutCallingProject(error)) {
       return TIMEOUT_CALLING_PROJECT_MSG;
     }
     if (typeof error == "string") {

src/packages/frontend/frame-editors/latex-editor/util.ts

@@ -10,7 +10,7 @@ import {
   ExecOpts,
   ExecOutput,
 } from "@cocalc/frontend/frame-editors/generic/client";
-import { IS_TIMEOUT_CALLING_PROJECT } from "@cocalc/util/consts/project";
+import { isTimeoutCallingProject } from "@cocalc/util/consts/project";
 import { ExecOptsBlocking } from "@cocalc/util/db-schema/projects";
 import { separate_file_extension } from "@cocalc/util/misc";
 import { ExecuteCodeOutputAsync } from "@cocalc/util/types/execute-code";
@@ -177,7 +177,7 @@ export async function runJob(opts: RunJobOpts): Promise<ExecOutput> {
       set_job_info(output);
       return output;
     } catch (err) {
-      if (IS_TIMEOUT_CALLING_PROJECT(err)) {
+      if (isTimeoutCallingProject(err)) {
         // This will eventually be fine, hopefully. We continue trying to get a reply.
         await delay(100);
       } else {

src/packages/util/consts/project.ts

@@ -10,9 +10,20 @@ export const TIMEOUT_CALLING_PROJECT = "timeout";
 export const TIMEOUT_CALLING_PROJECT_MSG =
   "Timeout communicating with project.";
 
-export const IS_TIMEOUT_CALLING_PROJECT = (err) => {
+/**
+ * Checks if an error represents a timeout when communicating with a project.
+ *
+ * Handles both legacy and conat-based timeout errors:
+ * - Legacy: String "timeout"
+ * - Conat: ConatError with code 408 (HTTP Request Timeout)
+ *   See @cocalc/conat/core/client.ts lines 1391, 1937-1939 where 408 timeouts are thrown
+ */
+export function isTimeoutCallingProject(err): boolean {
   if (err === TIMEOUT_CALLING_PROJECT) {
     return true;
   }
+  if (err?.constructor?.name === "ConatError" && err?.code === 408) {
+    return true;
+  }
   return false;
-};
+}