fix bug i just caused in goto line (from find)

williamstein · williamstein · commit 5fb4f5c3a88a · 2024-10-06T19:50:50.000Z
diff --git a/src/packages/frontend/frame-editors/code-editor/actions.ts b/src/packages/frontend/frame-editors/code-editor/actions.ts
@@ -1833,7 +1833,9 @@ export class Actions<
       // TODO: this is VERY CRAPPY CODE -- wait after,
       // so cm gets state/value fully set.
       await delay(100);
-      if (this._state == "closed") return;
+      if (this._state == "closed") {
+        return;
+      }
       doc.setCursor(pos);
       cm.scrollIntoView(pos, cm.getScrollInfo().clientHeight / 2);
     }
@@ -3074,7 +3076,8 @@ export class Actions<
     }
 
     if (fragmentId.line) {
-      this.programmatical_goto_line?.(fragmentId.line);
+      if (this._state == "closed") return;
+      this.programmatical_goto_line?.(fragmentId.line, true);
     }
 
     if (fragmentId.chat && !this.path.endsWith(".sage-chat")) {

Original file line number	Diff line number	Diff line change
`@@ -1833,7 +1833,9 @@ export class Actions<`
`1833`	`1833`	`// TODO: this is VERY CRAPPY CODE -- wait after,`
`1834`	`1834`	`// so cm gets state/value fully set.`
`1835`	`1835`	`await delay(100);`
`1836`		`- if (this._state == "closed") return;`
	`1836`	`+ if (this._state == "closed") {`
	`1837`	`+ return;`
	`1838`	`+ }`
`1837`	`1839`	`doc.setCursor(pos);`
`1838`	`1840`	`cm.scrollIntoView(pos, cm.getScrollInfo().clientHeight / 2);`
`1839`	`1841`	`}`
`@@ -3074,7 +3076,8 @@ export class Actions<`
`3074`	`3076`	`}`
`3075`	`3077`
`3076`	`3078`	`if (fragmentId.line) {`
`3077`		`- this.programmatical_goto_line?.(fragmentId.line);`
	`3079`	`+ if (this._state == "closed") return;`
	`3080`	`+ this.programmatical_goto_line?.(fragmentId.line, true);`
`3078`	`3081`	`}`
`3079`	`3082`
`3080`	`3083`	`if (fragmentId.chat && !this.path.endsWith(".sage-chat")) {`