fix #7728 -- pasting image into chat message in markdown mode breaks it

Author: williamstein

src/packages/frontend/chat/actions.ts

@@ -570,6 +570,7 @@ export class ChatActions extends Actions<ChatState> {
   }
 
   public set_uploading(is_uploading: boolean): void {
+    console.log("set_uploading", is_uploading);
     this.setState({ is_uploading });
   }
 

src/packages/frontend/chat/chat-log.tsx

@@ -286,6 +286,14 @@ function isThread(messages: ChatMessages, message: ChatMessageTyped) {
   if (message.get("reply_to") != null) {
     return true;
   }
+  // TODO/WARNING!!! This is a linear search
+  // through all messages to decide if a message is the root of a thread.
+  // This is VERY BAD and must to be redone at some point, since we call isThread
+  // on all messages (in getSortedDates), making that algorithm O(n^2),
+  // which is hideous as the number of messages scales.  Instead one must
+  // use a proper data structure (or even a cache) to track this once
+  // and for all.  It's more complicated but everything needs to be at
+  // most O(n).
   return messages.some(
     (m) => m.get("reply_to") === message.get("date").toISOString(),
   );

src/packages/frontend/editors/markdown-input/component.tsx

@@ -561,9 +561,7 @@ export function MarkdownInput(props: Props) {
     // console.log("upload_sending", file);
     if (current_uploads_ref.current == null) {
       current_uploads_ref.current = { [file.name]: true };
-      if (onUploadStart != null) {
-        onUploadStart();
-      }
+      onUploadStart?.();
     } else {
       current_uploads_ref.current[file.name] = true;
     }
@@ -582,16 +580,16 @@ export function MarkdownInput(props: Props) {
     if (path == null) {
       throw Error("path must be set if enableUploads is set.");
     }
+    const filename = file.name ?? file.upload.filename;
 
     if (current_uploads_ref.current != null) {
-      delete current_uploads_ref.current[file.name];
+      delete current_uploads_ref.current[filename];
       if (len(current_uploads_ref.current) == 0) {
         current_uploads_ref.current = null;
-        if (onUploadEnd != null) {
-          onUploadEnd();
-        }
+        onUploadEnd?.();
       }
     }
+
     if (cm.current == null) return;
     const input = cm.current.getValue();
     const s0 = upload_temp_link(file);