file explorer: remove show/hide masked files button

novoselt · novoselt · commit 635e9d9ee781 · 2025-11-24T19:09:59.000-07:00
diff --git a/src/packages/frontend/i18n/common.ts b/src/packages/frontend/i18n/common.ts
@@ -576,12 +576,6 @@ export const labels = defineMessages({
       "{hidden, select, true {Hide hidden files} other {Show hidden files}}. Hidden files in Linux start with a '.' in their filename. They are usually not meant to be edited.",
     description: "show/hide hidden files in a file-explorer in a UI",
   },
-  masked_files: {
-    id: "labels.masked_files",
-    defaultMessage:
-      "{masked, select, true {Hide masked files} other {Show masked files}}. Masked files are autogenerated or temporary files, which are not meant to be edited. They are grayed out.",
-    description: "show/hide masked files in a file-explorer in a UI.",
-  },
   folder: {
     id: "labels.folder",
     defaultMessage: "folder",
diff --git a/src/packages/frontend/i18n/trans/ar_EG.json b/src/packages/frontend/i18n/trans/ar_EG.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "لينكس تيرمنال",
   "labels.loading": "جار التحميل...",
   "labels.log": "تسجيل",
-  "labels.masked_files": "{masked, select, true {إخفاء الملفات المقنعة} other {إظهار الملفات المقنعة}}. الملفات المقنعة هي ملفات تم إنشاؤها تلقائيًا أو ملفات مؤقتة، والتي لا يُقصد تعديلها. يتم تظليلها باللون الرمادي.",
   "labels.message.plural": "{num, plural, one {رسالة} other {رسائل}}",
   "labels.messages": "رسائل",
   "labels.messages.all_messages": "جميع الرسائل",
diff --git a/src/packages/frontend/i18n/trans/de_DE.json b/src/packages/frontend/i18n/trans/de_DE.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Linux-Terminal",
   "labels.loading": "Laden...",
   "labels.log": "Protokoll",
-  "labels.masked_files": "{masked, select, true {Maskierte Dateien ausblenden} other {Maskierte Dateien anzeigen}}. Maskierte Dateien sind automatisch generierte oder temporäre Dateien, die nicht bearbeitet werden sollen. Sie sind ausgegraut.",
   "labels.message.plural": "{num, plural, one {Nachricht} other {Nachrichten}}",
   "labels.messages": "Nachrichten",
   "labels.messages.all_messages": "Alle Nachrichten",
diff --git a/src/packages/frontend/i18n/trans/es_ES.json b/src/packages/frontend/i18n/trans/es_ES.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Terminal de Linux",
   "labels.loading": "Cargando...",
   "labels.log": "Registro",
-  "labels.masked_files": "{masked, select, true {Ocultar archivos enmascarados} other {Mostrar archivos enmascarados}}. Los archivos enmascarados son archivos autogenerados o temporales, que no están destinados a ser editados. Están atenuados.",
   "labels.message.plural": "{num, plural, one {mensaje} other {mensajes}}",
   "labels.messages": "Mensajes",
   "labels.messages.all_messages": "Todos los mensajes",
diff --git a/src/packages/frontend/i18n/trans/es_PV.json b/src/packages/frontend/i18n/trans/es_PV.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Linux Terminala",
   "labels.loading": "Kargatzen...",
   "labels.log": "Egunkari",
-  "labels.masked_files": "{masked, select, true {Ezkutatu maskaratutako fitxategiak} other {Erakutsi maskaratutako fitxategiak}}. Maskaratutako fitxategiak automatikoki sortutako edo behin-behineko fitxategiak dira, eta ez dira editatzeko pentsatuta. Grisez agertzen dira.",
   "labels.message.plural": "{num, plural, one {Mezua} other {Mezuak}}",
   "labels.messages": "Mezuak",
   "labels.messages.all_messages": "Mezu guztiak",
diff --git a/src/packages/frontend/i18n/trans/fr_FR.json b/src/packages/frontend/i18n/trans/fr_FR.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Terminal Linux",
   "labels.loading": "Chargement...",
   "labels.log": "Journal",
-  "labels.masked_files": "{masked, select, true {Masquer les fichiers masqués} other {Afficher les fichiers masqués}}. Les fichiers masqués sont des fichiers générés automatiquement ou temporaires, qui ne sont pas destinés à être modifiés. Ils sont grisés.",
   "labels.message.plural": "{num, plural, one {message} other {messages}}",
   "labels.messages": "Messages",
   "labels.messages.all_messages": "Tous les messages",
diff --git a/src/packages/frontend/i18n/trans/he_IL.json b/src/packages/frontend/i18n/trans/he_IL.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "לינוקס טרמינל",
   "labels.loading": "טוען...",
   "labels.log": "יומן",
-  "labels.masked_files": "{masked, select, true {הסתר קבצים מוסתרים} other {הצג קבצים מוסתרים}}. קבצים מוסתרים הם קבצים שנוצרים אוטומטית או קבצים זמניים, אשר לא מיועדים לעריכה. הם מוצגים באפור.",
   "labels.message.plural": "{num, plural, one {הודעה} other {הודעות}}",
   "labels.messages": "הודעות",
   "labels.messages.all_messages": "כל ההודעות",
diff --git a/src/packages/frontend/i18n/trans/hi_IN.json b/src/packages/frontend/i18n/trans/hi_IN.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "लिनक्स टर्मिनल",
   "labels.loading": "लोड हो रहा है...",
   "labels.log": "लॉग",
-  "labels.masked_files": "{masked, select, true {छिपाएं मास्क किए गए फाइलें} other {दिखाएं मास्क किए गए फाइलें}}। मास्क किए गए फाइलें स्वचालित रूप से उत्पन्न या अस्थायी फाइलें होती हैं, जिन्हें संपादित करने के लिए नहीं बनाया गया है। वे धूसर रंग में होती हैं।",
   "labels.message.plural": "{num, plural, one {संदेश} other {संदेश}}",
   "labels.messages": "संदेश",
   "labels.messages.all_messages": "सभी संदेश",
diff --git a/src/packages/frontend/i18n/trans/hu_HU.json b/src/packages/frontend/i18n/trans/hu_HU.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Linux terminál",
   "labels.loading": "Betöltés...",
   "labels.log": "Napló",
-  "labels.masked_files": "{masked, select, true {Maszkos fájlok elrejtése} other {Maszkos fájlok megjelenítése}}. A maszkos fájlok automatikusan generált vagy ideiglenes fájlok, amelyeket nem szándékoznak szerkeszteni. Ezek szürkével vannak kiemelve.",
   "labels.message.plural": "{num, plural, one {üzenet} other {üzenetek}}",
   "labels.messages": "Üzenetek",
   "labels.messages.all_messages": "Összes üzenet",
diff --git a/src/packages/frontend/i18n/trans/it_IT.json b/src/packages/frontend/i18n/trans/it_IT.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Terminale Linux",
   "labels.loading": "Caricamento...",
   "labels.log": "Log",
-  "labels.masked_files": "{masked, select, true {Nascondi file mascherati} other {Mostra file mascherati}}. I file mascherati sono file autogenerati o temporanei, che non devono essere modificati. Sono visualizzati in grigio.",
   "labels.message.plural": "{num, plural, one {messaggio} other {messaggi}}",
   "labels.messages": "Messaggi",
   "labels.messages.all_messages": "Tutti i messaggi",
diff --git a/src/packages/frontend/i18n/trans/ja_JP.json b/src/packages/frontend/i18n/trans/ja_JP.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Linuxターミナル",
   "labels.loading": "読み込み中...",
   "labels.log": "ログ",
-  "labels.masked_files": "{masked, select, true {マスクされたファイルを隠す} other {マスクされたファイルを表示}}。マスクされたファイルは自動生成された一時ファイルであり、編集することを意図していません。これらはグレーアウトされています。",
   "labels.message.plural": "{num, plural, one {メッセージ} other {メッセージ}}",
   "labels.messages": "メッセージ",
   "labels.messages.all_messages": "すべてのメッセージ",
diff --git a/src/packages/frontend/i18n/trans/ko_KR.json b/src/packages/frontend/i18n/trans/ko_KR.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "리눅스 터미널",
   "labels.loading": "불러오는 중...",
   "labels.log": "로그",
-  "labels.masked_files": "{masked, select, true {마스크된 파일 숨기기} other {마스크된 파일 표시}}. 마스크된 파일은 자동 생성되거나 임시 파일로, 편집을 위한 것이 아닙니다. 이들은 회색으로 표시됩니다.",
   "labels.message.plural": "{num, plural, one {메시지} other {메시지들}}",
   "labels.messages": "메시지",
   "labels.messages.all_messages": "모든 메시지",
diff --git a/src/packages/frontend/i18n/trans/nl_NL.json b/src/packages/frontend/i18n/trans/nl_NL.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Linux Terminal",
   "labels.loading": "Laden...",
   "labels.log": "Logboek",
-  "labels.masked_files": "{masked, select, true {Verborgen bestanden verbergen} other {Verborgen bestanden tonen}}. Verborgen bestanden zijn automatisch gegenereerde of tijdelijke bestanden, die niet bedoeld zijn om te worden bewerkt. Ze worden grijs weergegeven.",
   "labels.message.plural": "{num, plural, one {bericht} other {berichten}}",
   "labels.messages": "Berichten",
   "labels.messages.all_messages": "Alle berichten",
diff --git a/src/packages/frontend/i18n/trans/pl_PL.json b/src/packages/frontend/i18n/trans/pl_PL.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Terminal Linux",
   "labels.loading": "Ładowanie...",
   "labels.log": "Dziennik",
-  "labels.masked_files": "{masked, select, true {Ukryj zamaskowane pliki} other {Pokaż zamaskowane pliki}}. Zamaskowane pliki to pliki generowane automatycznie lub tymczasowe, które nie są przeznaczone do edycji. Są wyszarzone.",
   "labels.message.plural": "{num, plural, one {wiadomość} other {wiadomości}}",
   "labels.messages": "Wiadomości",
   "labels.messages.all_messages": "Wszystkie wiadomości",
diff --git a/src/packages/frontend/i18n/trans/pt_BR.json b/src/packages/frontend/i18n/trans/pt_BR.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Terminal Linux",
   "labels.loading": "Carregando...",
   "labels.log": "Registro",
-  "labels.masked_files": "{masked, select, true {Ocultar arquivos mascarados} other {Mostrar arquivos mascarados}}. Arquivos mascarados são arquivos gerados automaticamente ou temporários, que não devem ser editados. Eles estão esmaecidos.",
   "labels.message.plural": "{num, plural, one {Mensagem} other {Mensagens}}",
   "labels.messages": "Mensagens",
   "labels.messages.all_messages": "Todas as mensagens",
diff --git a/src/packages/frontend/i18n/trans/pt_PT.json b/src/packages/frontend/i18n/trans/pt_PT.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Terminal Linux",
   "labels.loading": "A carregar...",
   "labels.log": "Registo",
-  "labels.masked_files": "{masked, select, true {Esconder ficheiros mascarados} other {Mostrar ficheiros mascarados}}. Os ficheiros mascarados são ficheiros autogerados ou temporários, que não devem ser editados. Estão esbatidos.",
   "labels.message.plural": "{num, plural, one {mensagem} other {mensagens}}",
   "labels.messages": "Mensagens",
   "labels.messages.all_messages": "Todas as Mensagens",
diff --git a/src/packages/frontend/i18n/trans/ru_RU.json b/src/packages/frontend/i18n/trans/ru_RU.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Терминал Linux",
   "labels.loading": "Загрузка...",
   "labels.log": "Журнал",
-  "labels.masked_files": "{masked, select, true {Скрыть замаскированные файлы} other {Показать замаскированные файлы}}. Замаскированные файлы — это автогенерируемые или временные файлы, которые не предназначены для редактирования. Они отображаются серым цветом.",
   "labels.message.plural": "{num, plural, one {сообщение} other {сообщения}}",
   "labels.messages": "Сообщения",
   "labels.messages.all_messages": "Все сообщения",
diff --git a/src/packages/frontend/i18n/trans/tr_TR.json b/src/packages/frontend/i18n/trans/tr_TR.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Linux Terminali",
   "labels.loading": "Yükleniyor...",
   "labels.log": "Günlük",
-  "labels.masked_files": "{masked, select, true {Maskelenmiş dosyaları gizle} other {Maskelenmiş dosyaları göster}}. Maskelenmiş dosyalar, düzenlenmemesi gereken, otomatik oluşturulmuş veya geçici dosyalardır. Bunlar gri renkte gösterilir.",
   "labels.message.plural": "{num, plural, one {mesaj} other {mesajlar}}",
   "labels.messages": "Mesajlar",
   "labels.messages.all_messages": "Tüm Mesajlar",
diff --git a/src/packages/frontend/i18n/trans/zh_CN.json b/src/packages/frontend/i18n/trans/zh_CN.json
@@ -1046,7 +1046,6 @@
   "labels.linux_terminal": "Linux 终端",
   "labels.loading": "加载中...",
   "labels.log": "日志",
-  "labels.masked_files": "{masked, select, true {隐藏遮罩文件} other {显示遮罩文件}}。遮罩文件是自动生成或临时文件，不适合编辑。它们显示为灰色。",
   "labels.message.plural": "{num, plural, one {消息} other {消息}}",
   "labels.messages": "消息",
   "labels.messages.all_messages": "所有消息",
diff --git a/src/packages/frontend/project/explorer/explorer.tsx b/src/packages/frontend/project/explorer/explorer.tsx
@@ -103,7 +103,6 @@ interface ReduxProps {
     | "upload";
   file_search: string;
   show_hidden?: boolean;
-  show_masked?: boolean;
   error?: string;
   checked_files: immutable.Set<string>;
   selected_file_index?: number;
@@ -182,7 +181,6 @@ const Explorer0 = rclass(
           file_action: rtypes.string,
           file_search: rtypes.string,
           show_hidden: rtypes.bool,
-          show_masked: rtypes.bool,
           error: rtypes.string,
           checked_files: rtypes.immutable,
           selected_file_index: rtypes.number,
@@ -650,11 +648,6 @@ const Explorer0 = rclass(
                 ? this.props.show_hidden
                 : false
             }
-            show_masked={
-              this.props.show_masked != undefined
-                ? this.props.show_masked
-                : true
-            }
             actions={this.props.actions}
             kucalc={this.props.kucalc}
             available_features={this.props.available_features}
diff --git a/src/packages/frontend/project/explorer/misc-side-buttons.tsx b/src/packages/frontend/project/explorer/misc-side-buttons.tsx
@@ -32,7 +32,6 @@ interface Props {
   kucalc?: string;
   project_id: string;
   show_hidden?: boolean;
-  show_masked?: boolean;
 }
 
 export const MiscSideButtons: React.FC<Props> = (props) => {
@@ -43,7 +42,6 @@ export const MiscSideButtons: React.FC<Props> = (props) => {
     kucalc,
     project_id,
     show_hidden,
-    show_masked,
   } = props;
 
   const intl = useIntl();
@@ -58,13 +56,6 @@ export const MiscSideButtons: React.FC<Props> = (props) => {
     });
   };
 
-  const handle_masked_toggle = (e: React.MouseEvent): void => {
-    e.preventDefault();
-    actions.setState({
-      show_masked: !show_masked,
-    });
-  };
-
   const handle_backup = (e: React.MouseEvent): void => {
     e.preventDefault();
     actions.open_directory(".snapshots");
@@ -87,25 +78,6 @@ export const MiscSideButtons: React.FC<Props> = (props) => {
     );
   }
 
-  function render_masked_toggle(): React.JSX.Element {
-    return (
-      <Button
-        onClick={handle_masked_toggle}
-        active={!show_masked}
-        bsSize={"small"}
-      >
-        <Tip
-          title={intl.formatMessage(labels.masked_files, {
-            masked: show_masked,
-          })}
-          placement={"bottomLeft"}
-        >
-          <Icon name={"mask"} />
-        </Tip>
-      </Button>
-    );
-  }
-
   function render_backup(): React.JSX.Element | undefined {
     // NOTE -- snapshots aren't available except in "kucalc" version
     // -- they are complicated nontrivial thing that isn't usually setup...
@@ -218,7 +190,6 @@ export const MiscSideButtons: React.FC<Props> = (props) => {
       <div className="pull-right">
         <Space.Compact>
           {render_hidden_toggle()}
-          {render_masked_toggle()}
           {render_backup()}
           <TourButton project_id={project_id} />
         </Space.Compact>
diff --git a/src/packages/frontend/project/page/flyouts/files-header.tsx b/src/packages/frontend/project/page/flyouts/files-header.tsx
@@ -112,7 +112,6 @@ export function FilesHeader(props: Readonly<Props>): React.JSX.Element {
   const kucalc = useTypedRedux("customize", "kucalc");
   const file_search = useTypedRedux({ project_id }, "file_search") ?? "";
   const hidden = useTypedRedux({ project_id }, "show_hidden");
-  const show_masked = useTypedRedux({ project_id }, "show_masked");
   const file_creation_error = useTypedRedux(
     { project_id },
     "file_creation_error",
@@ -459,17 +458,6 @@ export function FilesHeader(props: Readonly<Props>): React.JSX.Element {
             >
               <Icon name={hidden ? "eye" : "eye-slash"} />
             </BootstrapButton>
-            <BootstrapButton
-              title={intl.formatMessage(labels.masked_files, {
-                masked: show_masked,
-              })}
-              bsSize="xsmall"
-              style={{ flex: "0" }}
-              active={!show_masked}
-              onClick={() => actions?.setState({ show_masked: !show_masked })}
-            >
-              <Icon name={"mask"} />
-            </BootstrapButton>
           </Space.Compact>
           {kucalc === KUCALC_COCALC_COM ? (
             <Space.Compact direction="horizontal" size="small">
diff --git a/src/packages/frontend/project/page/flyouts/files.tsx b/src/packages/frontend/project/page/flyouts/files.tsx
@@ -123,7 +123,6 @@ export function FilesFlyout({
     "active_file_sort",
   );
   const file_search = useTypedRedux({ project_id }, "file_search") ?? "";
-  const show_masked = useTypedRedux({ project_id }, "show_masked");
   const hidden = useTypedRedux({ project_id }, "show_hidden");
   const checked_files = useTypedRedux({ project_id }, "checked_files");
   const openFiles = useTypedRedux({ project_id }, "open_files_order");
@@ -205,9 +204,6 @@ export function FilesFlyout({
           ((file.isdir ?? false) && search_match(`${fName}/`, searchWords))
         );
       })
-      .filter(
-        (file: DirectoryListingEntry) => show_masked || !(file.mask === true),
-      )
       .filter(
         (file: DirectoryListingEntry) => hidden || !file.name.startsWith("."),
       );
@@ -297,7 +293,6 @@ export function FilesFlyout({
     hidden,
     file_search,
     openFiles,
-    show_masked,
     current_path,
     strippedPublicPaths,
   ]);
diff --git a/src/packages/frontend/project_store.ts b/src/packages/frontend/project_store.ts
@@ -103,7 +103,6 @@ export interface ProjectStoreState {
   file_action?: string; // undefined is meaningfully none here
   file_search?: string;
   show_hidden?: boolean;
-  show_masked?: boolean;
   error?: string;
   checked_files: immutable.Set<string>;
   selected_file_index?: number; // Index on file listing to highlight starting at 0. undefined means none highlighted
@@ -301,7 +300,6 @@ export class ProjectStore extends Store<ProjectStoreState> {
       show_upload: false,
       create_file_alert: false,
       displayed_listing: undefined, // computed(object),
-      show_masked: true,
       configuration: undefined,
       configuration_loading: false, // for UI feedback
       show_custom_software_reset: false,
@@ -383,7 +381,6 @@ export class ProjectStore extends Store<ProjectStoreState> {
         "file_search",
         "other_settings",
         "show_hidden",
-        "show_masked",
         "compute_server_id",
         "starred_files",
       ] as const,
@@ -515,20 +512,6 @@ export class ProjectStore extends Store<ProjectStoreState> {
           })();
         }
 
-        if (!this.get("show_masked", true)) {
-          // if we do not gray out files (and hence haven't computed the file mask yet)
-          // we do it now!
-          if (!this.get("other_settings").get("mask_files")) {
-            compute_file_masks(listing);
-          }
-
-          const filtered: DirectoryListing = [];
-          for (const f of listing) {
-            if (!f.mask) filtered.push(f);
-          }
-          listing = filtered;
-        }
-
         const file_map = {};
         for (const v of listing) {
           file_map[v.name] = v;
