Skip to content

Commit 65e24b6

Browse files
committed
fix #7702 -- jupyter: kernel selection dialog button line up is slightly off
- also add a little optional tooltip in some cases
1 parent d1edb91 commit 65e24b6

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

src/packages/frontend/jupyter/select-kernel.tsx

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import {
1515
Popover,
1616
Spin,
1717
Tabs,
18+
Tooltip,
1819
Typography,
1920
} from "antd";
2021
import { Map as ImmutableMap, List, OrderedMap } from "immutable";
@@ -134,7 +135,7 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
134135
const priority: number = kernels_by_name
135136
?.get(name)
136137
?.getIn(["metadata", "cocalc", "priority"]) as number;
137-
return (
138+
const btn = (
138139
<Button
139140
key={`kernel-${lang}-${name}`}
140141
onClick={() => {
@@ -145,7 +146,7 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
145146
how: "click-button-in-dialog",
146147
});
147148
}}
148-
style={{ marginBottom: "5px", height: "35px" }}
149+
style={{ height: "35px" }}
149150
>
150151
<Logo
151152
kernel={name}
@@ -156,6 +157,15 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
156157
<KernelStar priority={priority} />
157158
</Button>
158159
);
160+
const cocalc = kernels_by_name?.getIn([name, "metadata", "cocalc"]);
161+
if (cocalc == null) {
162+
return btn;
163+
}
164+
return (
165+
<Tooltip color="white" title={render_suggested_link(cocalc)}>
166+
{btn}
167+
</Tooltip>
168+
);
159169
}
160170

161171
function render_suggested() {
@@ -338,8 +348,9 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
338348
return (
339349
<Descriptions bordered column={1} style={SELECTION_STYLE}>
340350
<Descriptions.Item label={"Quick select"}>
341-
<div>
342-
Your most recently selected kernel {render_kernel_button(name)}
351+
<div style={{ display: "flex", alignItems: "center" }}>
352+
Your most recently selected kernel{" "}
353+
<div style={{ width: "15px" }} /> {render_kernel_button(name)}
343354
</div>
344355
</Descriptions.Item>
345356
<Descriptions.Item label={"Make default"}>
@@ -492,7 +503,9 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
492503
function render_head(): Rendered {
493504
return (
494505
<div>
495-
<div style={{ float: "right" }}>
506+
<div
507+
style={{ float: "right", display: "flex", alignItems: "center" }}
508+
>
496509
{renderCloseButton()}
497510
{renderRefreshButton()}
498511
</div>

0 commit comments

Comments
 (0)