Skip to content

Commit 6f00c6e

Browse files
committed
un-deprecate sage worksheets
- we are clearly putting a lot of working into continuing to support them, - they have very real advantages over Jupyter, both in terms of the UI (the one large unified document with actual good virtualization/ windowing that works), and ALSO: - starting a new worksheet *forks* rather than starts a new process, so is fundamentally much faster than Jupyter. - If we push through modernizing this it could be a unique contribution as well.
1 parent 4b5b2a6 commit 6f00c6e

File tree

1 file changed

+3
-27
lines changed

1 file changed

+3
-27
lines changed

src/packages/frontend/project/new/file-type-selector.tsx

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* License: MS-RSL – see LICENSE.md for details
44
*/
55

6-
import { Col, Flex, Modal, Row, Tag } from "antd";
6+
import { Col, Flex, Row, Tag } from "antd";
77
import { Gutter } from "antd/es/grid/row";
88
import type { ReactNode } from "react";
99
import { FormattedMessage, useIntl } from "react-intl";
@@ -372,30 +372,6 @@ export function FileTypeSelector({
372372
function renderSageWS() {
373373
if (!availableFeatures.sage) return;
374374

375-
function handleClick(ext) {
376-
Modal.confirm({
377-
icon: <Icon name="exclamation-circle" />,
378-
title: intl.formatMessage({
379-
id: "project.new.file-type-selector.sagews.modal.title",
380-
defaultMessage: "SageMath Worksheets are Deprecated",
381-
}),
382-
content: intl.formatMessage({
383-
id: "project.new.file-type-selector.sagews.modal.content",
384-
defaultMessage:
385-
"Consider creating a Jupyter Notebook and use a SageMath Kernel (use the 'SageMath Notebook' button). You can also convert existing SageMath Worksheets to Jupyter Notebooks by opening the worksheet and clicking 'Jupyter'.",
386-
}),
387-
okText: intl.formatMessage({
388-
id: "project.new.file-type-selector.sagews.modal.ok",
389-
defaultMessage: "Create SageMath Worksheet Anyways",
390-
}),
391-
onOk: (close) => {
392-
create_file(ext);
393-
close();
394-
},
395-
closable: true,
396-
});
397-
}
398-
399375
return (
400376
<Col sm={sm} md={md}>
401377
<Tip
@@ -405,12 +381,12 @@ export function FileTypeSelector({
405381
tip={intl.formatMessage({
406382
id: "new.file-type-selector.sagews.tooltip",
407383
defaultMessage:
408-
"Create an interactive worksheet for using the SageMath mathematical software, Python, R, and many other systems. Do sophisticated mathematics, draw plots, compute integrals, work with matrices, etc.",
384+
"Create an interactive worksheet for using the SageMath mathematical software, Python, R, and many other systems. Do mathematics, draw plots, compute integrals, work with matrices, etc.",
409385
})}
410386
>
411387
<NewFileButton
412388
name={intl.formatMessage(labels.sagemath_worksheet)}
413-
on_click={handleClick}
389+
on_click={create_file}
414390
ext="sagews"
415391
size={btnSize}
416392
active={btnActive("sagews")}

0 commit comments

Comments
 (0)