allow some minimal opening of files when a project isn't running; ask to open on save (fix #8284)

Author: williamstein

src/packages/frontend/frame-editors/code-editor/actions.ts

@@ -110,6 +110,7 @@ import { SHELLS } from "./editor";
 import { test_line } from "./simulate_typing";
 import { misspelled_words } from "./spell-check";
 import { log_opened_time } from "@cocalc/frontend/project/open-file";
+import { ensure_project_running } from "@cocalc/frontend/project/project-start-warning";
 
 interface gutterMarkerParams {
   line: number;
@@ -1237,6 +1238,9 @@ export class Actions<
     // several other formatting actions.
     // Doing this automatically is fraught with error, since cursors aren't precise...
     if (explicit) {
+      if (!await this.ensureProjectIsRunning(`save ${this.path} to disk`)) {
+        return;
+      }
       const account: any = this.redux.getStore("account");
       if (
         account &&
@@ -2172,6 +2176,10 @@ export class Actions<
     }
   }
 
+  ensureProjectIsRunning = async (what: string): Promise<boolean> => {
+    return await ensure_project_running(this.project_id, what);
+  };
+
   public format_support_for_syntax(
     available_features: AvailableFeatures,
     syntax: FormatterSyntax,

src/packages/frontend/project/directory-listing.ts

@@ -42,7 +42,7 @@ export async function get_directory_listing(opts: ListingOpts) {
       timeout = 0.5;
       time0 = server_time();
       if (opts.trigger_start_project === false) {
-        return { files: [] };
+        return { files: [], noRunning: true };
       }
       redux.getActions("projects").start_project(opts.project_id);
     } else {

src/packages/frontend/project/fetch-directory-listing.ts

@@ -97,6 +97,10 @@ const fetchDirectoryListing = reuseInFlight(
       }
       const directory_listings = store.get("directory_listings");
       let listing2 = directory_listings.get(compute_server_id) ?? Map();
+      if (listing.noRunning && (listing2.get(path)?.size ?? 0) > 0) {
+        // do not change it
+        return;
+      }
       listing2 = listing2.set(path, value);
       actions.setState({
         directory_listings: directory_listings.set(compute_server_id, listing2),

src/packages/frontend/project/open-file.ts

@@ -6,12 +6,9 @@
 // Implement the open_file actions for opening one single file in a project.
 
 import { callback } from "awaiting";
-
 import { alert_message } from "@cocalc/frontend/alerts";
 import { redux } from "@cocalc/frontend/app-framework";
 import { local_storage } from "@cocalc/frontend/editor-local-storage";
-import { dialogs } from "@cocalc/frontend/i18n";
-import { getIntl } from "@cocalc/frontend/i18n/get-intl";
 import Fragment, { FragmentId } from "@cocalc/frontend/misc/fragment-id";
 import { remove } from "@cocalc/frontend/project-file";
 import { ProjectActions } from "@cocalc/frontend/project_actions";
@@ -26,7 +23,6 @@ import {
   uuid,
 } from "@cocalc/util/misc";
 import { SITE_NAME } from "@cocalc/util/theme";
-import { ensure_project_running } from "./project-start-warning";
 import { normalize } from "./utils";
 import { syncdbPath as ipynbSyncdbPath } from "@cocalc/util/jupyter/names";
 import { termPath } from "@cocalc/util/terminal/names";
@@ -146,19 +142,6 @@ export async function open_file(
     opts.fragmentId = Fragment.decode(location.hash);
   }
 
-  const intl = await getIntl();
-  if (!tabIsOpened()) {
-    return;
-  }
-  const what = intl.formatMessage(dialogs.project_open_file_what, {
-    path: opts.path,
-  });
-
-  if (!(await ensure_project_running(actions.project_id, what))) {
-    if (!actions.open_files) return; // closed
-    actions.open_files.delete(opts.path);
-    return;
-  }
   if (!tabIsOpened()) {
     return;
   }