completely remove the "insert image" button/menu item for jupyter

- markdown editors (both slate and codemirror) already solve this
  problem better
- and this attachment thing doesn't even work at all

Author: williamstein

src/packages/frontend/frame-editors/jupyter-editor/cell-notebook/actions.ts

@@ -984,15 +984,6 @@ export class NotebookFrameActions {
     }
   }
 
-  public insert_image(): void {
-    const cur_id = this.store.get("cur_id");
-    if (this.jupyter_actions.store.get_cell_type(cur_id) === "markdown") {
-      this.jupyter_actions.insert_image(cur_id); // causes a modal dialog to appear.
-    } else {
-      throw Error(`insert_image -- cell must be a markdown cell`);
-    }
-  }
-
   public toggle_selected_outputs(property: "collapsed" | "scrolled"): void {
     this.jupyter_actions.toggle_outputs(
       this.store.get_selected_cell_ids_list(),

src/packages/frontend/frame-editors/jupyter-editor/editor.ts

@@ -320,7 +320,6 @@ const JUPYTER_MENUS = {
         children: ["format cells", "format all cells"],
       },
     ],
-    "insert-image": ["insert image"],
   },
   view: {
     label: "View",

src/packages/frontend/jupyter/cell-input.tsx

@@ -117,13 +117,6 @@ export const CellInput: React.FC<CellInputProps> = React.memo(
       );
     }
 
-    function handle_upload_click(): void {
-      if (props.actions == null) {
-        return;
-      }
-      props.actions.insert_image(props.id);
-    }
-
     function handle_md_double_click(): void {
       frameActions.current?.switch_md_cell_to_edit(props.cell.get("id"));
     }
@@ -208,14 +201,6 @@ export const CellInput: React.FC<CellInputProps> = React.memo(
             >
               <Icon name="edit" /> Edit
             </Button>
-            <Button
-              style={CODE_BAR_BTN_STYLE}
-              size="small"
-              type="text"
-              onClick={handle_upload_click}
-            >
-              <Icon name="image" />
-            </Button>
             <CellIndexNumber index={props.index} />
           </div>
         </div>

src/packages/frontend/jupyter/commands.ts

@@ -434,13 +434,6 @@ export function commands(actions: AllActions): {
       },
     },
 
-    "insert image": {
-      i: "image",
-      b: "Image",
-      m: "Insert Images in Markdown Cell",
-      f: () => actions.frame_actions?.insert_image(),
-    },
-
     "interrupt kernel": {
       i: "stop",
       b: "Stop",

src/packages/frontend/jupyter/insert-image.tsx

@@ -37,7 +37,6 @@ import { ConfirmDialog } from "./confirm-dialog";
 import { EditAttachments } from "./edit-attachments";
 import { EditCellMetadata } from "./edit-cell-metadata";
 import { FindAndReplace } from "./find-and-replace";
-import { InsertImage } from "./insert-image";
 import { JupyterContext } from "./jupyter-context";
 import useKernelUsage from "./kernel-usage";
 import KernelWarning from "./kernel-warning";
@@ -169,8 +168,6 @@ export const JupyterEditor: React.FC<Props> = React.memo((props: Props) => {
   ]);
   const path: undefined | string = useRedux([name, "path"]);
   const cell_toolbar: undefined | string = useRedux([name, "cell_toolbar"]);
-  // show insert image dialog
-  const insert_image: undefined | string = useRedux([name, "insert_image"]);
   const edit_attachments: undefined | string = useRedux([
     name,
     "edit_attachments",
@@ -336,19 +333,6 @@ export const JupyterEditor: React.FC<Props> = React.memo((props: Props) => {
     );
   }
 
-  function render_insert_image() {
-    if (insert_image == null || project_id == null) {
-      return;
-    }
-    return (
-      <InsertImage
-        actions={actions}
-        project_id={project_id}
-        insert_image={insert_image}
-      />
-    );
-  }
-
   function render_edit_attachments() {
     if (edit_attachments == null || cells == null) {
       return;
@@ -427,7 +411,6 @@ export const JupyterEditor: React.FC<Props> = React.memo((props: Props) => {
       <>
         {render_about()}
         {render_nbconvert()}
-        {render_insert_image()}
         {render_edit_attachments()}
         {render_edit_cell_metadata()}
         {render_find_and_replace()}

src/packages/frontend/jupyter/main.tsx

@@ -2094,16 +2094,6 @@ export abstract class JupyterActions extends Actions<JupyterStoreState> {
     ); // case to bool
   };
 
-  public insert_image(id: string): void {
-    if (this.check_edit_protection(id, "inserting an image")) {
-      return;
-    }
-    if (this.store.get_cell_type(id) != "markdown") {
-      throw Error("must be a markdown cell -- id " + id);
-    }
-    this.setState({ insert_image: id }); // causes a modal dialog to appear.
-  }
-
   scroll(pos): any {
     this.deprecated("scroll", pos);
   }

src/packages/jupyter/redux/actions.ts

@@ -71,7 +71,6 @@ export interface JupyterStoreState {
   find_and_replace: any;
   has_uncommitted_changes?: boolean;
   has_unsaved_changes?: boolean;
-  insert_image: string; // id of a markdown cell
   introspect: any;
   kernel_error?: string;
   kernel_info?: any;