widgets: properly set buffers -- at least now bqplot works

Author: williamstein

src/packages/frontend/jupyter/widgets/manager2.ts

@@ -239,10 +239,6 @@ export class WidgetManager {
     A simple example that uses buffers is this image one:
        https://ipywidgets.readthedocs.io/en/latest/examples/Widget%20List.html#image
     */
-
-    console.log("TEMPORARILY skipping buffers change!!");
-    return;
-
     const model = await this.manager.get_model(model_id);
     const { buffer_paths, buffers } =
       await this.ipywidgets_state.get_model_buffers(model_id);
@@ -254,16 +250,24 @@ export class WidgetManager {
       // TODO/concern: what if buffer_paths is deeper (length > 1)?
       // Will that break something?  We do set things properly later.
       const key = buffer_paths[i][0];
-      if (deserialized_state[key] == null) {
+      const buffer = buffers[i];
+      if (deserialized_state[key] == null || buffer == null) {
         change[key] = null;
         continue;
       }
-      const buffer = buffers[i];
-      const s = serializers[key]?.serialize(deserialized_state[key]) ?? {};
-      s.value = { buffer };
+      let s;
+      const f = serializers[key];
+      if (f != null) {
+        s = f.serialize(deserialized_state[key]);
+        s.value = { buffer };
+        s = f.deserialize(s);
+      } else {
+        s = { ...deserialized_state[key], value: buffer };
+      }
       change[key] = s;
     }
     log("handleBuffersChange: ", model_id, change);
+    window.x = { model, model_id, change };
     model.set_state(change);
   };
 

src/packages/util/db-schema/syncstring-schema.ts

@@ -120,7 +120,7 @@ Table({
               } else {
                 cb(err);
               }
-            }
+            },
           );
         },
       },
@@ -159,7 +159,7 @@ Table({
             old_val,
             new_val,
             account_id,
-            cb
+            cb,
           );
         },
       },
@@ -340,7 +340,7 @@ Table({
             obj,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
@@ -366,7 +366,7 @@ Table({
             obj,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
         before_change(_db, old_val, new_val, _account_id, cb) {
@@ -381,7 +381,7 @@ Table({
               old_val.user_id !== new_val.user_id
             ) {
               cb(
-                `you may not change the author of a patch from ${old_val.user_id} to ${new_val.user_id}`
+                `you may not change the author of a patch from ${old_val.user_id} to ${new_val.user_id}`,
               );
               return;
             }
@@ -493,7 +493,7 @@ Table({
             obj,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
@@ -515,7 +515,7 @@ Table({
             obj,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
@@ -566,7 +566,7 @@ Table({
             obj.string_id,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
@@ -588,7 +588,7 @@ Table({
             obj.string_id,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
@@ -637,7 +637,7 @@ Table({
             obj.string_id,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
@@ -659,7 +659,7 @@ Table({
             obj.string_id,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
@@ -709,11 +709,12 @@ Table({
             obj.string_id,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },
       set: {
+        delete: true,
         fields: {
           string_id: true,
           model_id: true,
@@ -731,7 +732,7 @@ Table({
             obj.string_id,
             account_id,
             project_id,
-            cb
+            cb,
           );
         },
       },