Merge pull request #8830 from sagemathinc/fix-latex-error-popup-during-typing

fix(latex): suppress error toast when build/output/errors frame is visible

Author: haraldschilly

src/packages/frontend/frame-editors/latex-editor/actions.ts

@@ -820,6 +820,32 @@ export class Actions extends BaseActions<LatexEditorState> {
     return this._new_frame_tree_layout();
   }
 
+  // Frame types (EDITOR_SPEC keys) that already display build errors.
+  // https://github.com/sagemathinc/cocalc/issues/8659
+  private static ERROR_DISPLAY_FRAMES = [
+    "output",
+    "build",
+    "error",
+  ] as const;
+
+  private hasErrorDisplayFrame(): boolean {
+    try {
+      const tree = this._get_tree();
+      for (const id in this._get_leaf_ids()) {
+        const node = tree_ops.get_node(tree, id);
+        if (
+          node != null &&
+          (Actions.ERROR_DISPLAY_FRAMES as readonly string[]).includes(
+            node.get("type"),
+          )
+        ) {
+          return true;
+        }
+      }
+    } catch {}
+    return false;
+  }
+
   check_for_fatal_error(): void {
     const build_logs: BuildLogs = this.store.get("build_logs");
     if (!build_logs) return;
@@ -841,7 +867,11 @@ export class Actions extends BaseActions<LatexEditorState> {
         "WARNING: It is not possible to generate a useful PDF file.\n" +
         s.trim();
       console.warn(err);
-      this.set_error(err);
+      // Only show toast if no error-displaying frame is visible —
+      // if one is, the user can already see the problem there.
+      if (!this.hasErrorDisplayFrame()) {
+        this.set_error(err);
+      }
     }
   }
 

src/packages/frontend/frame-editors/latex-editor/output.tsx

@@ -505,11 +505,20 @@ export function Output(props: OutputProps) {
 
   function renderProblemsTab() {
     const { errors, warnings, typesetting } = errorCounts;
-
     return {
       key: "problems",
       label: (
-        <span style={LABEL_STYLE}>
+        <span
+          style={{
+            ...LABEL_STYLE,
+            ...(errors > 0
+              ? {
+                  backgroundColor: "rgba(255, 0, 0, 0.1)",
+                  borderRadius: "4px",
+                }
+              : undefined),
+          }}
+        >
           <Icon name="bug" style={{ marginRight: "0" }} />
           {intl.formatMessage(editor.errors_and_warnings_title_short)}
           {renderProblemsCounter(errors, warnings, typesetting)}