dns scan: don't read files on import (since this breaks all non-k8s use); use async file read

Author: williamstein

src/packages/server/conat/socketio/dns-scan-k8s-api.ts

@@ -1,87 +1,91 @@
-import * as fs from "fs";
+import { readFile } from "fs/promises";
 import * as https from "https";
 
 // Define the options interface for type safety
 interface ListPodsOptions {
   labelSelector?: string; // e.g. "app=foo,env=prod"
 }
 
-const NAMESPACE: string = fs
-  .readFileSync(
-    "/var/run/secrets/kubernetes.io/serviceaccount/namespace",
-    "utf8",
-  )
-  .trim();
-const CA: Buffer = fs.readFileSync(
-  "/var/run/secrets/kubernetes.io/serviceaccount/ca.crt",
-);
+let NAMESPACE: string | null = null;
+let CA: Buffer | null = null;
 
 async function listPods(options: ListPodsOptions = {}): Promise<any> {
+  let token: string;
   try {
-    // Read service account details, token could be rotated
-    const token = fs
-      .readFileSync(
+    NAMESPACE =
+      NAMESPACE ??
+      (
+        await readFile(
+          "/var/run/secrets/kubernetes.io/serviceaccount/namespace",
+          "utf8",
+        )
+      ).trim();
+    CA =
+      CA ??
+      (await readFile("/var/run/secrets/kubernetes.io/serviceaccount/ca.crt"));
+
+    // Read service account details, token could be rotated, so read every time
+    token = (
+      await readFile(
         "/var/run/secrets/kubernetes.io/serviceaccount/token",
         "utf8",
       )
-      .trim();
+    ).trim();
+  } catch (err) {
+    throw new Error(`Failed to read service account files: ${err}`);
+  }
 
-    // Base API path
-    let path = `/api/v1/namespaces/${NAMESPACE}/pods`;
+  // Base API path
+  let path = `/api/v1/namespaces/${NAMESPACE}/pods`;
 
-    const queryParams: string[] = [];
-    if (options.labelSelector) {
-      queryParams.push(
-        `labelSelector=${encodeURIComponent(options.labelSelector)}`,
-      );
-    }
+  const queryParams: string[] = [];
+  if (options.labelSelector) {
+    queryParams.push(
+      `labelSelector=${encodeURIComponent(options.labelSelector)}`,
+    );
+  }
 
-    if (queryParams.length > 0) {
-      path += `?${queryParams.join("&")}`;
-    }
+  if (queryParams.length > 0) {
+    path += `?${queryParams.join("&")}`;
+  }
 
-    const query: https.RequestOptions = {
-      hostname: "kubernetes.default.svc",
-      path,
-      method: "GET",
-      headers: {
-        Authorization: `Bearer ${token}`,
-        Accept: "application/json",
-      },
-      ca: [CA],
-    };
+  const query: https.RequestOptions = {
+    hostname: "kubernetes.default.svc",
+    path,
+    method: "GET",
+    headers: {
+      Authorization: `Bearer ${token}`,
+      Accept: "application/json",
+    },
+    ca: [CA],
+  };
 
-    return new Promise((resolve, reject) => {
-      const req = https.request(query, (res) => {
-        let data = "";
-        res.on("data", (chunk) => {
-          data += chunk;
-        });
-        res.on("end", () => {
-          if (res.statusCode !== 200) {
-            reject(
-              new Error(
-                `K8S API request failed. status=${res.statusCode}: ${data}`,
-              ),
-            );
-          } else {
-            try {
-              resolve(JSON.parse(data));
-            } catch (parseError) {
-              reject(parseError);
-            }
+  return new Promise((resolve, reject) => {
+    const req = https.request(query, (res) => {
+      let data = "";
+      res.on("data", (chunk) => {
+        data += chunk;
+      });
+      res.on("end", () => {
+        if (res.statusCode !== 200) {
+          reject(
+            new Error(
+              `K8S API request failed. status=${res.statusCode}: ${data}`,
+            ),
+          );
+        } else {
+          try {
+            resolve(JSON.parse(data));
+          } catch (parseError) {
+            reject(parseError);
           }
-        });
+        }
       });
-
-      req.on("error", (error) => reject(error));
-      req.end();
     });
-  } catch (error) {
-    throw new Error(
-      `Failed to read service account files: ${(error as Error).message}`,
-    );
-  }
+
+    req.on("error", (error) => reject(error));
+    req.end();
+  });
 }
 
 export async function getAddressesFromK8sApi(): Promise<