Skip to content

Commit c66d863

Browse files
authored
Merge pull request #8596 from sagemathinc/fix-conat-logging-8548
switch to backticks for string interpolation
2 parents 26ef90d + 758ecfd commit c66d863

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/packages/conat/socket/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ export class ConatSocketServer extends ConatSocketBase {
211211
try {
212212
await socket.end({ timeout });
213213
} catch (err) {
214-
console.log("WARNING: error ending socket -- ${err}");
214+
console.log(`WARNING: error ending socket -- ${err}`);
215215
}
216216
};
217217
await Promise.all(Object.keys(this.sockets).map(end));

src/packages/frontend/jupyter/nbgrader/clear-mark-regions.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function replace_mark_region(input: string): string | undefined {
3131
// check to make sure this isn't a nested BEGIN MARK SCHEME region
3232
if (in_region)
3333
throw Error(
34-
"encountered nested ${begin_delimiter}, which is not allowed"
34+
`encountered nested ${begin_delimiter}, which is not allowed`,
3535
);
3636

3737
in_region = true;
@@ -52,7 +52,7 @@ function replace_mark_region(input: string): string | undefined {
5252
// we finished going through all the lines, but didn't find a
5353
// matching END statement
5454
if (in_region) {
55-
throw Error("no matching ${end_delimiter} found");
55+
throw Error(`no matching ${end_delimiter} found`);
5656
}
5757

5858
// replace the area?

src/packages/server/conat/socketio/health.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export function handleHealth(
1414
res: ServerResponse,
1515
) {
1616
const healthy = server.isHealthy();
17-
logger.debug("/health reporting conat is healthy=${healthy}");
17+
logger.debug(`/health reporting conat is healthy=${healthy}`);
1818
if (healthy) {
1919
res.statusCode = 200;
2020
res.end("healthy");

0 commit comments

Comments
 (0)