typescript issues

Author: williamstein

src/packages/backend/conat/test/persist/backup-archive.test.ts

@@ -5,7 +5,6 @@ Testing automatic tiered storage and backup persistence functionality.
 import {
   before,
   after,
-  connect,
   delay,
   client,
   wait,
@@ -16,7 +15,6 @@ import { pathExists } from "fs-extra";
 import { join } from "path";
 import * as fs from "fs/promises";
 import { messageData } from "@cocalc/conat/core/client";
-import { executeCode } from "@cocalc/backend/execute-code";
 import sqlite from "better-sqlite3";
 import { openPaths } from "@cocalc/conat/persist/storage";
 
@@ -89,11 +87,6 @@ describe("create persist server that also saves data to an archive folder and a
     // at this point the actual sqlite3 database should be closed
   });
 
-  const sha1 = async (path) => {
-    const { stdout } = await executeCode({ command: "sha1sum", args: [path] });
-    return stdout;
-  };
-
   it("the backup, archive, and local files should all be identical as sqlite database", async () => {
     // they are not the same as files though so we need some care to compare them.
     expect(await serialize(local)).toEqual(await serialize(backup));

src/packages/conat/persist/storage.ts

@@ -330,7 +330,11 @@ export class PersistentStream extends EventEmitter {
   };
 
   close = async () => {
-    logger.debug("close ", this.options.path);
+    const path = this.options?.path;
+    if (path == null) {
+      return;
+    }
+    logger.debug("close ", path);
     if (this.db != null) {
       this.vacuum();
       this.db.prepare("PRAGMA wal_checkpoint(FULL)").run();
@@ -345,7 +349,7 @@ export class PersistentStream extends EventEmitter {
     this.msgIDs?.clear();
     // @ts-ignore
     delete this.msgIDs;
-    openPaths.delete(options.path);
+    openPaths.delete(path);
   };
 
   private backup = reuseInFlight(async (path?: string): Promise<void> => {