chat: properly embed fragment in mention

- this code is definitely painful and hard to follow.  sorry...

Author: williamstein

src/packages/frontend/chat/actions.ts

@@ -162,28 +162,37 @@ export class ChatActions extends Actions<ChatState> {
     reply_to,
     tag,
     noNotification,
+    submitMentionsRef,
   }: {
     input?: string;
     sender_id?: string;
     reply_to?: Date;
     tag?: string;
     noNotification?: boolean;
+    submitMentionsRef?;
   }): string => {
     if (this.syncdb == null || this.store == null) {
       console.warn("attempt to sendChat before chat actions initialized");
       // WARNING: give an error or try again later?
       return "";
     }
+    if (this.store.get("is_uploading")) {
+      // do not send while uploading, since would be mangled.
+      return "";
+    }
+    const time_stamp: Date = webapp_client.server_time();
+    const time_stamp_str = time_stamp.toISOString();
+    if (submitMentionsRef?.current != null) {
+      input = submitMentionsRef.current?.({ chat: `${time_stamp.valueOf()}` });
+    }
     if (input == null) {
       input = this.store.get("input");
     }
     input = input.trim();
-    if (input.length == 0 || this.store.get("is_uploading")) {
-      // do not send while uploading or there is nothing to send.
+    if (input.length == 0) {
+      // do not send when there is nothing to send.
       return "";
     }
-    const time_stamp: Date = webapp_client.server_time();
-    const time_stamp_str = time_stamp.toISOString();
     const message: ChatMessage = {
       sender_id,
       event: "chat",
@@ -345,12 +354,14 @@ export class ChatActions extends Actions<ChatState> {
     from,
     noNotification,
     reply_to,
+    submitMentionsRef,
   }: {
     message: ChatMessage;
-    reply: string;
+    reply?: string;
     from?: string;
     noNotification?: boolean;
     reply_to?: Date;
+    submitMentionsRef?;
   }): string => {
     const store = this.store;
     if (store == null) {
@@ -369,6 +380,7 @@ export class ChatActions extends Actions<ChatState> {
           });
     const time_stamp_str = this.sendChat({
       input: reply,
+      submitMentionsRef,
       sender_id: from ?? this.redux.getStore("account").get_account_id(),
       reply_to: new Date(reply_to_value),
       noNotification,

src/packages/frontend/chat/chatroom.tsx

@@ -267,9 +267,8 @@ export function ChatRoom({
   }
 
   function on_send(): void {
-    const input = submitMentionsRef.current?.();
     scrollToBottomRef.current?.(true);
-    actions.sendChat({ input });
+    actions.sendChat({ submitMentionsRef });
     setTimeout(() => {
       scrollToBottomRef.current?.(true);
     }, 100);

src/packages/frontend/chat/message.tsx

@@ -653,7 +653,9 @@ export default function Message(props: Readonly<Props>) {
 
   function saveEditedMessage(): void {
     if (props.actions == null) return;
-    const mesg = submitMentionsRef.current?.() ?? edited_message_ref.current;
+    const mesg =
+      submitMentionsRef.current?.({ chat: `${date}` }) ??
+      edited_message_ref.current;
     const value = newest_content(message);
     if (mesg !== value) {
       set_edited_message(mesg);
@@ -717,10 +719,14 @@ export default function Message(props: Readonly<Props>) {
   function sendReply(reply?: string) {
     if (props.actions == null) return;
     setReplying(false);
-    if (!reply) {
-      reply = replyMentionsRef.current?.() ?? replyMessageRef.current;
+    if (!reply && !replyMentionsRef.current?.(undefined, true)) {
+      reply = replyMessageRef.current;
     }
-    props.actions.sendReply({ message: message.toJS(), reply });
+    props.actions.sendReply({
+      message: message.toJS(),
+      reply,
+      submitMentionsRef: replyMentionsRef,
+    });
     props.actions.scrollToIndex(props.index);
   }
 

src/packages/frontend/chat/side-chat.tsx

@@ -75,8 +75,7 @@ export default function SideChat({
 
   const sendChat = useCallback(
     (options?) => {
-      const input = submitMentionsRef.current?.();
-      actions.sendChat({ input, ...options });
+      actions.sendChat({ submitMentionsRef, ...options });
       actions.deleteDraft(0);
       scrollToBottomRef.current?.(true);
       setTimeout(() => {