Merge pull request #8564 from sagemathinc/latex-no-timeout

Latex Timeout Fix

Author: williamstein

src/packages/frontend/cspell.json

@@ -7,12 +7,14 @@
     "ARIMA",
     "autograde",
     "autograding",
+    "bibtex",
     "Bioconductor",
     "bioinformatics",
     "CoCalc",
     "conat",
     "dplyr",
     "dstream",
+    "errorstopmode",
     "formatjs",
     "geospatial",
     "ggplot",
@@ -22,15 +24,21 @@
     "katex",
     "knitr",
     "kucalc",
+    "latexmk",
+    "lualatex",
+    "luatex",
     "mathjax",
     "matplotlib",
     "Miniterm",
     "nbconvert",
     "nbgrader",
     "nbviewer",
+    "nonstopmode",
     "Ollama",
     "onprem",
+    "pdflatex",
     "plotly",
+    "pythontex",
     "rclass",
     "rereturn",
     "respawns",
@@ -53,7 +61,10 @@
     "synctex",
     "tidymodels",
     "tidyverse",
+    "tikz",
     "timetravel",
+    "xelatex",
+    "xetex",
     "tolerations",
     "undelete",
     "undeleting"

src/packages/frontend/frame-editors/code-editor/actions.ts

@@ -64,7 +64,7 @@ import {
   syntax2tool,
 } from "@cocalc/util/code-formatter";
 import {
-  IS_TIMEOUT_CALLING_PROJECT,
+  isTimeoutCallingProject,
   TIMEOUT_CALLING_PROJECT_MSG,
 } from "@cocalc/util/consts/project";
 import {
@@ -1921,7 +1921,7 @@ export class Actions<
     if (error === undefined) {
       return "";
     }
-    if (IS_TIMEOUT_CALLING_PROJECT(error)) {
+    if (isTimeoutCallingProject(error)) {
       return TIMEOUT_CALLING_PROJECT_MSG;
     }
     if (typeof error == "string") {

src/packages/frontend/frame-editors/latex-editor/build.tsx

@@ -9,7 +9,7 @@ Show the last latex build log, i.e., output from last time we ran the LaTeX buil
 
 import Ansi from "@cocalc/frontend/components/ansi-to-react";
 import { Button, Flex, Tooltip } from "antd";
-import { Fragment, useState } from "react";
+import { Fragment, useEffect, useMemo, useRef, useState } from "react";
 
 import { AntdTabItem, Tab, Tabs } from "@cocalc/frontend/antd-bootstrap";
 import { CSS, React, Rendered, useRedux } from "@cocalc/frontend/app-framework";
@@ -52,6 +52,25 @@ export const Build: React.FC<Props> = React.memo((props) => {
     BUILD_SPECS.latex.label,
   );
   const [error_tab, set_error_tab] = useState<string | null>(null);
+  const logContainerRef = useRef<HTMLDivElement>(null);
+  const [shownLog, setShownLog] = useState<string>("");
+
+  // Compute whether we have running jobs - this determines UI precedence
+  const hasRunningJobs = useMemo(() => {
+    return (
+      build_logs?.some((job) => {
+        const jobJS: BuildLog = job?.toJS();
+        return jobJS?.type === "async" && jobJS?.status === "running";
+      }) ?? false
+    );
+  }, [build_logs]);
+
+  // Auto-scroll to bottom when log updates
+  useEffect(() => {
+    if (logContainerRef.current) {
+      logContainerRef.current.scrollTop = logContainerRef.current.scrollHeight;
+    }
+  }, [shownLog]);
 
   let no_errors = true;
 
@@ -179,7 +198,8 @@ export const Build: React.FC<Props> = React.memo((props) => {
   }
 
   function render_logs(): Rendered {
-    if (status) return;
+    // Hide logs when jobs are running - show live output instead
+    if (hasRunningJobs) return;
 
     const items: AntdTabItem[] = [];
 
@@ -230,12 +250,17 @@ export const Build: React.FC<Props> = React.memo((props) => {
     const infos: React.JSX.Element[] = [];
     let isLongRunning = false;
     let logTail = "";
+
     build_logs.forEach((infoI, key) => {
       const info: ExecuteCodeOutput = infoI?.toJS();
       if (!info || info.type !== "async" || info.status !== "running") return;
       const stats_str = getResourceUsage(info.stats, "last");
       const start = info.start;
-      logTail = tail((info.stdout ?? "") + (info.stderr ?? ""), 6);
+      logTail = tail((info.stdout ?? "") + (info.stderr ?? ""), 100);
+      // Update state for auto-scrolling effect
+      if (logTail !== shownLog) {
+        setShownLog(logTail);
+      }
       isLongRunning ||=
         typeof start === "number" &&
         webapp_client.server_time() - start > WARN_LONG_RUNNING_S * 1000;
@@ -287,19 +312,36 @@ export const Build: React.FC<Props> = React.memo((props) => {
             </Tooltip>
           </Flex>
         </div>
-        <div style={logStyle}>
+        <div
+          style={{
+            ...logStyle,
+            maxHeight: "300px",
+            overflow: "hidden",
+            display: "flex",
+            flexDirection: "column",
+          }}
+        >
           <div
             style={{
               fontWeight: "bold",
               whiteSpace: "nowrap",
               overflow: "hidden",
               textOverflow: "ellipsis",
+              flexShrink: 0,
             }}
           >
             {status}
             {"\n"}
           </div>
-          {logTail}
+          <div
+            ref={logContainerRef}
+            style={{
+              overflowY: "auto",
+              flexGrow: 1,
+            }}
+          >
+            <Ansi>{shownLog}</Ansi>
+          </div>
         </div>
       </>
     );

src/packages/frontend/frame-editors/latex-editor/latexmk.ts

@@ -168,7 +168,7 @@ export function build_command(
   /*
     -f: force even when there are errors
     -g: ignore heuristics to stop processing latex (sagetex)
-    silent: **don't** set -silent, also silences sagetex mesgs!
+    silent: **don't** set -silent, also silences sagetex messages!
     bibtex: a default, run bibtex when necessary
     synctex: forward/inverse search in pdf
     nonstopmode: continue after errors (otherwise, partial files)

src/packages/frontend/frame-editors/latex-editor/util.ts

@@ -10,7 +10,7 @@ import {
   ExecOpts,
   ExecOutput,
 } from "@cocalc/frontend/frame-editors/generic/client";
-import { IS_TIMEOUT_CALLING_PROJECT } from "@cocalc/util/consts/project";
+import { isTimeoutCallingProject } from "@cocalc/util/consts/project";
 import { ExecOptsBlocking } from "@cocalc/util/db-schema/projects";
 import { separate_file_extension } from "@cocalc/util/misc";
 import { ExecuteCodeOutputAsync } from "@cocalc/util/types/execute-code";
@@ -99,7 +99,7 @@ async function gatherJobInfo(
         return;
       }
       await delay(1000 * wait_s);
-      wait_s = Math.min(5, wait_s + 1);
+      wait_s = Math.min(3, wait_s + 0.5);
     }
   } catch {
     return;
@@ -177,7 +177,7 @@ export async function runJob(opts: RunJobOpts): Promise<ExecOutput> {
       set_job_info(output);
       return output;
     } catch (err) {
-      if (IS_TIMEOUT_CALLING_PROJECT(err)) {
+      if (isTimeoutCallingProject(err)) {
         // This will eventually be fine, hopefully. We continue trying to get a reply.
         await delay(100);
       } else {

src/packages/util/consts/project.ts

@@ -10,9 +10,20 @@ export const TIMEOUT_CALLING_PROJECT = "timeout";
 export const TIMEOUT_CALLING_PROJECT_MSG =
   "Timeout communicating with project.";
 
-export const IS_TIMEOUT_CALLING_PROJECT = (err) => {
+/**
+ * Checks if an error represents a timeout when communicating with a project.
+ *
+ * Handles both legacy and conat-based timeout errors:
+ * - Legacy: String "timeout"
+ * - Conat: ConatError with code 408 (HTTP Request Timeout)
+ *   See @cocalc/conat/core/client.ts lines 1391, 1937-1939 where 408 timeouts are thrown
+ */
+export function isTimeoutCallingProject(err): boolean {
   if (err === TIMEOUT_CALLING_PROJECT) {
     return true;
   }
+  if (err?.constructor?.name === "ConatError" && err?.code === 408) {
+    return true;
+  }
   return false;
-};
+}