Skip to content

Commit ee231b3

Browse files
committed
fix react key error in jupyter kernel list
1 parent 7b68eeb commit ee231b3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/packages/frontend/jupyter/select-kernel.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import {
1919
} from "antd";
2020
import { Map as ImmutableMap, List, OrderedMap } from "immutable";
2121
import { FormattedMessage, useIntl } from "react-intl";
22-
2322
import {
2423
CSS,
2524
React,
@@ -140,9 +139,10 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
140139
const priority: number = kernels_by_name
141140
?.get(name)
142141
?.getIn(["metadata", "cocalc", "priority"]) as number;
142+
const key = `kernel-${lang}-${name}`;
143143
const btn = (
144144
<Button
145-
key={`kernel-${lang}-${name}`}
145+
key={key}
146146
onClick={() => {
147147
actions.select_kernel(name);
148148
track("jupyter", {
@@ -167,7 +167,7 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
167167
return btn;
168168
}
169169
return (
170-
<Tooltip color="white" title={render_suggested_link(cocalc)}>
170+
<Tooltip key={key} color="white" title={render_suggested_link(cocalc)}>
171171
{btn}
172172
</Tooltip>
173173
);
@@ -200,7 +200,7 @@ export const KernelSelector: React.FC<KernelSelectorProps> = React.memo(
200200
const label = render_kernel_button(name);
201201

202202
entries.push(
203-
<Descriptions.Item key={lang} label={label}>
203+
<Descriptions.Item key={name} label={label}>
204204
<div>{render_suggested_link(cocalc)}</div>
205205
</Descriptions.Item>,
206206
);

0 commit comments

Comments
 (0)