finished migrating the entire frickin' test suite!!

Author: williamstein

lib/http-proxy/index.ts

@@ -27,7 +27,10 @@ export type ProxyTarget = ProxyTargetUrl | ProxyTargetDetailed;
 export type ProxyTargetUrl = URL | string;
 
 export interface ServerOptions {
-  // NOTE: `options.target and `options.forward` cannot be both missing.
+  // NOTE: `options.target and `options.forward` cannot be both missing when the 
+  // actually proxying is called.  However, they can be missing when creating the
+  // proxy server in the first place!  E.g., you could make a proxy server P with 
+  // no options, then use P.web(req,res, {target:...}).
   // URL string to be parsed with the url module.
   target?: ProxyTarget;
   // URL string to be parsed with the url module or a URL object.

lib/http-proxy/passes/ws-incoming.ts

@@ -211,7 +211,11 @@ export function stream(
     } else {
       server.emit("error", err, req, socket);
     }
-    socket.end();
+    // I changed this from "socket.end()" which is what node-http-proxy does to destroySoon() due to getting
+    // the unit test "should close client socket if upstream is closed before upgrade" from lib/http-proxy.test.ts
+    // to work.  Just doing socket.end() leaves things half open for a while if proxySocket errors out,
+    // which may be another leak type situation and definitely doesn't work for unit testing.
+    socket.destroySoon();
   }
 
   proxyReq.end();