Error on startup when applying user capabilities

[presjpolk]

Make sure you have done the following

• Updated to the latest version of blink.cmp
• Searched for existing issues and documentation (try <C-k> on https://cmp.saghen.dev)

Bug Description

Issue #2288 complained that a user's vim.lsp.config would be overridden. So the start of blink-cmp.lua does this now:

if vim.fn.has('nvim-0.11') == 1 and vim.lsp.config then
  local user_caps = vim.lsp.config['*'].capabilities

  vim.lsp.config('*', {
    capabilities = require('blink.cmp').get_lsp_capabilities(user_caps),
  })
end

This fails if vim.lsp.config['*'] is not set by the user before blink-cmp loads, because it's indexing into a nil value instead of a table.

Proposed fix: change line 2 to

local user_caps = vim.lsp.config['*'] and vim.lsp.config['*'].capabilities or {}

Relevant configuration

Happens with any config.

neovim version

0.11

blink.cmp version

1.9.1

[soifou]

This fails if vim.lsp.config['*'] is not set by the user before blink-cmp loads, because it's indexing into a nil value instead of a table.

How does it fail? Could you provide a minimal repro?

vim.lsp.config isn't a plain Lua table, it's a metatable, so vim.lsp.config['*'] doesn't behave like a raw nil, and accessing .capabilities on it won't error even if the user never defined a '*' config.

You can verify it quickly with:

:= vim.lsp.config['*']
:= vim.lsp.config['*'].capabilities
:= getmetatable(vim.lsp.config)

The defensive check doesn't really hurt, but it looks redundant with the current behavior.

[presjpolk]

vim.lsp.config['*'] is nil when it runs for me. That's the fail state I'm seeing. I'm loading you up in Lazy to support CodeCompanion. I don't know how to load just your code without any other code.

[soifou]

I still don't get what's your issue. vim.lsp.config['*'] returning nil is fine! := require('blink.cmp').get_lsp_capabilities(nil) returns a proper capabilities table on nvim 0.11+.

Can you share what actually breaks for you?

[presjpolk]

Error while calling lua chunk
.../nvim/data/lazy/blink.cmp/plugin/blink-cmp.lua:2: attempt to index field '*' (a nil value)

the problem is line TWO. Your user_caps line is indexing into vim.lsp.config['*'] without checking if THAT is nil.