Skip to content

Commit 0210f68

Browse files
author
Sascha Goldhofer
committed
Refactor remove view abstraction
1 parent 16f0931 commit 0210f68

File tree

4 files changed

+17
-42
lines changed

4 files changed

+17
-42
lines changed

completion.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ def resolve_trigger(view, query):
6060
return trigger
6161

6262

63-
def get_filepaths(view, query, current_file):
63+
def get_filepaths(view, query):
6464
global start_expression
6565

6666
trigger = resolve_trigger(view, query)
6767
log(ID_TRIGGER, trigger)
68-
if query.build(start_expression.get("needle"), trigger, current_file.get_directory()) is False:
68+
if query.build(start_expression.get("needle"), trigger, current_state.get_directory()) is False:
6969
# query is valid, but may not be triggered: not forced, no auto-options
7070
verbose(ID, "abort - no auto trigger found")
7171
return False
@@ -75,7 +75,7 @@ def get_filepaths(view, query, current_file):
7575

7676
return current_state.search_completions(
7777
query.get_needle(),
78-
current_file.get_project_directory(),
78+
current_state.get_project_directory(),
7979
query.get_extensions(),
8080
query.get_base_path()
8181
)

controller.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def get_filepath_completions(view):
3535
return False
3636

3737
verbose(ID, "get filepath completions")
38-
completions = Completion.get_filepaths(view, Query, state.get_view())
38+
completions = Completion.get_filepaths(view, Query)
3939

4040
if completions and len(completions[0]) > 0:
4141
Completion.start(Query.get_replacements())

current_state.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
import sublime
99
import os
10+
import re
1011
import FuzzyFilePath.common.settings as settings
1112
from FuzzyFilePath.project.FileCache import FileCache
12-
from FuzzyFilePath.project.View import View
1313
import FuzzyFilePath.common.path as Path
1414
import FuzzyFilePath.common.verbose as logger
1515

@@ -66,9 +66,9 @@ def update():
6666

6767
# @TODO cache
6868
state["file"] = file
69+
state["directory"] = sanitize_directory(file, project_folder)
6970
state["folders"] = folders
7071
state["project_folder"] = project_folder
71-
state["view"] = View(project_folder, file)
7272
state["cache"] = get_file_cache(project_folder)
7373

7474
logger.start_block()
@@ -77,24 +77,30 @@ def update():
7777
return valid
7878

7979

80+
def sanitize_directory(file_name, project_folder):
81+
directory = re.sub(project_folder, "", file_name)
82+
directory = re.sub("^[\\\\/\.]*", "", directory)
83+
return os.path.dirname(directory)
84+
85+
8086
def get_project_directory():
8187
return state.get("project_folder")
8288

8389

90+
def get_directory():
91+
return state.get("directory")
92+
93+
8494
def update_settings():
8595
if state.get("project_folder"):
96+
# we expect settings to be already updated and thus only update the project folder settings
8697
settings.update_project_folder_settings(state.get("project_folder"))
8798

8899

89100
def is_valid():
90101
return valid
91102

92103

93-
def get_view():
94-
""" legacy: return the current view """
95-
return state.get("view")
96-
97-
98104
def enable():
99105
global is_enabled
100106
is_enabled = True

project/View.py

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)