httpx: decouple tests from proxy related environment variables (open-telemetry#2822)

xrmx · web-flow · commit 5558e78d8c17 · 2024-08-26T12:24:53.000-07:00
diff --git a/instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py b/instrumentation/opentelemetry-instrumentation-httpx/tests/test_httpx_integration.py
@@ -723,6 +723,7 @@ def test_client_mounts_with_instrumented_transport(self):
                 spans[1].attributes[SpanAttributes.HTTP_URL], https_url
             )
 
+    @mock.patch.dict("os.environ", {"NO_PROXY": ""}, clear=True)
     class BaseInstrumentorTest(BaseTest, metaclass=abc.ABCMeta):
         @abc.abstractmethod
         def create_client(

Original file line number	Diff line number	Diff line change
`@@ -723,6 +723,7 @@ def test_client_mounts_with_instrumented_transport(self):`
`723`	`723`	`spans[1].attributes[SpanAttributes.HTTP_URL], https_url`
`724`	`724`	`)`
`725`	`725`
	`726`	`+ @mock.patch.dict("os.environ", {"NO_PROXY": ""}, clear=True)`
`726`	`727`	`class BaseInstrumentorTest(BaseTest, metaclass=abc.ABCMeta):`
`727`	`728`	`@abc.abstractmethod`
`728`	`729`	`def create_client(`