add tests

Author: TheAnshul756

instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py

@@ -67,6 +67,7 @@
     route_span_name,
     traced,
     traced_template,
+    DummyMiddleware,
 )
 
 DJANGO_2_0 = VERSION >= (2, 0)
@@ -144,6 +145,42 @@ def tearDown(self):
     def tearDownClass(cls):
         super().tearDownClass()
         conf.settings = conf.LazySettings()
+    
+    def test_middleware_added_at_position(self):
+        _django_instrumentor.uninstrument()
+        if DJANGO_2_0:
+            middleware = conf.settings.MIDDLEWARE
+        else:
+            middleware = conf.settings.MIDDLEWARE_CLASSES
+        # adding two dummy middlewares
+        temprory_middelware = "django.utils.deprecation.MiddlewareMixin"
+        middleware.append(temprory_middelware)
+        middleware.append(temprory_middelware)
+        
+        middleware_position = 1
+        _django_instrumentor.instrument(middleware_position=middleware_position)
+        self.assertEqual(
+            middleware[middleware_position],
+            "opentelemetry.instrumentation.django.middleware.otel_middleware._DjangoMiddleware"
+        )
+        
+    
+    def test_middleware_added_at_position_if_wrong_position(self):
+        _django_instrumentor.uninstrument()
+        if DJANGO_2_0:
+            middleware = conf.settings.MIDDLEWARE
+        else:
+            middleware = conf.settings.MIDDLEWARE_CLASSES
+        # adding middleware
+        temprory_middelware = "django.utils.deprecation.MiddlewareMixin"
+        middleware.append(temprory_middelware)
+        middleware_position = 756 # wrong position out of bound of middleware length
+        _django_instrumentor.instrument(middleware_position=middleware_position)
+        self.assertEqual(
+            middleware[len(middleware) - 1],
+            "opentelemetry.instrumentation.django.middleware.otel_middleware._DjangoMiddleware"
+        )
+
 
     def test_templated_route_get(self):
         Client().get("/route/2020/template/")

instrumentation/opentelemetry-instrumentation-django/tests/test_sqlcommenter.py

@@ -71,6 +71,34 @@ def test_middleware_added(self, sqlcommenter_middleware):
             "opentelemetry.instrumentation.django.middleware.sqlcommenter_middleware.SqlCommenter"
             in middleware
         )
+    
+    @patch(
+        "opentelemetry.instrumentation.django.middleware.sqlcommenter_middleware.SqlCommenter"
+    )
+    def test_middleware_added_at_position(self, sqlcommenter_middleware):
+        _django_instrumentor.uninstrument()
+        if DJANGO_2_0:
+            middleware = conf.settings.MIDDLEWARE
+        else:
+            middleware = conf.settings.MIDDLEWARE_CLASSES
+        
+        # adding two dummy middlewares
+        temprory_middelware = "django.utils.deprecation.MiddlewareMixin"
+        middleware.append(temprory_middelware)
+        middleware.append(temprory_middelware)
+        
+        middleware_position = 1
+        _django_instrumentor.instrument(is_sql_commentor_enabled=True, middleware_position=middleware_position)
+        instance = sqlcommenter_middleware.return_value
+        instance.get_response = HttpResponse()
+        self.assertEqual(
+            middleware[middleware_position],
+            "opentelemetry.instrumentation.django.middleware.otel_middleware._DjangoMiddleware"
+        )
+        self.assertEqual(
+            middleware[middleware_position + 1],
+            "opentelemetry.instrumentation.django.middleware.sqlcommenter_middleware.SqlCommenter"
+        )
 
     @patch(
         "opentelemetry.instrumentation.django.middleware.sqlcommenter_middleware._get_opentelemetry_values"

instrumentation/opentelemetry-instrumentation-django/tests/views.py

@@ -82,3 +82,10 @@ async def async_with_custom_header(request):
     response.headers["custom-test-header-1"] = "test-header-value-1"
     response.headers["custom-test-header-2"] = "test-header-value-2"
     return response
+
+class DummyMiddleware:
+    def __init__(self, get_response):
+        self.get_response = get_response
+
+    def __call__(self, request):
+        return self.get_response(request)