chore(appset/templates): remove annotations from GitHub and GitLab templates (#252)

* chore(appset/templates): remove annotations from GitHub and GitLab templates

* chore(projects/values): add default empty list for destinationServiceAccounts spec

* chore(docs): update prerequisites for Kubernetes, ArgoCD, and HELM versions

* chore(chart): update version and kubeVersion, refine annotations in Chart.yaml

* chore(workflows): update kubectl and node image versions for compatibility

* chore(docs): update Kubernetes cluster version requirement to >= 1.31

Author: saidsef

.github/workflows/charts.yml

@@ -111,8 +111,8 @@ jobs:
       - name: Create k8s Kind Cluster
         uses: helm/kind-action@v1.13.0
         with:
-          kubectl_version: v1.30.4 # Ensure compatibility with the latest APIs
-          node_image: kindest/node:v1.30.4 # Match node version with kubectl for consistency
+          kubectl_version: v1.33.7 # Ensure compatibility with the latest APIs
+          node_image: kindest/node:v1.33.7 # Match node version with kubectl for consistency
       - name: Checkout
         uses: actions/checkout@v6
       - name: Run K8s test

README.md

@@ -12,9 +12,9 @@ This helm chart implements Pull Request generator of ApplicationSet, it uses API
 
 Services that should already be installed and/or running.
 
-- Kubernetes Cluster >= 1.28
-- [ArgoCD ApplicationSet Controller](https://argo-cd.readthedocs.io/en/stable/user-guide/application-set/) >= v2.5.8
-- [HELM](https://helm.sh/docs/intro/install/) >= v3.9
+- Kubernetes Cluster >= 1.31
+- [ArgoCD ApplicationSet Controller](https://argo-cd.readthedocs.io/en/stable/user-guide/application-set/) >= v2.13
+- [HELM](https://helm.sh/docs/intro/install/) >= v3.10
 
 ## Deployment
 

charts/applicationset/Chart.yaml

@@ -2,9 +2,9 @@ apiVersion: v2
 name: argocd-applicationsets-services
 description: A Helm chart for ArgoCD ApplicationSets, a declarative, GitOps continuous delivery tool for Kubernetes
 type: application
-version: &version "0.16.1"
+version: &version "0.17.1"
 appVersion: *version
-kubeVersion: ">= 1.28"
+kubeVersion: ">= 1.31"
 home: https://github.com/saidsef/argocd-applicationsets-services
 icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
 keywords:
@@ -24,7 +24,11 @@ annotations:
   artifacthub.io/license: "Apache-2.0"
   artifacthub.io/changes: |
     - kind: added
-      description: Added github appSecretName field to support GitHub App authentication.
+      description: A§dd destinationServiceAccounts to project values.
+    - kind: changed
+      description: Moved annotations related references to chart values global annotations.
+    - kind: changed
+      description: Updated readme to note minimum requirements for Kubernetes and ArgoCD versions.
   artifacthub.io/links: |
     - name: README
       url: https://raw.githubusercontent.com/saidsef/argocd-applicationsets-services/main/README.md

charts/applicationset/templates/github-pr.yml

@@ -58,10 +58,6 @@ spec:
         app.kubernetes.io/branch: {{ trunc 63 $branchSlug | trimSuffix "-" }}
         app.kubernetes.io/created-by: 'applicationset'
       annotations:
-        argocd-image-updater.argoproj.io/force-update: 'true'
-        argocd-image-updater.argoproj.io/update-strategy: 'latest'
-        argocd-image-updater.argoproj.io/write-back-method: 'argocd'
-        argocd.argoproj.io/application-set-refresh: 'true'
         argocd.argoproj.io/head: {{ $headShortSha }}
         link.argocd.argoproj.io/external-link: '{{ $pr }}/{{ $github.owner }}/{{or $repo.name $repo.path}}/pull/{{ $dqf }}number{{ $dqb }}'
         {{- with $globals.annotations }}

charts/applicationset/templates/gitlab-mr.yml

@@ -54,10 +54,6 @@ spec:
         app.kubernetes.io/branch: {{ trunc 63 $branchSlug | trimSuffix "-" }}
         app.kubernetes.io/created-by: 'applicationset'
       annotations:
-        argocd-image-updater.argoproj.io/force-update: 'true'
-        argocd-image-updater.argoproj.io/update-strategy: 'latest'
-        argocd-image-updater.argoproj.io/write-back-method: 'argocd'
-        argocd.argoproj.io/application-set-refresh: 'true'
         argocd.argoproj.io/head: {{ $headShortSha }}
         link.argocd.argoproj.io/external-link: '{{ $gitlab.api }}/{{ $gitlab.group }}/{{or $repo.name $repo.path}}/-/merge_requests/{{ $dqf }}number{{ $dqb }}'
         {{- with $globals.annotations }}

charts/applicationset/templates/projects.yml

@@ -16,6 +16,8 @@ spec:
     {{- toYaml .Values.project.clusterResourceBlacklist | nindent 4 }}
   clusterResourceWhitelist:
    {{- toYaml .Values.project.clusterResourceWhitelist | nindent 4 }}
+  destinationServiceAccounts:
+    {{- toYaml .Values.project.destinationServiceAccounts | nindent 4 }}
   destinations:
     {{- toYaml .Values.project.destinations | nindent 4 }}
   namespaceResourceBlacklist:

charts/applicationset/values.yaml

@@ -57,6 +57,8 @@ project:
   - namespace: 'previews'
     server: '*'
     name: '*'
+  # -- No destination service accounts by default
+  destinationServiceAccounts: []
   # -- Allow all namespaced-scoped resources to be created, except for AppProject
   namespaceResourceBlacklist:
   - group: 'argoproj.io'