Skip to content

Commit 7d59dda

Browse files
SajeerSajeer
authored andcommitted
toolchain-install-feature-it location changed so to fix the errors
1 parent eb85bf0 commit 7d59dda

File tree

7 files changed

+70
-126
lines changed

7 files changed

+70
-126
lines changed

liberty-maven-plugin/src/it/kernel-install-feature-test/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
<module>install-usr-feature-ext-it</module>
4646
<module>install-usr-feature-old-version</module>
4747
<module>install-features-override-server-dir-it</module>
48+
<module>toolchain-install-feature-it</module>
4849
</modules>
4950

5051
<!-- Profiles for WLP vs OL -->
Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
<modelVersion>4.0.0</modelVersion>
5+
6+
<parent>
7+
<groupId>io.openliberty.tools.it</groupId>
8+
<artifactId>kernel-install-feature-tests</artifactId>
9+
<version>1.0-SNAPSHOT</version>
10+
</parent>
11+
12+
<artifactId>toolchain-install-feature-it</artifactId>
13+
<packaging>jar</packaging>
14+
15+
<build>
16+
<plugins>
17+
<plugin>
18+
<groupId>io.openliberty.tools</groupId>
19+
<artifactId>liberty-maven-plugin</artifactId>
20+
<version>@pom.version@</version>
21+
<configuration>
22+
<jdkToolchain>
23+
<version>11</version>
24+
</jdkToolchain>
25+
<assemblyArtifact>
26+
<groupId>${runtimeGroupId}</groupId>
27+
<artifactId>${runtimeKernelId}</artifactId>
28+
<version>${runtimeVersion}</version>
29+
<type>zip</type>
30+
</assemblyArtifact>
31+
<serverName>toolchainTestServer</serverName>
32+
<serverXmlFile>src/test/resources/server.xml</serverXmlFile>
33+
</configuration>
34+
<executions>
35+
<execution>
36+
<id>install-liberty</id>
37+
<phase>compile</phase>
38+
<goals>
39+
<goal>install-server</goal>
40+
</goals>
41+
</execution>
42+
<execution>
43+
<id>create-liberty-server</id>
44+
<phase>pre-integration-test</phase>
45+
<goals>
46+
<goal>create</goal>
47+
</goals>
48+
</execution>
49+
<execution>
50+
<id>install-features</id>
51+
<phase>pre-integration-test</phase>
52+
<goals>
53+
<goal>install-feature</goal>
54+
</goals>
55+
<configuration>
56+
<features>
57+
<acceptLicense>true</acceptLicense>
58+
</features>
59+
</configuration>
60+
</execution>
61+
</executions>
62+
</plugin>
63+
</plugins>
64+
</build>
65+
</project>

liberty-maven-plugin/src/it/toolchain-install-feature-it/src/test/java/net/wasdev/wlp/maven/test/app/ToolchainInstallFeatureTest.java renamed to liberty-maven-plugin/src/it/kernel-install-feature-test/toolchain-install-feature-it/src/test/java/net/wasdev/wlp/maven/test/app/ToolchainInstallFeatureTest.java

File renamed without changes.

liberty-maven-plugin/src/it/toolchain-install-feature-it/src/test/resources/server.xml renamed to liberty-maven-plugin/src/it/kernel-install-feature-test/toolchain-install-feature-it/src/test/resources/server.xml

File renamed without changes.

liberty-maven-plugin/src/it/toolchain-install-feature-it/invoker.properties

Lines changed: 0 additions & 1 deletion
This file was deleted.

liberty-maven-plugin/src/it/toolchain-install-feature-it/pom.xml

Lines changed: 0 additions & 124 deletions
This file was deleted.

liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/ServerFeatureSupport.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ protected Map<String, String> getToolchainEnvVar() {
537537
}
538538
// 1. Read existing config files
539539
List<String> serverEnvLines = readConfigFileLines(getServerEnvFile());
540-
if (mergeServerEnv && serverEnvFile != null && serverEnvFile.exists() && configDirectory.exists()) {
540+
if (mergeServerEnv && serverEnvFile != null && serverEnvFile.exists() && configDirectory != null && configDirectory.exists()) {
541541
File configDirServerEnv = new File(configDirectory, "server.env");
542542
if (configDirServerEnv.exists()) {
543543
serverEnvLines.addAll(readConfigFileLines(configDirServerEnv));
@@ -571,6 +571,9 @@ private File getServerEnvFile() {
571571
if (serverEnvFile != null && serverEnvFile.exists()) {
572572
return serverEnvFile;
573573
}
574+
if (configDirectory == null) {
575+
return null;
576+
}
574577
File defaultServerEnv = new File(configDirectory, "server.env");
575578
if (defaultServerEnv.exists()) {
576579
return defaultServerEnv;

0 commit comments

Comments
 (0)