coderabbitai II

Author: st-manu

lessonbuilder/tool/src/java/org/sakaiproject/lessonbuildertool/service/LessonBuilderEntityProducer.java

@@ -856,6 +856,11 @@ public Map<Long, List<Long>> findReferencedPagesByItems(String siteId) {
 		}
 
 		for (SimplePage page : allPages) {
+			if ("0".equals(page.getToolId())) {
+				log.debug("Skipping orphaned page {} with toolId='0'", page.getPageId());
+				continue;
+			}
+			
 			List<SimplePageItem> items = simplePageToolDao.findItemsOnPage(page.getPageId());
 			if (items != null) {
 				for (SimplePageItem item : items) {

lessonbuilder/tool/src/test/org/sakaiproject/lessonbuildertool/service/LessonBuilderEntityProducerTest.java

@@ -229,9 +229,9 @@ public void testFindReferencedPagesByItemsSkipsOrphans() {
         // The method should skip orphaned parents
         Map<Long, List<Long>> result = producer.findReferencedPagesByItems(siteId);
 
-        // Result may be empty or not contain the orphan - depends on implementation
-        // The key point is it shouldn't cause errors
+        // Verify the orphan parent is not included in the result
         assertNotNull("Result should not be null", result);
+        assertFalse("Orphan parent page 200L should not be in result", result.containsKey(200L));
     }
 
     /**