fix: prevent nodepool update when one is running

Signed-off-by: Carlos Salas <[email protected]>

Author: salasberryfin

cloud/services/container/nodepools/reconcile.go

@@ -147,6 +147,13 @@ func (s *Service) Reconcile(ctx context.Context) (ctrl.Result, error) {
 	needUpdateConfig, nodePoolUpdateConfigRequest := s.checkDiffAndPrepareUpdateConfig(nodePool)
 	if needUpdateConfig {
 		log.Info("Node pool config update required", "request", nodePoolUpdateConfigRequest)
+		// TODO: this is where it fails
+		// do not trigger an update to node pools if there's one already in progress or the machine pool is being removed
+		fmt.Println("###### GKEMachinePoolDeletingCondition: ", conditions.IsTrue(s.scope.GCPManagedMachinePool, infrav1exp.GKEMachinePoolDeletingCondition))
+		if conditions.IsTrue(s.scope.GCPManagedMachinePool, infrav1exp.GKEMachinePoolUpdatingCondition) || conditions.IsTrue(s.scope.GCPManagedMachinePool, infrav1exp.GKEMachinePoolDeletingCondition) {
+			log.Info("Another node pool config update operation is already in progress, requeuing")
+			return ctrl.Result{RequeueAfter: reconciler.DefaultRetryTime}, nil
+		}
 		err = s.updateNodePoolConfig(ctx, nodePoolUpdateConfigRequest)
 		if err != nil {
 			return ctrl.Result{}, fmt.Errorf("node pool config update (either version/labels/taints/locations/image type/network tag/linux node config or all) failed: %s", err)

exp/controllers/gcpmanagedmachinepool_controller.go

@@ -333,6 +333,12 @@ func (r *GCPManagedMachinePoolReconciler) reconcile(ctx context.Context, managed
 		log.V(4).Info("Calling reconciler", "reconciler", name)
 		res, err := r.Reconcile(ctx)
 		if err != nil {
+			// Ensure the ready condition is false, but do not overwrite an existing
+			// error condition which might provide more details.
+			if conditions.IsTrue(managedMachinePoolScope.GCPManagedMachinePool, infrav1exp.GKEMachinePoolReadyCondition) {
+				conditions.MarkFalse(managedMachinePoolScope.GCPManagedMachinePool, infrav1exp.GKEMachinePoolReadyCondition, infrav1exp.GKEMachinePoolErrorReason, clusterv1.ConditionSeverityError, err.Error())
+			}
+
 			var e *apierror.APIError
 			if ok := errors.As(err, &e); ok {
 				if e.GRPCStatus().Code() == codes.FailedPrecondition {
@@ -341,6 +347,7 @@ func (r *GCPManagedMachinePoolReconciler) reconcile(ctx context.Context, managed
 				}
 			}
 			log.Error(err, "Reconcile error", "reconciler", name)
+
 			record.Warnf(managedMachinePoolScope.GCPManagedMachinePool, "GCPManagedMachinePoolReconcile", "Reconcile error - %v", err)
 			return ctrl.Result{}, err
 		}