Rename runChecked to runCatching

Signed-off-by: Gopal S Akshintala <[email protected]>

Author: overfullstack

src/main/kotlin/com/salesforce/revoman/input/config/StepPick.kt

@@ -37,10 +37,10 @@ sealed interface StepPick {
     companion object PickUtils {
       /**
        * If there are steps with the same name, you may pass the stepName along with the folderPath,
-       * where each folder is seperated by FOLDER_DELIMITER {@see com.salesforce.revoman.output.report.Folder.FOLDER_DELIMITER}
-       * You may not have to pass the entire path,
-       * you can pass the path from the Least common Ancestor
-       * to uniquely identify the step of your interest to add this Hook
+       * where each folder is seperated by FOLDER_DELIMITER {@see
+       * com.salesforce.revoman.output.report.Folder.FOLDER_DELIMITER} You may not have to pass the
+       * entire path, you can pass the path from the Least common Ancestor to uniquely identify the
+       * step of your interest to add this Hook
        */
       @JvmStatic
       fun beforeStepName(vararg stepNameSubstrings: String) = PreTxnStepPick { currentStep, _, _ ->
@@ -73,11 +73,11 @@ sealed interface StepPick {
 
     companion object PickUtils {
       /**
-       * If there are steps with the same name, you may pass the stepName along with the folderPath, 
-       * where each folder is seperated by FOLDER_DELIMITER {@see com.salesforce.revoman.output.report.Folder.FOLDER_DELIMITER}
-       * You may not have to pass the entire path,
-       * you can pass the path from the Least common Ancestor
-       * to uniquely identify the step of your interest to add this Hook 
+       * If there are steps with the same name, you may pass the stepName along with the folderPath,
+       * where each folder is seperated by FOLDER_DELIMITER {@see
+       * com.salesforce.revoman.output.report.Folder.FOLDER_DELIMITER} You may not have to pass the
+       * entire path, you can pass the path from the Least common Ancestor to uniquely identify the
+       * step of your interest to add this Hook
        */
       @JvmStatic
       fun afterStepName(vararg stepNameSubstrings: String) = PostTxnStepPick { stepReport, _ ->

src/main/kotlin/com/salesforce/revoman/internal/exe/ExeUtils.kt

@@ -75,7 +75,7 @@ internal fun shouldStepBePicked(
   return runStep
 }
 
-internal fun <T> runChecked(
+internal fun <T> runCatching(
   currentStep: Step,
   exeType: ExeType,
   fn: () -> T,

src/main/kotlin/com/salesforce/revoman/internal/exe/HttpRequest.kt

@@ -37,7 +37,7 @@ internal fun fireHttpRequest(
   httpRequest: Request,
   insecureHttp: Boolean,
 ): Either<HttpRequestFailure, TxnInfo<Response>> =
-  runChecked(currentStep, HTTP_REQUEST) {
+  runCatching(currentStep, HTTP_REQUEST) {
       // * NOTE gopala.akshintala 06/08/22: Preparing httpClient for each step,
       // * as there can be intermediate auths
       // ! TODO 29/01/24 gopala.akshintala: When would bearer token size be > 1?

src/main/kotlin/com/salesforce/revoman/internal/exe/PMJSEval.kt

@@ -26,7 +26,7 @@ internal fun executePreReqJS(
 ): Either<PreReqJSFailure, Unit> {
   val preReqJS = item.event?.find { it.listen == "prerequest" }?.script?.exec?.joinToString("\n")
   return if (!preReqJS.isNullOrBlank()) {
-    runChecked(currentStep, PRE_REQ_JS) { executePreReqJSWithPolyglot(preReqJS, item.request, pm) }
+    runCatching(currentStep, PRE_REQ_JS) { executePreReqJSWithPolyglot(preReqJS, item.request, pm) }
       .mapLeft { PreReqJSFailure(it, pm.currentStepReport.requestInfo!!.get()) }
   } else {
     Right(Unit)
@@ -45,7 +45,7 @@ internal fun executePostResJS(
 ): Either<PostResJSFailure, Unit> {
   val postResJs = item.event?.find { it.listen == "test" }?.script?.exec?.joinToString("\n")
   return if (!postResJs.isNullOrBlank()) {
-    runChecked(currentStep, POST_RES_JS) {
+    runCatching(currentStep, POST_RES_JS) {
         executePostResJSWithPolyglot(postResJs, item.request, pm.currentStepReport, pm)
       }
       .mapLeft {

src/main/kotlin/com/salesforce/revoman/internal/exe/PostStepHook.kt

@@ -21,7 +21,7 @@ import io.github.oshai.kotlinlogging.KotlinLogging
 internal fun postHookExe(kick: Kick, pm: PostmanSDK): PostStepHookFailure? =
   pickPostHooks(kick.postHooks(), pm.currentStepReport, pm.rundown)
     .map { postHook ->
-      runChecked(pm.currentStepReport.step, POST_STEP_HOOK) {
+      runCatching(pm.currentStepReport.step, POST_STEP_HOOK) {
           postHook.accept(pm.currentStepReport, pm.rundown)
         }
         .mapLeft { PostStepHookFailure(it) }

src/main/kotlin/com/salesforce/revoman/internal/exe/PreStepHook.kt

@@ -28,7 +28,7 @@ internal fun preHookExe(
 ): PreStepHookFailure? =
   pickPreHooks(kick.preHooks(), currentStep, requestInfo, pm.rundown)
     .map { preHook ->
-      runChecked(currentStep, PRE_STEP_HOOK) {
+      runCatching(currentStep, PRE_STEP_HOOK) {
           preHook.accept(currentStep, requestInfo, pm.rundown)
         }
         .mapLeft { PreStepHookFailure(it, requestInfo) }

src/main/kotlin/com/salesforce/revoman/internal/exe/UnmarshallRequest.kt

@@ -41,7 +41,7 @@ internal fun unmarshallRequest(
       ?.objType ?: Any::class.java
   return when {
     isJson(httpRequest) ->
-      runChecked(currentStep, UNMARSHALL_REQUEST) {
+      runCatching(currentStep, UNMARSHALL_REQUEST) {
           pmRequest.body?.let { body -> moshiReVoman.asA(body.raw, requestType.rawType.kotlin) }
         }
         .mapLeft { UnmarshallRequestFailure(it, TxnInfo(requestType, null, httpRequest)) }

src/main/kotlin/com/salesforce/revoman/internal/exe/UnmarshallResponse.kt

@@ -43,7 +43,7 @@ internal fun unmarshallResponse(
           ?.also { logger.info { "$currentStep ResponseConfig found : ${pprint(it)}" } }
           ?.objType ?: Any::class.java
       val requestInfo = pm.currentStepReport.requestInfo!!.get()
-      runChecked(currentStep, UNMARSHALL_RESPONSE) {
+      runCatching(currentStep, UNMARSHALL_RESPONSE) {
           moshiReVoman.asA(httpResponse.bodyString(), responseType.rawType.kotlin)
         }
         .mapLeft {

src/main/kotlin/com/salesforce/revoman/output/report/Step.kt

@@ -70,8 +70,9 @@ constructor(
 
   override fun toString(): String =
     when {
-        isRoot -> name
-        else -> parentPath.joinToString(separator = FOLDER_DELIMITER, postfix = FOLDER_DELIMITER) {
+      isRoot -> name
+      else ->
+        parentPath.joinToString(separator = FOLDER_DELIMITER, postfix = FOLDER_DELIMITER) {
           it.name
         } + name
     }