Skip to content

Commit 58210d3

Browse files
committed
Minor CONTRIBUTING.adoc update
Signed-off-by: Gopal S Akshintala <gopala.akshintala@salesforce.com>
1 parent eb3ed1d commit 58210d3

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

CONTRIBUTING.adoc

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,16 @@ endif::[]
3535
3636
=== Install Java 11
3737
38-
* It needs JDK 11 installed in your system. I recommend doing it via https://sdkman.io/install[SDKMAN]. After you install SDKMAN, run `sdk list java` -> Pick Identifier for your favorite java dist -> Run `sdk install java <Identifier-you-picked> to install Java.
38+
It needs JDK 11 installed in your system.
39+
Recommendation is to do it via https://sdkman.io/install[SDKMAN].
40+
After you install SDKMAN,
41+
run `sdk list java` -> Pick Identifier for your favorite java distribution -> Run `sdk install java <Identifier-you-picked>`
42+
to install Java. For example:
43+
44+
[source,bash]
45+
----
46+
sdk install java 11.0.22-tem
47+
----
3948
4049
=== Build with Gradle
4150

vador/src/test/java/com/salesforce/vador/execution/VadorAnnotationTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,18 @@
2525
import org.junit.jupiter.api.Test;
2626
import sample.consumer.failure.ValidationFailure;
2727

28-
public class VadorAnnotationTest {
28+
class VadorAnnotationTest {
2929

3030
private static final Bean VALIDATABLE = new Bean(1, -90, 0);
3131

32-
private static final BeanMix VALIDATABLEMIX = new BeanMix(6, "abed");
32+
private static final BeanMix VALIDATABLE_MIX = new BeanMix(6, "abed");
3333

34-
private static final BeanCustom VALIDATBLECUSTOM = new BeanCustom(new ID("Test Class"));
34+
private static final BeanCustom VALIDATABLE_CUSTOM = new BeanCustom(new ID("Test Class"));
3535

36-
private static final BeanCustom2 VALIDATBLECUSTOM2 =
36+
private static final BeanCustom2 VALIDATABLE_CUSTOM2 =
3737
new BeanCustom2(new ID("Test Class1"), new ID("Test Class2"));
3838

39-
private static final BeanCustom3 VALIDATBLECUSTOM3 = new BeanCustom3(new ID("Test Class1"));
39+
private static final BeanCustom3 VALIDATABLE_CUSTOM3 = new BeanCustom3(new ID("Test Class1"));
4040

4141
@Test
4242
void failFastWithFirstFailureWithValidatorAnnotation() {
@@ -67,7 +67,7 @@ void failFastWithFirstFailureWithValidatorAnnotationRunTimeError() {
6767
assertThrows(
6868
ClassCastException.class,
6969
() -> {
70-
Vador.validateAndFailFast(VALIDATABLEMIX, validationConfig);
70+
Vador.validateAndFailFast(VALIDATABLE_MIX, validationConfig);
7171
});
7272
}
7373

@@ -77,7 +77,7 @@ void failFastWithFirstFailureWithValidatorCustomAnnotation() {
7777
ValidationConfig.<VadorAnnotationTest.BeanCustom, ValidationFailure>toValidate()
7878
.forAnnotations(Tuple.of(Map.of("unexpectedException", UNKNOWN_EXCEPTION), NONE))
7979
.prepare();
80-
final var result = Vador.validateAndFailFast(VALIDATBLECUSTOM, validationConfig);
80+
final var result = Vador.validateAndFailFast(VALIDATABLE_CUSTOM, validationConfig);
8181
assertThat(result).isEmpty();
8282
}
8383

@@ -87,7 +87,7 @@ void failFastWithFirstFailureWithValidatorCustomAnnotationWithError() {
8787
ValidationConfig.<VadorAnnotationTest.BeanCustom2, ValidationFailure>toValidate()
8888
.forAnnotations(Tuple.of(Map.of("unexpectedException", UNKNOWN_EXCEPTION), NONE))
8989
.prepare();
90-
final var result = Vador.validateAndFailFast(VALIDATBLECUSTOM2, validationConfig);
90+
final var result = Vador.validateAndFailFast(VALIDATABLE_CUSTOM2, validationConfig);
9191
assertThat(result).contains(UNKNOWN_EXCEPTION);
9292
}
9393

@@ -100,7 +100,7 @@ void failFastWithFirstFailureWithValidatorCustomAnnotationWithDifferentInterface
100100
assertThrows(
101101
IllegalArgumentException.class,
102102
() -> {
103-
Vador.validateAndFailFast(VALIDATBLECUSTOM3, validationConfig);
103+
Vador.validateAndFailFast(VALIDATABLE_CUSTOM3, validationConfig);
104104
});
105105
}
106106

0 commit comments

Comments
 (0)