Skip to content

Commit 0282ce9

Browse files
laurensuhandrewvasilchukLauren SuhDottenpixel
authored
docs(modals): focusable header (#5071)
* docs(modals): focusable header * fix(modals): footless example tabindex added for focusable header * fixed release notes Co-authored-by: andrewvasilchuk <[email protected]> Co-authored-by: Lauren Suh <[email protected]> Co-authored-by: Doug Molidor <[email protected]>
1 parent fd59edb commit 0282ce9

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

RELEASENOTES.general.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<!-- On release, add general notes here. In time the legacy release notes will be add to this -->
33

44
## 2.19.0 - Upcoming
5+
56
- Updated icons to `v10.4.0`
67
- Standard Set:
78
- Added `ai_accelerator_card`

RELEASENOTES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<!-- !!! THIS FILE IS AUTO-GENERATED !!! DO NOT EDIT THIS FILE MANUALLY !!! -->
33

44
## Release 2.19.0 - Upcoming
5+
56
- Updated icons to `v10.4.0`
67
- Standard Set:
78
- Added `ai_accelerator_card`
@@ -64,6 +65,10 @@
6465
#### Added
6566
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`
6667

68+
### [Modals](https://www.lightningdesignsystem.com/components/modals)
69+
#### Changed
70+
- Added tabindex to Footless example for programmatic focus use case.
71+
6772
### [Tabs](https://www.lightningdesignsystem.com/components/tabs)
6873
#### Added
6974
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`

ui/components/modals/RELEASENOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.19.0
8+
### Changed
9+
- Added tabindex to Footless example for programmatic focus use case.
10+
711
## 2.18.0
812
### Changed
913

ui/components/modals/base/example.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ export let Footless = (props) => (
268268
<Backdrop>
269269
<Modal aria-labelledby="modal-heading-01">
270270
<ModalHeader>
271-
<h1 id="modal-heading-01" className="slds-modal__title slds-hyphenate">
271+
<h1 id="modal-heading-01" className="slds-modal__title slds-hyphenate" tabindex="-1">
272272
Modal header
273273
</h1>
274274
</ModalHeader>

0 commit comments

Comments
 (0)