Skip to content

Commit 1dac67b

Browse files
DottenpixelDottenpixel
authored
fix(tests): Update tests in experience components with combobox (#4692)
* update timepicker combobox tests * update datetime picker combobox tests * update dynamic-menu combobox tests * update datepicker combobox tests * update brand-band combobox tests * update input tests * update datepicker tests * update expression tests
1 parent 7da34b0 commit 1dac67b

File tree

8 files changed

+183
-168
lines changed

8 files changed

+183
-168
lines changed

‎RELEASENOTES.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#### Added
1717
- Added examples for Required, Required with Error states
1818
- Added `aria-label` to provide the full `DD MM YYYY` text of the date
19-
2019
#### Fixed
2120
- Fixed missing attribute `aria-current="date"` when today's date falls inside of a selected range
2221

‎ui/components/brand-band/__tests__/__snapshots__/snapshot.spec.js.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ exports[`render brand band renders brand band with no image 1`] = `
44
<div
55
style={
66
Object {
7-
"backgroundColor": "rgb(176, 196, 223)",
7+
"backgroundColor": "#eef4ff",
88
"minHeight": "20rem",
99
"position": "relative",
1010
"zIndex": "1",
@@ -21,7 +21,7 @@ exports[`render brand band renders large brand band 1`] = `
2121
<div
2222
style={
2323
Object {
24-
"backgroundColor": "rgb(176, 196, 223)",
24+
"backgroundColor": "#eef4ff",
2525
"minHeight": "20rem",
2626
"position": "relative",
2727
"zIndex": "1",
@@ -38,7 +38,7 @@ exports[`render brand band renders medium brand band 1`] = `
3838
<div
3939
style={
4040
Object {
41-
"backgroundColor": "rgb(176, 196, 223)",
41+
"backgroundColor": "#eef4ff",
4242
"minHeight": "20rem",
4343
"position": "relative",
4444
"zIndex": "1",
@@ -55,7 +55,7 @@ exports[`render brand band renders small brand band 1`] = `
5555
<div
5656
style={
5757
Object {
58-
"backgroundColor": "rgb(176, 196, 223)",
58+
"backgroundColor": "#eef4ff",
5959
"minHeight": "20rem",
6060
"position": "relative",
6161
"zIndex": "1",

‎ui/components/datepickers/__tests__/__snapshots__/index.spec.js.snap

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -548,6 +548,7 @@ exports[`Date Picker renders a Date Picker in a Data Table 1`] = `
548548
</span>
549549
</td>
550550
<td
551+
aria-current={null}
551552
aria-label="25 June 2020"
552553
aria-selected="false"
553554
className=""
@@ -1218,6 +1219,7 @@ exports[`Date Picker renders a Date Picker with Date selected 1`] = `
12181219
</span>
12191220
</td>
12201221
<td
1222+
aria-current={null}
12211223
aria-label="25 June 2020"
12221224
aria-selected="false"
12231225
className=""
@@ -1904,6 +1906,7 @@ exports[`Date Picker renders a Date Picker with Range - Current and adjacent mon
19041906
</span>
19051907
</td>
19061908
<td
1909+
aria-current={null}
19071910
aria-label="25 June 2020"
19081911
aria-selected="false"
19091912
className=""
@@ -2567,6 +2570,7 @@ exports[`Date Picker renders a Date Picker with Range - Current and adjacent mon
25672570
</span>
25682571
</td>
25692572
<td
2573+
aria-current={null}
25702574
aria-label="25 June 2020"
25712575
aria-selected="false"
25722576
className=""
@@ -3276,6 +3280,7 @@ exports[`Date Picker renders a Date Picker with Range - Current and adjacent mon
32763280
</span>
32773281
</td>
32783282
<td
3283+
aria-current={null}
32793284
aria-label="25 June 2020"
32803285
aria-selected="false"
32813286
className=""
@@ -3939,6 +3944,7 @@ exports[`Date Picker renders a Date Picker with Range - Current and adjacent mon
39393944
</span>
39403945
</td>
39413946
<td
3947+
aria-current={null}
39423948
aria-label="25 June 2020"
39433949
aria-selected="false"
39443950
className=""
@@ -4651,6 +4657,7 @@ exports[`Date Picker renders a Date Picker with Range - Default in a Data Table
46514657
</span>
46524658
</td>
46534659
<td
4660+
aria-current={null}
46544661
aria-label="25 June 2020"
46554662
aria-selected="false"
46564663
className=""
@@ -5313,6 +5320,7 @@ exports[`Date Picker renders a Date Picker with Range - Default in a Data Table
53135320
</span>
53145321
</td>
53155322
<td
5323+
aria-current={null}
53165324
aria-label="25 June 2020"
53175325
aria-selected="false"
53185326
className=""
@@ -6008,6 +6016,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Diffe
60086016
</span>
60096017
</td>
60106018
<td
6019+
aria-current={null}
60116020
aria-label="25 June 2020"
60126021
aria-selected="false"
60136022
className=""
@@ -6671,6 +6680,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Diffe
66716680
</span>
66726681
</td>
66736682
<td
6683+
aria-current={null}
66746684
aria-label="25 June 2020"
66756685
aria-selected="true"
66766686
className="slds-is-selected slds-is-selected-multi"
@@ -7380,6 +7390,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Diffe
73807390
</span>
73817391
</td>
73827392
<td
7393+
aria-current={null}
73837394
aria-label="25 June 2020"
73847395
aria-selected="false"
73857396
className=""
@@ -8043,6 +8054,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Diffe
80438054
</span>
80448055
</td>
80458056
<td
8057+
aria-current={null}
80468058
aria-label="25 June 2020"
80478059
aria-selected="true"
80488060
className="slds-is-selected slds-is-selected-multi"
@@ -8738,6 +8750,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Same
87388750
</span>
87398751
</td>
87408752
<td
8753+
aria-current={null}
87418754
aria-label="25 June 2020"
87428755
aria-selected="false"
87438756
className=""
@@ -9401,6 +9414,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Same
94019414
</span>
94029415
</td>
94039416
<td
9417+
aria-current={null}
94049418
aria-label="25 June 2020"
94059419
aria-selected="true"
94069420
className="slds-is-selected slds-is-selected-multi"
@@ -10110,6 +10124,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Same
1011010124
</span>
1011110125
</td>
1011210126
<td
10127+
aria-current={null}
1011310128
aria-label="25 June 2020"
1011410129
aria-selected="false"
1011510130
className=""
@@ -10773,6 +10788,7 @@ exports[`Date Picker renders a Date Picker with Range - End date selected (Same
1077310788
</span>
1077410789
</td>
1077510790
<td
10791+
aria-current={null}
1077610792
aria-label="25 June 2020"
1077710793
aria-selected="true"
1077810794
className="slds-is-selected slds-is-selected-multi"
@@ -11468,6 +11484,7 @@ exports[`Date Picker renders a Date Picker with Range - Start date selected 1`]
1146811484
</span>
1146911485
</td>
1147011486
<td
11487+
aria-current={null}
1147111488
aria-label="25 June 2020"
1147211489
aria-selected="false"
1147311490
className=""
@@ -12130,6 +12147,7 @@ exports[`Date Picker renders a Date Picker with Range - Start date selected 1`]
1213012147
</span>
1213112148
</td>
1213212149
<td
12150+
aria-current={null}
1213312151
aria-label="25 June 2020"
1213412152
aria-selected="false"
1213512153
className=""
@@ -12839,6 +12857,7 @@ exports[`Date Picker renders a Date Picker with Range - Start date selected in a
1283912857
</span>
1284012858
</td>
1284112859
<td
12860+
aria-current={null}
1284212861
aria-label="25 June 2020"
1284312862
aria-selected="false"
1284412863
className=""
@@ -13501,6 +13520,7 @@ exports[`Date Picker renders a Date Picker with Range - Start date selected in a
1350113520
</span>
1350213521
</td>
1350313522
<td
13523+
aria-current={null}
1350413524
aria-label="25 June 2020"
1350513525
aria-selected="false"
1350613526
className=""
@@ -14196,6 +14216,7 @@ exports[`Date Picker renders a Date Picker with Range - Today - In selected rang
1419614216
</span>
1419714217
</td>
1419814218
<td
14219+
aria-current={null}
1419914220
aria-label="25 June 2020"
1420014221
aria-selected="false"
1420114222
className=""
@@ -14859,6 +14880,7 @@ exports[`Date Picker renders a Date Picker with Range - Today - In selected rang
1485914880
</span>
1486014881
</td>
1486114882
<td
14883+
aria-current="date"
1486214884
aria-label="25 June 2020"
1486314885
aria-selected="true"
1486414886
className="slds-is-selected slds-is-selected-multi slds-is-today"
@@ -15568,6 +15590,7 @@ exports[`Date Picker renders a Date Picker with Range - Today - In selected rang
1556815590
</span>
1556915591
</td>
1557015592
<td
15593+
aria-current={null}
1557115594
aria-label="25 June 2020"
1557215595
aria-selected="false"
1557315596
className=""
@@ -16231,6 +16254,7 @@ exports[`Date Picker renders a Date Picker with Range - Today - In selected rang
1623116254
</span>
1623216255
</td>
1623316256
<td
16257+
aria-current="date"
1623416258
aria-label="25 June 2020"
1623516259
aria-selected="true"
1623616260
className="slds-is-selected slds-is-selected-multi slds-is-today"
@@ -16905,6 +16929,7 @@ exports[`Date Picker renders a Date Picker with error 1`] = `
1690516929
</span>
1690616930
</td>
1690716931
<td
16932+
aria-current={null}
1690816933
aria-label="25 June 2020"
1690916934
aria-selected="false"
1691016935
className=""
@@ -17599,6 +17624,7 @@ exports[`Date Picker renders a Date Picker with required 1`] = `
1759917624
</span>
1760017625
</td>
1760117626
<td
17627+
aria-current={null}
1760217628
aria-label="25 June 2020"
1760317629
aria-selected="false"
1760417630
className=""
@@ -18271,6 +18297,7 @@ exports[`Date Picker renders a Date Picker with required and error 1`] = `
1827118297
</span>
1827218298
</td>
1827318299
<td
18300+
aria-current={null}
1827418301
aria-label="25 June 2020"
1827518302
aria-selected="false"
1827618303
className=""
@@ -18954,6 +18981,7 @@ exports[`Date Picker renders a Date picker with an error in a Data Table 1`] = `
1895418981
</span>
1895518982
</td>
1895618983
<td
18984+
aria-current={null}
1895718985
aria-label="25 June 2020"
1895818986
aria-selected="false"
1895918987
className=""
@@ -19642,6 +19670,7 @@ exports[`Date Picker renders a Date picker with date selected in a Data Table 1`
1964219670
</span>
1964319671
</td>
1964419672
<td
19673+
aria-current={null}
1964519674
aria-label="25 June 2020"
1964619675
aria-selected="false"
1964719676
className=""
@@ -20311,6 +20340,7 @@ exports[`Date Picker renders a default datetime picker 1`] = `
2031120340
</span>
2031220341
</td>
2031320342
<td
20343+
aria-current={null}
2031420344
aria-label="25 June 2020"
2031520345
aria-selected="false"
2031620346
className=""

‎ui/components/datetime-picker/__tests__/__snapshots__/index.spec.js.snap

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -550,6 +550,7 @@ exports[`Datetime Picker renders a default datetime picker 1`] = `
550550
</span>
551551
</td>
552552
<td
553+
aria-current={null}
553554
aria-label="25 June 2020"
554555
aria-selected="false"
555556
className=""
@@ -1471,6 +1472,7 @@ exports[`Datetime Picker renders with a date selection 1`] = `
14711472
</span>
14721473
</td>
14731474
<td
1475+
aria-current={null}
14741476
aria-label="25 June 2020"
14751477
aria-selected="false"
14761478
className=""
@@ -2400,6 +2402,7 @@ exports[`Datetime Picker renders with a required plus error state 1`] = `
24002402
</span>
24012403
</td>
24022404
<td
2405+
aria-current={null}
24032406
aria-label="25 June 2020"
24042407
aria-selected="false"
24052408
className=""
@@ -3333,8 +3336,8 @@ exports[`Datetime Picker renders with a required state 1`] = `
33333336
</span>
33343337
</td>
33353338
<td
3336-
aria-label="25 June 2020"
33373339
aria-current={null}
3340+
aria-label="25 June 2020"
33383341
aria-selected="false"
33393342
className=""
33403343
role="gridcell"
@@ -4254,8 +4257,8 @@ exports[`Datetime Picker renders with a small width container 1`] = `
42544257
</span>
42554258
</td>
42564259
<td
4257-
aria-label="25 June 2020"
42584260
aria-current={null}
4261+
aria-label="25 June 2020"
42594262
aria-selected="false"
42604263
className=""
42614264
role="gridcell"
@@ -5176,8 +5179,8 @@ exports[`Datetime Picker renders with a time selection 1`] = `
51765179
</span>
51775180
</td>
51785181
<td
5179-
aria-label="25 June 2020"
51805182
aria-current={null}
5183+
aria-label="25 June 2020"
51815184
aria-selected="false"
51825185
className=""
51835186
role="gridcell"
@@ -6113,8 +6116,8 @@ exports[`Datetime Picker renders with an error state 1`] = `
61136116
</span>
61146117
</td>
61156118
<td
6116-
aria-label="25 June 2020"
61176119
aria-current={null}
6120+
aria-label="25 June 2020"
61186121
aria-selected="false"
61196122
className=""
61206123
role="gridcell"

‎ui/components/dynamic-menu/__tests__/__snapshots__/index.spec.js.snap

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -835,10 +835,7 @@ exports[`Dynamic Menu renders a dynamic menu with more than 10 items 1`] = `
835835
className="slds-combobox_container"
836836
>
837837
<div
838-
aria-expanded="true"
839-
aria-haspopup="listbox"
840838
className="slds-combobox slds-is-open"
841-
role="combobox"
842839
>
843840
<div
844841
className="slds-combobox__form-element slds-input-has-icon slds-input-has-icon_right slds-m-around_small"
@@ -847,13 +844,15 @@ exports[`Dynamic Menu renders a dynamic menu with more than 10 items 1`] = `
847844
<input
848845
aria-autocomplete="list"
849846
aria-controls="example-unique-id-4"
847+
aria-expanded="true"
848+
aria-haspopup="listbox"
850849
autocomplete="off"
851850
className="slds-input slds-combobox__input"
852851
id="example-unique-id-3"
853852
onBlur={[Function]}
854853
onFocus={[Function]}
855854
placeholder="Search Favorites"
856-
role="textbox"
855+
role="combobox"
857856
type="text"
858857
/>
859858
<span

0 commit comments

Comments
 (0)