Skip to content

Commit 26f4b08

Browse files
authored
Merge branch '234-winter-22' into merge-summer-21-winter-22
2 parents d32d932 + dd1713d commit 26f4b08

File tree

20 files changed

+410
-196
lines changed

20 files changed

+410
-196
lines changed

.circleci/config.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,20 @@ commands:
6464
if [[ "${CIRCLE_BRANCH}" = "${CURRENT_DEFAULT_BRANCH}" ]] ; then
6565
echo "Publishing to UPCOMING..."
6666
echo 'export HEROKU_APP_NAME=${HEROKU_APP_UPCOMING}' >> $BASH_ENV
67+
echo 'export HEROKU_RELEASE_STORYBOOK_APP_NAME=storybook-upcoming' >> $BASH_ENV
6768
elif [[ ${CIRCLE_TAG} =~ ^v[0-9]+\.[0-9]+\.[0-9]+-.+$ ]] ; then
6869
echo "Publishing to CORE-MAIN..."
6970
echo 'export HEROKU_APP_NAME=${HEROKU_APP_CORE_MAIN}' >> $BASH_ENV
71+
echo 'export HEROKU_RELEASE_STORYBOOK_APP_NAME=storybook-core-main' >> $BASH_ENV
7072
elif [[ ${CIRCLE_TAG} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]] ; then
7173
echo "Publishing to CORE-PATCH..."
7274
echo 'export HEROKU_APP_NAME=${HEROKU_APP_CORE_PATCH}' >> $BASH_ENV
75+
echo 'export HEROKU_RELEASE_STORYBOOK_APP_NAME=storybook-core-patch' >> $BASH_ENV
7376
else
7477
echo "Publishing to pull-request review app..."
7578
echo 'export HEROKU_APP_NAME=slds-review-site-pr-${PR_NUMBER}' >> $BASH_ENV
7679
echo 'export HEROKU_RELEASE_STORYBOOK_APP_NAME=true' >> $BASH_ENV
7780
fi
78-
echo 'export HEROKU_RELEASE_STORYBOOK_APP_NAME=${HEROKU_APP_NAME}' >> $BASH_ENV
7981
source $BASH_ENV
8082
echo $HEROKU_APP_NAME > workspace/heroku-app-name.txt
8183
echo $HEROKU_RELEASE_STORYBOOK_APP_NAME > workspace/heroku-release-storybook-app-name.txt
@@ -200,7 +202,12 @@ jobs:
200202
- run:
201203
name: Get Github pull-request number
202204
command: |
203-
gh api /repos/salesforce-ux/design-system-internal/commits/${CIRCLE_SHA1}/pulls -H "Accept: application/vnd.github.groot-preview+json" | jq -r '.[].number' > workspace/gh-pr-num.txt && cat workspace/gh-pr-num.txt
205+
set +e
206+
gh pr view --json number,state,title,url > gh-pull-data.json
207+
echo "=== Github pull-request API results ==="
208+
cat gh-pull-data.json
209+
echo "---------------------------------------"
210+
cat gh-pull-data.json | jq -r '.number' > workspace/gh-pr-num.txt && cat workspace/gh-pr-num.txt
204211
205212
- persist_to_workspace:
206213
root: workspace

shared/components/StylingHooksTable.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ const formatType = type => {
3636
class StylingHooksTable extends Component {
3737
render() {
3838
const { name, type } = this.props;
39-
39+
4040
let vars;
4141
try {
4242
vars = require(`../../.generated/metadata/${type}s/${name}/styling-hooks.json`);
@@ -101,13 +101,13 @@ class StylingHooksTable extends Component {
101101
})}
102102
>
103103
{ii === 0 ? (
104-
<td
104+
<th
105105
className="hooks-table__col-category"
106106
scope="rowgroup"
107107
rowSpan={categoryVars.length}
108108
>
109109
{category}
110-
</td>
110+
</th>
111111
) : null}
112112
<td>
113113
<div className="slds-grid">

shared/styles/doc.scss

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ $frame-spacing: 0.5rem;
9797
display: flex;
9898
justify-content: flex-end;
9999
background: $light-gray-border-color;
100-
margin: -1rem -1rem 1rem -1rem;
100+
margin: -1rem -1rem 1rem;
101101
padding: 0.25rem 0.5rem;
102102
}
103103

@@ -145,7 +145,6 @@ $frame-spacing: 0.5rem;
145145
flex: 1 1 auto;
146146
padding-left: 5%;
147147
}
148-
149148
}
150149
}
151150

@@ -233,7 +232,7 @@ blockquote.doc {
233232
font-size: 1.125rem;
234233
font-weight: 300;
235234
padding: 1rem;
236-
margin: 0 0 1.5rem 0;
235+
margin: 0 0 1.5rem;
237236
border: 1px solid $light-gray-border-color;
238237
border-left-width: 0.125rem;
239238

@@ -300,6 +299,10 @@ ol.doc {
300299

301300
ul.doc {
302301
list-style: disc;
302+
303+
ul.doc {
304+
list-style: circle;
305+
}
303306
}
304307

305308
ol.doc {
@@ -349,12 +352,18 @@ ul.doc-toc {
349352
}
350353

351354
.doc-toc li.doc a {
352-
font-size: .875rem;
355+
font-size: 0.875rem;
353356
font-weight: 700;
354357
}
355358

356-
li.doc > ul.doc, li.doc > li.doc, ul.doc > ul.doc, ul.doc > li.doc {
357-
margin-left: .4rem;
359+
li.doc > li.doc,
360+
ul.doc > li.doc {
361+
margin-left: 0.4rem;
362+
}
363+
364+
li.doc > ul.doc,
365+
ul.doc > ul.doc {
366+
margin-left: 1rem;
358367
}
359368

360369
li.doc > ul.doc {
@@ -366,17 +375,17 @@ li.doc > ul.doc {
366375
}
367376

368377
.doc-toc > li.doc > ul.doc ul.doc > li.doc a {
369-
font-size: .75rem;
378+
font-size: 0.75rem;
370379
font-weight: 400;
371380
color: #4872ab;
372381
}
373382

374383
h2.doc-toc-header {
375384
font-size: 1rem;
376385
border-bottom: 1px solid #d9dbdd;
377-
margin-bottom: .5rem;
386+
margin-bottom: 0.5rem;
378387
text-transform: uppercase;
379-
letter-spacing: .1rem;
388+
letter-spacing: 0.1rem;
380389
}
381390

382391
.doc-tokens-group .slds-button {
@@ -421,7 +430,7 @@ h2.doc-toc-header {
421430
height: 8rem;
422431
}
423432

424-
.doc-padding::before{
433+
.doc-padding:before {
425434
content: '';
426435
display: block;
427436
background: #1589ee;

0 commit comments

Comments
 (0)