Skip to content

Commit 382c63a

Browse files
committed
fix(modal): update breakpoint to mq-small
1 parent 0b12587 commit 382c63a

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

ui/components/modals/RELEASENOTES.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,33 @@
55
<!-- ## [Unreleased] -->
66

77
## 2.22.0
8+
89
### Changed
10+
911
- Optimized full size option and refactored to use CSS grid.
12+
- Updated full size variant to trigger at the `$mq-small` breakpoint to prevent larger devices from receiving the variant.
1013

1114
## 2.21.0
12-
### Fixed
15+
16+
### Fixed
17+
1318
- Fixed `aria-labelledby` to meet accessibility requirements specifically for screen readers.
1419

1520
## 2.21.0
21+
1622
### Changed
17-
- Added full size option for modal. This will allow the modal to reach full screen for mobile screen size and devices. When screen is bigger than mobile screen width (from 768px), full size modal will take on large size modal behaviour.
23+
24+
- Added full size option for modal. This will allow the modal to reach full screen for mobile screen size and devices. When screen is bigger than mobile screen width (from 768px), full size modal will take on large size modal behaviour.
1825
- Changed close button to meet accessibility requirement when in full size and in mobile width.
1926

2027
## 2.19.0
28+
2129
### Changed
30+
2231
- Added tabindex to Footless example for programmatic focus use case.
2332

2433
## 2.18.0
34+
2535
### Changed
2636

2737
- Added `slds-modal__content_footless` class to example for clarity.

ui/components/modals/base/_index.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,9 +301,9 @@
301301
min-width: 40rem;
302302
}
303303

304-
// We use mq-medium-max since modal was originally designed as desktop first;
304+
// We use mq-small-max since modal was originally designed as desktop first;
305305
// This saves us from having to duplicate code for the full modifier.
306-
@include mq-medium-max {
306+
@include mq-small-max {
307307
// Account for iOS safe areas so our modal doesn't load underneath iOS elements.
308308
top: env(safe-area-inset-top, 0);
309309
// Override slds-modal's bottom: 0 so we can make the height dynamic.

0 commit comments

Comments
 (0)