Skip to content

Commit 3f74604

Browse files
puneetk92Puneet Kulkarni
andauthored
fix(slds): fix text color issue for yellow background in edited cell varient of datatable (#5192)
Co-authored-by: Puneet Kulkarni <[email protected]>
1 parent e8c1142 commit 3f74604

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

ui/components/data-tables/RELEASENOTES.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@
66

77
## 2.22.0
88

9+
### Added
10+
11+
- Added `font-weight` property in `.slds-is-edited` & `.slds-has-error` to provide secondary indicator for the text
12+
- Updated `Accessibility` section in `docs.mdx` documentation file for bold text
13+
14+
## 2.22.0
15+
916
### Changed
1017

1118
- Removed `aria-label` from table header to prevent from reading twice headers.

ui/components/data-tables/docs.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,8 @@ The Advanced Data Table and Inline Edit Data Table are based on the semantics, r
162162

163163
The role of Grid comes with 2 distinct modes, Navigation mode and Actionable mode. Both come with very specific keyboard interaction modals. Navigation mode is the default mode of the Grid.
164164

165+
Bold text for edited cell examples provide secondary indicators for text, along with yellow backgrounds, to indicate content is edited but unsaved.
166+
165167
**Navigation Mode**
166168

167169
- Tabbing into the grid focuses the first data cell in the table.

ui/components/data-tables/inline-edit/_index.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@
192192

193193
&,
194194
&:hover {
195+
font-weight: 700;
195196
background-color: var(--slds-g-color-palette-yellow-90, #{$color-background-highlight});
196197
}
197198
}
@@ -207,6 +208,7 @@
207208

208209
&,
209210
&:hover {
211+
font-weight: 700;
210212
background-color: var(--slds-g-color-palette-yellow-90, #{$color-background-highlight});
211213
box-shadow: var(--slds-g-color-error-base-40, #{$color-border-error}) 0 0 0 ($border-width-thick) inset;
212214
}
@@ -228,7 +230,7 @@
228230

229231
&[disabled],
230232
&:disabled {
231-
color: var(--slds-g-color-neutral-base-50, #{$color-text-icon-default});
233+
color: var(--slds-g-color-neutral-base-50, #{$color-text-icon-default});
232234
}
233235
}
234236

0 commit comments

Comments
 (0)