Skip to content

Commit 4a936d2

Browse files
Fix(accessibility) fix sa11y accessibility issue for popovers (#5143)
* Fixed Aria label attr * cleaning code * cleaning code * Fixed the release number * Updated release notes * removed unreachable null * removed fallback aria label * Updated the release note * changed title --------- Co-authored-by: Manjunath Kalburgi <[email protected]>
1 parent 7a07105 commit 4a936d2

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

ui/components/popovers/RELEASENOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55

66
### Added button to the story `body-max-height-small` to fix scrollable-region-focusable wcag issue.
77

8+
### Added
9+
10+
- Added `title` attribute to meet accessibility requirements.
11+
812
## 2.19
913

1014
### Fixed

ui/components/popovers/base/example.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ export let examples = [
415415
id: 'dark-base',
416416
label: 'Base [dark]',
417417
element: (
418-
<Popover className="slds-popover_dark slds-nubbin_left" closeButton>
418+
<Popover className="slds-popover_dark slds-nubbin_left" title="Popover Title" closeButton>
419419
<p>
420420
Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do
421421
eiusmod tempor incididunt ut labore et dolore magna aliqua.

0 commit comments

Comments
 (0)