Skip to content

Commit 4c4f061

Browse files
authored
chore(dynamic icons): color updates (#4946)
1 parent 5da7cc6 commit 4c4f061

File tree

14 files changed

+125
-59
lines changed

14 files changed

+125
-59
lines changed

RELEASENOTES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@
7272
#### Fixed
7373
- Fixed missing attribute `required` on date input
7474

75+
### [Dynamic Icons](https://www.lightningdesignsystem.com/components/dynamic-icons)
76+
#### Changed
77+
- Updated dynamic icon colors to match new Salesforce color palettes.
78+
7579
### [Icons](https://www.lightningdesignsystem.com/components/icons)
7680
#### Removed
7781
- Removed outdated documentation about changing background color, as this contradicts current Design System guidelines.

ui/components/dynamic-icons/RELEASENOTES.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,8 @@
55
<!-- ## [Unreleased] -->
66

77
<!-- ## [VERSION] -->
8+
9+
## 2.17.0
10+
11+
### Changed
12+
- Updated dynamic icon colors to match new Salesforce color palettes.

ui/components/dynamic-icons/ellie/_index.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ $_ellie-frameset: (
7171
svg {
7272
width: $_ellie-sprite-width;
7373
vertical-align: top;
74-
color: #00a0e3;
74+
color: $palette-cloud-blue-60;
7575
}
7676

7777
circle:nth-child(2n + 1) {
@@ -81,8 +81,8 @@ $_ellie-frameset: (
8181
}
8282

8383
circle:nth-child(2n) {
84-
fill: $color-gray-1;
85-
stroke: $color-gray-1;
84+
fill: $palette-neutral-100;
85+
stroke: $palette-neutral-100;
8686
stroke-width: 1px;
8787
}
8888
}

ui/components/dynamic-icons/ellie/example.jsx

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,24 @@ import Ellie from './';
88
Exports
99
----------------------------------------------------------------------------- */
1010

11-
export default (
12-
<Ellie
13-
className="slds-is-animated"
14-
title="Description of the icon"
15-
assistiveText="Text alternative"
16-
/>
17-
);
11+
export default [
12+
{
13+
id: 'default',
14+
label: 'Ellie – default',
15+
element: (
16+
<Ellie
17+
className="slds-is-animated"
18+
title="Description of the icon"
19+
assistiveText="Text alternative"
20+
/>
21+
)
22+
}
23+
];
1824

1925
export let states = [
2026
{
2127
id: 'paused',
22-
label: 'Paused',
28+
label: 'Ellie – Paused',
2329
element: (
2430
<Ellie
2531
className="slds-is-animated slds-is-paused"
@@ -30,7 +36,7 @@ export let states = [
3036
},
3137
{
3238
id: 'static',
33-
label: 'Static (no animation)',
39+
label: 'Ellie – Static (no animation)',
3440
element: (
3541
<Ellie title="Description of the icon" assistiveText="Text alternative" />
3642
)

ui/components/dynamic-icons/eq/example.jsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,12 @@ import EqIcon from './';
88
Exports
99
----------------------------------------------------------------------------- */
1010

11-
export default <EqIcon />;
11+
export default [
12+
{
13+
id: 'default',
14+
label: 'EQ – default',
15+
element: (
16+
<EqIcon />
17+
)
18+
}
19+
];

ui/components/dynamic-icons/global-action-help/example.jsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,12 @@ import GlobalActionHelp from './';
88
Exports
99
----------------------------------------------------------------------------- */
1010

11-
export default <GlobalActionHelp />;
11+
export default [
12+
{
13+
id: 'default',
14+
label: 'Global Action Help - Default',
15+
element: (
16+
<GlobalActionHelp />
17+
)
18+
}
19+
];

ui/components/dynamic-icons/score/_index.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
* @restrict .slds-icon-score svg
3535
*/
3636
.slds-icon-score__positive {
37-
fill: #30a664;
38-
stroke: #30a664;
37+
fill: $color-background-success-dark;
38+
stroke: $color-background-success-dark;
3939
}
4040

4141
/**
@@ -46,7 +46,7 @@
4646
*/
4747
.slds-icon-score__negative {
4848
fill: transparent;
49-
stroke: #d2504c;
49+
stroke: $color-background-destructive;
5050
}
5151

5252
[data-slds-state="positive"] .slds-icon-score__positive,

ui/components/dynamic-icons/score/example.jsx

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,26 @@ import Score from './';
88
Exports
99
----------------------------------------------------------------------------- */
1010

11-
// Default
12-
export default <Score data-slds-state="positive" />;
11+
export default [
12+
{
13+
id: 'default',
14+
label: 'Score – default',
15+
element: (
16+
<Score data-slds-state="positive" />
17+
)
18+
}
19+
];
1320

1421
// States
1522
export let states = [
1623
{
1724
id: 'positive',
18-
label: 'Positive',
25+
label: 'Score – Positive',
1926
element: <Score data-slds-state="positive" />
2027
},
2128
{
2229
id: 'negative',
23-
label: 'Negative',
30+
label: 'Score – Negative',
2431
element: <Score data-slds-state="negative" />
2532
}
2633
];

ui/components/dynamic-icons/strength/_index.scss

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
circle { // 1
2828
stroke-width: 0.95px;
2929
fill: transparent;
30-
stroke: #ccc;
30+
stroke: $palette-neutral-60;
3131
transition: // 2
3232
fill 0.4s ease-in-out,
3333
stroke 0.4s ease-in-out;
@@ -51,8 +51,8 @@
5151
&[data-slds-strength="3"] circle:nth-child(1),
5252
&[data-slds-strength="3"] circle:nth-child(2),
5353
&[data-slds-strength="3"] circle:nth-child(3) {
54-
fill: #04844b;
55-
stroke: #04844b;
54+
fill: $color-text-success;
55+
stroke: $color-text-success;
5656
}
5757

5858
&[data-slds-strength="-1"] circle:nth-child(1),
@@ -61,8 +61,8 @@
6161
&[data-slds-strength="-3"] circle:nth-child(1),
6262
&[data-slds-strength="-3"] circle:nth-child(2),
6363
&[data-slds-strength="-3"] circle:nth-child(3) {
64-
fill: #ffdde1;
65-
stroke: #c23934;
64+
fill: $palette-pink-90;
65+
stroke: $color-background-error-dark;
6666
}
6767

6868
/**
@@ -126,11 +126,11 @@
126126
// Improve readability of animations
127127
// stylelint-disable
128128
@keyframes slds-icon-strength-positive-load {
129-
0% { fill: transparent; stroke: #ccc; }
130-
100% { fill: #04844b; stroke: #04844b; }
129+
0% { fill: transparent; stroke: $palette-neutral-60; }
130+
100% { fill: $color-text-success; stroke: $color-text-success; }
131131
}
132132

133133
@keyframes slds-icon-strength-negative-load {
134-
0% { fill: transparent; stroke: #ccc; }
135-
100% { fill: #ffdde1; stroke: #c23934; }
134+
0% { fill: transparent; stroke: $palette-neutral-60; }
135+
100% { fill: $palette-pink-90; stroke: $color-background-destructive; }
136136
}

ui/components/dynamic-icons/strength/example.jsx

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,15 @@ import Strength from './';
99
----------------------------------------------------------------------------- */
1010

1111
// Default
12-
export default <Strength data-slds-strength="0" />;
12+
export default [
13+
{
14+
id: 'default',
15+
label: 'Strength – default',
16+
element: (
17+
<Strength data-slds-strength="0" />
18+
)
19+
}
20+
];
1321

1422
// States
1523
export let states = [
@@ -45,17 +53,17 @@ export let states = [
4553
},
4654
{
4755
id: 'animated',
48-
label: 'Animated on load',
56+
label: 'Strength – Animated on load',
4957
element: <Strength className="slds-is-animated" data-slds-strength="3" />
5058
},
5159
{
5260
id: 'animated-negative',
53-
label: 'Animated on load (negative)',
61+
label: 'Strength – Animated on load (negative)',
5462
element: <Strength className="slds-is-animated" data-slds-strength="-3" />
5563
},
5664
{
5765
id: 'paused',
58-
label: 'Paused',
66+
label: 'Strength – Paused',
5967
element: (
6068
<Strength
6169
className="slds-is-animated slds-is-paused"

0 commit comments

Comments
 (0)