Skip to content

Commit 4d2600a

Browse files
authored
chore(modals): React example cleanup (#4942)
1 parent fc9a8ca commit 4d2600a

File tree

8 files changed

+8
-9
lines changed

8 files changed

+8
-9
lines changed

ui/components/docked-composer/__tests__/__snapshots__/index.spec.js.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,6 @@ exports[`renders a docked composer with popout 1`] = `
703703
aria-labelledby="dialog-heading-id-1"
704704
aria-modal="true"
705705
className="slds-modal slds-fade-in-open slds-docked-composer-modal"
706-
closeButton="false"
707706
role="dialog"
708707
tabIndex="-1"
709708
>

ui/components/docked-composer/__tests__/index.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ it('renders a docked composer with popout', () =>
8484
className="slds-docked-composer-modal"
8585
aria-labelledby={dialogHeadingId}
8686
aria-describedby={dialogBodyId}
87-
closeButton="false"
87+
closeButton={false}
8888
>
8989
<ModalContent id="modal-content-id">
9090
<DockedComposerPanel footer={<Footer />} nestedDialog>

ui/components/docked-composer/base/example.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ export let states = [
333333
className="slds-docked-composer-modal"
334334
aria-labelledby={dialogHeadingId}
335335
aria-describedby={dialogBodyId}
336-
closeButton="false"
336+
closeButton={false}
337337
>
338338
<ModalContent id="modal-content-id">
339339
<DockedComposerPanel footer={<Footer />} nestedDialog>

ui/components/modals/base/_deprecate.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
}
4141

4242
@include deprecate('4.0.0', 'Please move slds-modal__close outside modal header') {
43+
4344
.slds-modal__header .slds-modal__close {
4445
position: absolute;
4546
top: ($square-icon-medium-boundary * -1.25);

ui/components/prompt/__tests__/__snapshots__/index.spec.js.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ exports[`Prompt renders a default prompt 1`] = `
1414
aria-labelledby="prompt-heading-id"
1515
aria-modal="true"
1616
className="slds-modal slds-fade-in-open slds-modal_prompt"
17-
closeButton="false"
1817
role="alertdialog"
1918
tabIndex="0"
2019
>

ui/components/prompt/base/example.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export default (
1919
aria-labelledby="prompt-heading-id"
2020
aria-describedby="prompt-message-wrapper"
2121
className="slds-modal_prompt"
22-
closeButton="false"
22+
closeButton={false}
2323
>
2424
<ModalHeader
2525
className="slds-theme_error slds-theme_alert-texture"

ui/touch/forms/edit-dialog/example.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const inputId09 = 'input-id-09';
2424
export default (
2525
<div className="demo-only" style={{ height: '640px' }}>
2626
<Modal className="slds-modal_form">
27-
<ModalHeader closeButton="false">
27+
<ModalHeader closeButton={false}>
2828
<button className="slds-button slds-button_neutral">Cancel</button>
2929
<button className="slds-button slds-button_neutral">Save</button>
3030
<h1

ui/touch/notifications/prompt/example.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export let states = [
4242
element: (
4343
<div className="demo-only" style={{ height: '640px' }}>
4444
<Backdrop>
45-
<Modal closeButton="false">
45+
<Modal closeButton={false}>
4646
<ModalHeader>
4747
<h1 className="slds-text-heading_medium">
4848
Select a New Record Type
@@ -70,7 +70,7 @@ export let states = [
7070
element: (
7171
<div className="demo-only" style={{ height: '640px' }}>
7272
<Backdrop>
73-
<Modal closeButton="false">
73+
<Modal closeButton={false}>
7474
<ModalHeader>
7575
<h1 className="slds-text-heading_medium">Delete Account</h1>
7676
<p className="slds-m-top_x-small">
@@ -94,7 +94,7 @@ export let states = [
9494
element: (
9595
<div className="demo-only" style={{ height: '640px' }}>
9696
<Backdrop>
97-
<Modal closeButton="false">
97+
<Modal closeButton={false}>
9898
<ModalHeader>
9999
<span className="slds-icon_container slds-icon-action-share-thanks slds-m-bottom_x-small">
100100
<SvgIcon

0 commit comments

Comments
 (0)