Skip to content

Commit 6450f87

Browse files
authored
fix(combobox): Revert some styles in combobox form element and faux input (#4822)
* add width: 100% to slds-combobox__form-element * remove faux-input width, remove display:flex on slds-combobox__form-element * add release notes
1 parent 5b3f62d commit 6450f87

File tree

5 files changed

+23
-5
lines changed

5 files changed

+23
-5
lines changed

RELEASENOTES.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
<!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
22
<!-- !!! THIS FILE IS AUTO-GENERATED !!! DO NOT EDIT THIS FILE MANUALLY !!! -->
33

4+
## Release 2.16.2 - September 22, 2021
5+
6+
## Components
7+
### [Combobox](https://www.lightningdesignsystem.com/components/combobox)
8+
## Removed
9+
- Removed `display: flex` property from `.slds-combobox__form-element` which was added recently for ARIA 1.2 guidance.
10+
11+
### [Input](https://www.lightningdesignsystem.com/components/input)
12+
## Removed
13+
- Removed `width` property from `.slds-input_faux` which was added recently for ARIA 1.2 guidance.
14+
415
## Release 2.16.1 - August 25, 2021
516

617
## Release 2.16.0 - August 12, 2021

ui/components/combobox/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.16.2
8+
9+
## Removed
10+
11+
- Removed `display: flex` property from `.slds-combobox__form-element` which was added recently for ARIA 1.2 guidance.
12+
713
## 2.16.0
814

915
### Changed

ui/components/combobox/base/_index.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@
7878
* @restrict .slds-combobox > div
7979
*/
8080
.slds-combobox__form-element {
81-
display: flex;
8281
flex: 1 1 auto;
8382
}
8483

ui/components/input/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.16.2
8+
9+
## Removed
10+
11+
- Removed `width` property from `.slds-input_faux` which was added recently for ARIA 1.2 guidance.
12+
713
## 2.16.0
814

915
### Added

ui/components/input/base/_index.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,10 +120,6 @@
120120
flex: 1 1 auto;
121121
text-align: left;
122122

123-
@include mq-small-min {
124-
width: rem(146px); // estimated magic number to match input's inherent width in Chrome
125-
}
126-
127123
&.slds-is-disabled {
128124
@include input-disabled;
129125
}

0 commit comments

Comments
 (0)