Skip to content

Commit 6e95826

Browse files
authored
fix(tests): Test updates and lint fixes (#4668)
* fix lint * update page-header tests * update lookup tests * update list-builder tests
1 parent 36e7d79 commit 6e95826

File tree

4 files changed

+21
-1
lines changed

4 files changed

+21
-1
lines changed

ui/components/buttons/stateful/example.jsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ export let StatefulButton = props => {
1616
isSelectedClicked
1717
} = props;
1818
const [buttonSelected, setButtonSelected] = useState(
19-
isSelected || isSelectedClicked
19+
(typeof isNotSelected !== 'undefined' &&
20+
Boolean(isNotSelected) === false) ||
21+
isSelected ||
22+
isSelectedClicked
2023
);
2124
const [buttonFocused, setButtonFocused] = useState(isSelectedClicked);
2225

ui/components/list-builder/__tests__/__snapshots__/index.spec.js.snap

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ exports[`List Builder Inline Edit renders a default list builder with inline edi
6363
className="slds-scrollable"
6464
>
6565
<table
66+
aria-label="Example product list"
6667
className="slds-table slds-table_fixed-layout slds-table_bordered slds-no-row-hover slds-table_cell-buffer"
6768
role="grid"
6869
>
@@ -908,6 +909,7 @@ exports[`List Builder renders a default list builder 1`] = `
908909
className="slds-scrollable_none"
909910
>
910911
<table
912+
aria-label="Example product list"
911913
aria-multiselectable="true"
912914
className="slds-table slds-no-row-hover slds-table_bordered slds-table_fixed-layout slds-table_resizable-cols"
913915
role="grid"
@@ -2156,6 +2158,7 @@ exports[`List Builder renders a list builder with default items disabled 1`] = `
21562158
className="slds-scrollable_none"
21572159
>
21582160
<table
2161+
aria-label="Example product list"
21592162
aria-multiselectable="true"
21602163
className="slds-table slds-no-row-hover slds-table_bordered slds-table_fixed-layout slds-table_resizable-cols"
21612164
role="grid"
@@ -3484,6 +3487,7 @@ exports[`List Builder renders a list builder with filtered results 1`] = `
34843487
className="slds-scrollable_none"
34853488
>
34863489
<table
3490+
aria-label="Example product list"
34873491
aria-multiselectable="true"
34883492
className="slds-table slds-no-row-hover slds-table_bordered slds-table_fixed-layout slds-table_resizable-cols"
34893493
role="grid"
@@ -4109,6 +4113,7 @@ exports[`List Builder renders a list builder with hidden header 1`] = `
41094113
className="slds-scrollable_none"
41104114
>
41114115
<table
4116+
aria-label="Example single column product list"
41124117
aria-multiselectable="true"
41134118
className="slds-table slds-table_header-hidden slds-no-row-hover slds-table_bordered"
41144119
role="grid"
@@ -4894,6 +4899,7 @@ exports[`List Builder renders a list builder with items disabled 1`] = `
48944899
className="slds-scrollable_none"
48954900
>
48964901
<table
4902+
aria-label="Example product list"
48974903
aria-multiselectable="true"
48984904
className="slds-table slds-no-row-hover slds-table_bordered slds-table_fixed-layout slds-table_resizable-cols"
48994905
role="grid"
@@ -6192,6 +6198,7 @@ exports[`List Builder renders a list builder with items selected 1`] = `
61926198
className="slds-scrollable_none"
61936199
>
61946200
<table
6201+
aria-label="Example product list"
61956202
aria-multiselectable="true"
61966203
className="slds-table slds-no-row-hover slds-table_bordered slds-table_fixed-layout slds-table_resizable-cols"
61976204
role="grid"

ui/components/lookups/__tests__/__snapshots__/index.spec.js.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ exports[`Lookup - Advanced Modal renders a lookup with modal 1`] = `
9393
</div>
9494
</div>
9595
<table
96+
aria-label="Example table for advanced modal lookup"
9697
className="slds-table slds-table_bordered slds-table_cell-buffer slds-no-row-hover"
9798
id="lookup-grouped-table-id-1"
9899
role="listbox"

ui/components/page-headers/__tests__/__snapshots__/snapshot.spec.js.snap

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -841,8 +841,11 @@ exports[`Renders a page header renders deprecated record home page header 1`] =
841841
>
842842
<button
843843
aria-live="assertive"
844+
aria-pressed="false"
844845
className="slds-button slds-button_neutral slds-button_stateful slds-not-selected"
846+
onBlur={[Function]}
845847
onClick={[Function]}
848+
onFocus={[Function]}
846849
>
847850
<span
848851
className="slds-text-not-selected"
@@ -1912,8 +1915,11 @@ exports[`Renders a page header renders record home page header 1`] = `
19121915
>
19131916
<button
19141917
aria-live="assertive"
1918+
aria-pressed="false"
19151919
className="slds-button slds-button_neutral slds-button_stateful slds-not-selected"
1920+
onBlur={[Function]}
19161921
onClick={[Function]}
1922+
onFocus={[Function]}
19171923
>
19181924
<span
19191925
className="slds-text-not-selected"
@@ -2449,8 +2455,11 @@ exports[`Renders a page header renders vertical record home page header 1`] = `
24492455
>
24502456
<button
24512457
aria-live="assertive"
2458+
aria-pressed="false"
24522459
className="slds-button slds-button_neutral slds-button_stateful slds-not-selected"
2460+
onBlur={[Function]}
24532461
onClick={[Function]}
2462+
onFocus={[Function]}
24542463
>
24552464
<span
24562465
className="slds-text-not-selected"

0 commit comments

Comments
 (0)