Merge tag 'v2.21.0' of github.com:salesforce-ux/design-system-internal into opensource-summer-23

Author: Dottenpixel

.github/actions/set-heroku-app-name/action.yml

@@ -7,8 +7,18 @@ outputs:
 runs:
   using: composite
   steps:
+  - name: Print context
+    env:
+      GITHUB_CONTEXT: ${{ toJson(github) }}
+    run: |
+      echo "$GITHUB_CONTEXT"
+    shell: bash
   - name: Set which app to deploy to on Heroku
     id: which-app
+    env:
+      HEROKU_APP_UPCOMING: upcoming-doc-site
+      HEROKU_APP_CORE_MAIN: core-main-doc-site
+      HEROKU_APP_CORE_PATCH: core-patch-doc-site
     # if on default branch without a tag
     #   then publish to UPCOMING
     #
@@ -20,19 +30,18 @@ runs:
     #
     # All other cases publish to the review app
     run: |-
-      export CURRENT_DEFAULT_BRANCH=`git remote show origin | grep "HEAD branch" | cut -d ":" -f 2 | xargs`
       echo 'HEROKU_RELEASE_STORYBOOK_APP_NAME=false' >> $GITHUB_OUTPUT
-      if [[ "${{ github.ref }}" = "${CURRENT_DEFAULT_BRANCH}" ]] ; then
+      if [[ "${{ github.ref_name }}" = "${{ github.event.repository.default_branch }}" ]] ; then
         echo "Publishing to UPCOMING..."
-        echo 'HEROKU_APP_NAME=${HEROKU_APP_UPCOMING}' >> $GITHUB_OUTPUT
+        echo 'HEROKU_APP_NAME=${{ env.HEROKU_APP_UPCOMING }}' >> $GITHUB_OUTPUT
         echo 'HEROKU_RELEASE_STORYBOOK_APP_NAME=storybook-upcoming' >> $GITHUB_OUTPUT
-      elif [[ ${{ github.ref }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+-.+$ ]] ; then
+      elif [[ ${{ github.ref_name }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+-.+$ ]] ; then
         echo "Publishing to CORE-MAIN..."
-        echo 'HEROKU_APP_NAME=${HEROKU_APP_CORE_MAIN}' >> $GITHUB_OUTPUT
+        echo 'HEROKU_APP_NAME=${{ env.HEROKU_APP_CORE_MAIN }}' >> $GITHUB_OUTPUT
         echo 'HEROKU_RELEASE_STORYBOOK_APP_NAME=storybook-core-main' >> $GITHUB_OUTPUT
-      elif [[ ${{ github.ref }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]] ; then
+      elif [[ ${{ github.ref_name }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]] ; then
         echo "Publishing to CORE-PATCH..."
-        echo 'HEROKU_APP_NAME=${HEROKU_APP_CORE_PATCH}' >> $GITHUB_OUTPUT
+        echo 'HEROKU_APP_NAME=${{ env.HEROKU_APP_CORE_PATCH }}' >> $GITHUB_OUTPUT
         echo 'HEROKU_RELEASE_STORYBOOK_APP_NAME=storybook-core-patch' >> $GITHUB_OUTPUT
       else
         echo "Publishing to pull-request review app..."
@@ -62,4 +71,4 @@ runs:
       cat workspace/heroku-release-storybook-app-name.txt
       echo "============================================="
       echo
-    shell: bash
+    shell: bash

.github/workflows/remove-labels.yml

@@ -11,4 +11,5 @@ jobs:
         with:
           labels: |
             vrt:chrome-ready
+            vrt:mobile-ready
             vrt:full-ready

.github/workflows/storybook.yml

@@ -1,6 +1,12 @@
 name: Make Review Apps
 
-on: pull_request
+on:
+  release:
+    types: [released, prereleased]
+  pull_request:
+    branches: [ '**' ]
+  push:
+    branches: [ '2[0-9][02468]-*-2[0-9]' ]
 
 env:
   # APPLITOOLS_API_KEY:
@@ -10,7 +16,7 @@ env:
   # DSE_API_RELEASE_TOKEN:
   # GITHUB_PACKAGES_TOKEN:
   # GITHUB_TOKEN: ${{ github.token }}
-  HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
+  HEROKU_API_KEY: ${{ secrets.DSE_INFRA_HEROKU_API_KEY }}
 
 jobs:
   init:
@@ -87,11 +93,15 @@ jobs:
 
     - uses: "./.github/actions/copy-tokens-to-workspace"
 
-    # - run: |-HEROKU_RELEASE_STORYBOOK_APP_NAME
-    #     HEROKU_APP_NAME=${{ steps.which-heroku-app.outputs.HEROKU_APP_NAME }}
-    #     HEROKU_RELEASE_STORYBOOK_APP_NAME=${{ steps.which-heroku-app.outputs.HEROKU_RELEASE_STORYBOOK_APP_NAME }}
-    #     echo $HEROKU_APP_NAME
-    #     echo $HEROKU_RELEASE_STORYBOOK_APP_NAME
+    - name: Print destination app names
+      run: |
+        HEROKU_APP_NAME=${{ steps.which-heroku-app.outputs.HEROKU_APP_NAME }}
+        HEROKU_RELEASE_STORYBOOK_APP_NAME=${{ steps.which-heroku-app.outputs.HEROKU_RELEASE_STORYBOOK_APP_NAME }}
+        echo "=============================="
+        echo $HEROKU_APP_NAME
+        echo $HEROKU_RELEASE_STORYBOOK_APP_NAME
+        # if HEROKU_RELEASE_STORYBOOK_APP_NAME is "true", then we are in a PR
+        echo "=============================="
 
     - name: Compile styles
       run: npm run gulp -- styles
@@ -138,6 +148,8 @@ jobs:
 
     - name: Build static Storybook
       run: npm run storybook:build
+      env:
+        NODE_OPTIONS: --openssl-legacy-provider # per https://candid.technology/error-error-0308010c-digital-envelope-routines-unsupported/
 
     - name: Archive static Storybook
       run: tar -czvf workspace/storybook.tar.gz .www/ Procfile config/nginx.conf.erb heroku-start.sh app.json
@@ -147,7 +159,7 @@ jobs:
         path: workspace/storybook.tar.gz
 
   publish-storybook:
-    if: ${{ needs.prepare.outputs.HEROKU_RELEASE_STORYBOOK_APP_NAME == 'true' }}
+    if: ${{ needs.prepare.outputs.HEROKU_RELEASE_STORYBOOK_APP_NAME != 'false' }}
     runs-on: ubuntu-latest
     needs:
       - init
@@ -241,6 +253,9 @@ jobs:
       - run: npm ci
       - name: Do build-dist
         run: npm run build-dist
+        env:
+          NODE_OPTIONS: --openssl-legacy-provider # per https://candid.technology/error-error-0308010c-digital-envelope-routines-unsupported/
+
       - name: Compress .dist
         run: |-
           tar -cvf workspace/design-system-dist.tar .dist/
@@ -303,6 +318,8 @@ jobs:
         run: npm run build
         env:
           SLDS__FRAMEWORK__PATH: ".slds/.dist/"
+          NODE_OPTIONS: --openssl-legacy-provider # per https://candid.technology/error-error-0308010c-digital-envelope-routines-unsupported/
+
       - name: Display structure of downloaded files
         run: ls -la
       - name: Generate site tarball

.github/workflows/vrt.yml

@@ -1,4 +1,4 @@
-name: Trigger VRT from Label
+name: VRT Triggered from Label
 
 on:
   pull_request:
@@ -15,7 +15,7 @@ env:
 
 jobs:
   vrt-init:
-    if: ${{ github.event.label.name == 'vrt:chrome-ready' || github.event.label.name == 'vrt:full-ready'}}
+    if: startsWith(github.event.label.name, 'vrt:')
     runs-on: ubuntu-latest
 
     steps:
@@ -36,6 +36,7 @@ jobs:
           cache: 'npm'
 
   vrt-desktop:
+    if: contains(fromJSON('["vrt:full-ready", "vrt:chrome-ready"]'), github.event.label.name)
     needs: vrt-init
     runs-on: ubuntu-latest
 
@@ -62,10 +63,12 @@ jobs:
 
       - name: Applitools
         run: 'VRT_MODE=${{ env.VRT_MODE }} npx eyes-storybook'
-        timeout-minutes: 20
+        timeout-minutes: 60
+        env:
+          NODE_OPTIONS: --openssl-legacy-provider # per https://candid.technology/error-error-0308010c-digital-envelope-routines-unsupported/
 
   vrt-legacy:
-    if: ${{ github.event.label.name == 'vrt:full-ready'}}
+    if: contains(fromJSON('["vrt:full-ready"]'), github.event.label.name)
     needs: vrt-init
     runs-on: ubuntu-latest
 
@@ -93,10 +96,12 @@ jobs:
 
       - name: Applitools
         run: 'STORYBOOK_SLDS_VERSION=legacy npx eyes-storybook --conf applitools.legacy.config.js' # -u https://${REVIEW_APP_NAME}.herokuapp.com
-        timeout-minutes: 20
+        timeout-minutes: 60
+        env:
+          NODE_OPTIONS: --openssl-legacy-provider # per https://candid.technology/error-error-0308010c-digital-envelope-routines-unsupported/
 
   vrt-mobile:
-    if: ${{ github.event.label.name == 'vrt:full-ready'}}
+    if: contains(fromJSON('["vrt:full-ready", "vrt:mobile-ready"]'), github.event.label.name)
     needs: vrt-init
     runs-on: ubuntu-latest
 
@@ -124,11 +129,13 @@ jobs:
 
       - name: Applitools
         run: 'STORYBOOK_SLDS_VERSION=mobile npx eyes-storybook --conf applitools.mobile.config.js' # -u https://${REVIEW_APP_NAME}.herokuapp.com
-        timeout-minutes: 20
+        timeout-minutes: 60
+        env:
+          NODE_OPTIONS: --openssl-legacy-provider # per https://candid.technology/error-error-0308010c-digital-envelope-routines-unsupported/
 
   vrt-wrap:
     needs: [vrt-desktop, vrt-legacy, vrt-mobile]
-    if: always() && !cancelled() && !contains(needs.*.result, 'failure')
+    if: startsWith(github.event.label.name, 'vrt:') && always() && !cancelled() && !contains(needs.*.result, 'failure')
     runs-on: ubuntu-latest
     env:
       APPLITOOLS_API_KEY: ${{ secrets.APPLITOOLS_API_KEY }}
@@ -150,7 +157,9 @@ jobs:
 
       - name: Dump GitHub context event
         id: github_context_event_step
-        run: echo '${{ toJSON(github.event) }}'
+        env:
+          GITHUB_EVENT_CONTEXT: ${{ toJson(github.event) }}
+        run: echo "$GITHUB_EVENT_CONTEXT"
 
       - name: Show GitHub context
         env:
@@ -176,4 +185,4 @@ jobs:
           GH_APP_CLIENT_ID: Iv1.6aaf118377862b49
           GH_APP_CLIENT_SECRET: ${{ secrets.DSE_CI_CLIENT_SECRET }}
         # single quotes are needed around the JSON string here so that is can be parsed by the node script
-        run: batchesData='${{ steps.applitools_batch.outputs.batches }}' node scripts/ci/pr-checks
+        run: batchesData='${{ steps.applitools_batch.outputs.batches }}' node scripts/ci/pr-checks

.nvmrc

@@ -1 +1 @@
-14
+16

RELEASENOTES.general.md

@@ -2,9 +2,53 @@
 <!-- On release, add general notes here. In time the legacy release notes will be add to this -->
 
 
+## 2.21.0 - April 20, 2023
+
+## Fixed
+
+- Update transparency values (rgba and design tokens) with transparent SLDS global styling hooks
+- Changed anchor link ouline border black color to blue-50
+- Updated background colors for Standard and Actions icons
+- Updated icons to `v10.6.0`
+  - Standard Set:
+    - Added `bill_of_materials`
+    - Added `buyer_group_qualifier`
+    - Added `datashare_target`
+    - Added `datashares`
+    - Added `disclosure_and_compliance`
+    - Added `document_preview`
+    - Added `facility_bed`
+    - Added `market`
+    - Added `price_sheet`
+    - Added `mulesoft`
+
+  - Utility Set:
+    - Added `add_source`
+    - Added `app_web_messaging`
+    - Added `bookmark_stroke`
+    - Added `buyer_group_qualifier`
+    - Added `document_preview`
+    - Added `expired`
+    - Added `favorite_alt`
+    - Added `heart`
+    - Added `hourglass`
+    - Added `integration`
+    - Added `market`
+    - Added `more`
+    - Added `notification_off`
+    - Added `notification_snoozed`
+    - Added `profile_alt`
+    - Added `promotion_tiers`
+    - Added `sender_email`
+    - Added `service_appointment`
+    - Added `service_report`
+    - Added `toggle_off`
+    - Added `toggle_on`
+    - Added `mulesoft`
+
 ## 2.20.1 - December 16, 2022
 
-- Updated colors for verious components:
+- Updated colors for various components:
   - Button Icons
   - Carousel
   - Checkbox Button