Skip to content

Commit 84a1562

Browse files
laurensuhSang Kyung Suh
andauthored
fix (form-elements): right to left formatting (#5027)
Co-authored-by: Sang Kyung Suh <[email protected]>
1 parent 8c3bf9e commit 84a1562

File tree

7 files changed

+37
-7
lines changed

7 files changed

+37
-7
lines changed

RELEASENOTES.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,15 @@
1414
#### Changed
1515
- Removed `vertical-align` from button non-base variants to create vertical alignment consistency among all the buttons.
1616

17+
### [Checkbox](https://www.lightningdesignsystem.com/components/checkbox)
18+
#### Fixed
19+
- Right to left legend to be right aligned and match the alignment of content.
20+
- Checkbox margin to properly support RTL.
21+
22+
### [Form Element](https://www.lightningdesignsystem.com/components/form-element)
23+
#### Fixed
24+
- Fixed form element label to support RTL layout by removing left aligned spacing and placing it back on the opposite side.
25+
1726
### [Modals](https://www.lightningdesignsystem.com/components/modals)
1827
#### Changed
1928
- Added `slds-modal__content_footless` class to example for clarity.

ui/components/checkbox/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.18.0
8+
9+
### Fixed
10+
- Right to left legend to be right aligned and match the alignment of content.
11+
- Checkbox margin to properly support RTL.
12+
713
## 2.17.5
814

915
### Fixed

ui/components/checkbox/base/_index.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,4 +209,12 @@
209209
.slds-form-element .slds-checkbox [type="checkbox"] + .slds-checkbox__label .slds-checkbox_faux,
210210
.slds-form-element .slds-checkbox [type="checkbox"] + .slds-checkbox__label .slds-checkbox--faux {
211211
margin-right: $spacing-x-small;
212+
213+
@include rtl() {
214+
/*! @noflip */
215+
margin-right: 0;
216+
217+
/*! @noflip */
218+
margin-left: $spacing-x-small;
219+
}
212220
}

ui/components/form-element/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
# Form Element Release Notes
44

55
<!-- ## [Unreleased] -->
6+
7+
## 2.18.0
8+
9+
### Fixed
10+
- Fixed form element label to support RTL layout by removing left aligned spacing and placing it back on the opposite side.
11+
612
## 2.16.0
713

814
### Fixed

ui/components/form-element/base/_index.scss

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@
2929
margin-bottom: $spacing-xxx-small;
3030

3131
@include rtl() {
32+
/*! @noflip */
33+
padding-right: 0;
34+
3235
/*! @noflip */
3336
padding-left: $spacing-x-small;
3437
}

ui/components/form-element/stacked/_index.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,11 @@
5252
width: 100%;
5353
flex-basis: 100%;
5454
clear: left;
55+
56+
@include rtl() {
57+
/*! @noflip */
58+
clear: right;
59+
}
5560
}
5661

5762
.slds-form-element__icon {

ui/components/radio-group/base/_index.scss

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,3 @@
158158
margin-left: $spacing-x-small;
159159
}
160160
}
161-
162-
.slds-radio .slds-form-element__label {
163-
@include rtl() {
164-
/*! @noflip */
165-
padding-right: 0;
166-
}
167-
}

0 commit comments

Comments
 (0)