Skip to content

Commit b2231ef

Browse files
authored
fix(tabs): add role to indicator dots for Sa11y tests (#5045)
1 parent d778c25 commit b2231ef

File tree

5 files changed

+26
-0
lines changed

5 files changed

+26
-0
lines changed

RELEASENOTES.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
<!-- Release notes authoring guidelines: http://keepachangelog.com/ -->
22
<!-- !!! THIS FILE IS AUTO-GENERATED !!! DO NOT EDIT THIS FILE MANUALLY !!! -->
33

4+
## Release 2.19.0 - April 12, 2022
5+
6+
## Components
7+
### [Global Navigation](https://www.lightningdesignsystem.com/components/global-navigation)
8+
#### Added
9+
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`
10+
11+
### [Tabs](https://www.lightningdesignsystem.com/components/tabs)
12+
#### Added
13+
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`
14+
415
## Release 2.18.0 - Upcoming
516

617
- Removed `&_` shorthand from numerous selectors in SCSS files

ui/components/global-navigation/RELEASENOTES.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.19.0
8+
9+
### Added
10+
11+
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`
12+
13+
714
## 2.13.0
815

916
### Changed

ui/components/global-navigation/index.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export const IndicatorUnread = props => (
2727
aria-label="New Activity"
2828
className="slds-indicator_unread"
2929
title="New Activity"
30+
role="img"
3031
/>
3132
);
3233

ui/components/tabs/RELEASENOTES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@
44

55
<!-- ## [Unreleased] -->
66

7+
## 2.19.0
8+
9+
### Added
10+
11+
- Added `role="img"` to unread indicator dot to comply with accessibility usage rules for `aria-label`
12+
713
## 2.17.0
814

915
### Added

ui/components/tabs/docs.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ Unread tabs receive a red dot on the tab.
245245
aria-label="New Activity"
246246
className="slds-indicator_unread"
247247
title="New Activity"
248+
role="img"
248249
/>
249250
</CodeBlock>
250251

0 commit comments

Comments
 (0)